Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of cmarcelk@gmail.com designates
 209.85.213.48 as permitted sender)
From: Marcel Kinard <cmarcelk@gmail.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_B9153A75-3838-43C0-B29F-26CB56B79D6B"
Message-Id: <DDDAD533-01DA-462B-8B90-C6D23BA15BF4@gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: We need better contributions from new people
Date: Thu, 13 Jun 2013 11:02:26 -0400
References: 
 <CAOBL_k7Y4=jFKSxytL15-F88qK3hsP9ChvoQKB2C+ppaLxMnaA@mail.gmail.com>
 <CAK_TSX+JHapBGLCXXGzpLJPrj7BCNVBcNB8dKWOOVctNELjG0A@mail.gmail.com>
 <CAEeF2TdkcCUV7apgAWS4u=CYqtFsMFzYmd=wkYeA=TW9P=CP5w@mail.gmail.com>
 <CAAzFgyiGySccfCDnBowgZB6wJEq28ryzaQK2_00ssrXs0y0Rfw@mail.gmail.com>
 <5B453437-97FC-4C57-9E54-358DDEC525D1@gmail.com>
 <CAOBL_k66g+1nvD87k2RPYLNQKAf-hXRPZNf5zrk_HO+oJY34AQ@mail.gmail.com>
To: dev@cordova.apache.org
In-Reply-To: 
 <CAOBL_k66g+1nvD87k2RPYLNQKAf-hXRPZNf5zrk_HO+oJY34AQ@mail.gmail.com>

--Apple-Mail=_B9153A75-3838-43C0-B29F-26CB56B79D6B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=iso-8859-1

On Jun 12, 2013, at 6:10 PM, Joe Bowser <bowserj@gmail.com> wrote:

> The problem with this approach is that we shouldn't rely on just
> mobile-spec for our testing...
>=20
> The fact is that on Android, if you're doing changes to the core, you
> should be running the JUnit tests included with the project...


Sounds good. So how about the following:

- the developer (contributor or committer) is responsible to test their =
own code and correct any problems before a pull request is submitted =
(contributor authored) or it lands in the stream (committer authored). =
The testing includes both verifying the function they added/touched, =
plus running the test suites to verify there are no regressions.
- When we say "run the test suites" this includes the automated tests in =
mobile-spec, the manual tests in mobile-spec and any platform-specific =
unit tests (i.e., cordova-android/test, cordova-ios/CordovaLibTests, =
etc.)
- if a pull request, the committer should sanity check the contributor's =
code. This should include at least a simple visual inspection.
- if a pull request, the committer should see that the contributor =
tested it. A simple comment in Jira should suffice, similar to how Mike =
and Lisa worked as contributors here: =
https://issues.apache.org/jira/browse/CB-3521=20

If there is consensus, I can add the above verbage to the wiki.

Do we want to go as far as the following?

- every new function and defect fix should include an automated test =
(where reasonably feasible) that lands in a test suite at the same time =
as the new function / fix.=20


--Apple-Mail=_B9153A75-3838-43C0-B29F-26CB56B79D6B--