Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 510D11047D for ; Thu, 13 Jun 2013 22:52:34 +0000 (UTC) Received: (qmail 69566 invoked by uid 500); 13 Jun 2013 22:52:34 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 69540 invoked by uid 500); 13 Jun 2013 22:52:34 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 69532 invoked by uid 99); 13 Jun 2013 22:52:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2013 22:52:34 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of simon.macdonald@gmail.com designates 209.85.220.177 as permitted sender) Received: from [209.85.220.177] (HELO mail-vc0-f177.google.com) (209.85.220.177) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2013 22:52:28 +0000 Received: by mail-vc0-f177.google.com with SMTP id hv10so7541547vcb.22 for ; Thu, 13 Jun 2013 15:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=GihctY3u19kK1uLMjT5hspZANma0oriz/Z+SWTJE56U=; b=d5G70fJ7KjC9pRM8fQEMFJJQXuLO3+F+Kb2huB3ZKhzoqtQF+lVHXqd0+fgbb/5oAN DXqlRUu0Z8dwcQQrYy4ndnzK//ZxvepvUWQRyIbvuAWv63wrBe70qdbdOV+AMzIHbTDL 5TZNKFzdIYaEtLuMUT9yl3O33Jq1tfBBsBIj7uTIUpXhSdaPu2TKPbyfmjU+VPAcPyg0 ahpfyrVuFgkz5F/i/RPYD/iI04yfJt3InForblEQBeaBQPeez67uVsLRugoHsBnVToOt qpBxfHiMIWcCQQCileaEhy1kpRAlNp/25R82leeEbvIMwOKAsXZeSfYntuxY1n870qVB cWMg== MIME-Version: 1.0 X-Received: by 10.52.0.232 with SMTP id 8mr1124216vdh.12.1371163927428; Thu, 13 Jun 2013 15:52:07 -0700 (PDT) Received: by 10.58.23.4 with HTTP; Thu, 13 Jun 2013 15:52:07 -0700 (PDT) Received: by 10.58.23.4 with HTTP; Thu, 13 Jun 2013 15:52:07 -0700 (PDT) In-Reply-To: References: Date: Thu, 13 Jun 2013 18:52:07 -0400 Message-ID: Subject: Re: Any problem with making DirectoryManager.getTempDirectoryPath public From: Simon MacDonald To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=047d7bacc79ed2c5fe04df10fac5 X-Virus-Checked: Checked by ClamAV on apache.org --047d7bacc79ed2c5fe04df10fac5 Content-Type: text/plain; charset=ISO-8859-1 There is not much in DirectoryManager maybe it should be folded into FileUtils then we wouldn't need to make as many things public. Less to doc. On Jun 13, 2013 6:05 PM, "Steven Gill" wrote: > argh, I meant for Android > > > On Thu, Jun 13, 2013 at 3:04 PM, Steven Gill > wrote: > > > Yeah. I have already done it on the 3.0.0 branch for ios. Camera plugin > > needed it. > > > > > > On Thu, Jun 13, 2013 at 3:02 PM, Tim Kim wrote: > > > >> Hey gang, > >> > >> I also need to make some function in DirectoryManager public for the > file > >> api. We cool with that too? > >> The ones in question: > >> testFileExists > >> getFreeDiskSpace > >> testSaveLocationExists > >> > >> Looking like we should definitely make DirectoryManager as a public api > >> now. > >> > >> > >> > >> On 11 June 2013 12:51, Joe Bowser wrote: > >> > >> > It's a part of plugin breakout. The main question is whether > >> > DirectoryManager should be a public API by documenting it, since a > >> > plugin needs it to function, not should we make it public. > >> > > >> > But yeah, make it public Steve! > >> > > >> > > >> > On Tue, Jun 11, 2013 at 12:48 PM, Simon MacDonald > >> > wrote: > >> > > Huh, you shouldn't need to do that as the DirectoryManager and > >> > > CameraLauncher are in the same package. I guess you are moving > >> > > CameraLauncher into it's own package, in which case go for it. > >> > > > >> > > > >> > > Simon Mac Donald > >> > > http://hi.im/simonmacdonald > >> > > > >> > > > >> > > On Tue, Jun 11, 2013 at 3:43 PM, Steven Gill < > stevengill97@gmail.com> > >> > wrote: > >> > > > >> > >> For Android. I need to make > >> > >> DirectoryManager.getTempDirectoryPath public so it can work with > the > >> > camera > >> > >> plugin. > >> > >> > >> > >> -Steve > >> > >> > >> > > >> > >> > >> > >> -- > >> Timothy Kim > >> > > > > > --047d7bacc79ed2c5fe04df10fac5--