Return-Path: 
 <dev-return-23932-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EFF4110D9E
	for <apmail-cordova-dev-archive@www.apache.org>;
 Thu, 20 Jun 2013 21:59:35 +0000 (UTC)
Received: (qmail 68187 invoked by uid 500); 20 Jun 2013 21:59:35 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 68168 invoked by uid 500); 20 Jun 2013 21:59:35 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 68160 invoked by uid 99); 20 Jun 2013 21:59:35 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jun 2013 21:59:35 +0000
X-ASF-Spam-Status: No, hits=-4.0 required=5.0
	tests=FRT_ADOBE2,RCVD_IN_DNSWL_HI,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of john.wargo@sap.com designates
 155.56.66.99 as permitted sender)
Received: from [155.56.66.99] (HELO smtpgw.sap-ag.de) (155.56.66.99)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jun 2013 21:59:31 +0000
From: "Wargo, John" <john.wargo@sap.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: Multiple plugins with the same dependencies
Thread-Topic: Multiple plugins with the same dependencies
Thread-Index: Ac5t2/7bZLQFtyUWT3W3AVx1hVuCWgAI4zyAAAJwggAAAgwRIA==
Date: Thu, 20 Jun 2013 21:59:07 +0000
Message-ID: 
 <5900F9BCB827854FB01CA94BA718810D0D1D6E4E@USPHLEMB11A.global.corp.sap>
References: 
 <5900F9BCB827854FB01CA94BA718810D0D1D3886@USPHLEMB11A.global.corp.sap>
 <CDE88C4F.211BF%fil@adobe.com>
 <CABiQX1Uie7oLLcSCTQShjGBWrpCUPE9Bzivx2ZGzm5ZU6-mYQQ@mail.gmail.com>
In-Reply-To: 
 <CABiQX1Uie7oLLcSCTQShjGBWrpCUPE9Bzivx2ZGzm5ZU6-mYQQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.4.150.15]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Virus-Checked: Checked by ClamAV on apache.org

That's what we thought - perhaps make a plugin out of the common dependency=
, but that becomes more to manage.   I'd have to install three plugins to m=
ake this work when developers are going to expect that plugman manages this=
 for them. What happens for example if two non-related plugins rely upon so=
me third party dependency?

John M. Wargo
Email: john.wargo@sap.com
Twitter: @johnwargo


-----Original Message-----
From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of Andrew Gr=
ieve
Sent: Thursday, June 20, 2013 2:56 PM
To: dev
Subject: Re: Multiple plugins with the same dependencies

I think the correct approach here would be to create a plugin that only
provides SDMCommon-2.3.0.183.jar, and then have your other plugins depend
on it.


On Thu, Jun 20, 2013 at 1:45 PM, Filip Maj <fil@adobe.com> wrote:

> The file collision checking is built in.
>
> A -f / --force flag would need to be implemented to support this case.
>
> There are a set of common file methods handling things like copying stuff
> over, deleting files, that kind of stuff [1]. These helper methods all
> have built-in checking that the source of a file exists [2], as well as a
> target destination does _not_ exist [3]. It is [3] that would have to be
> tweaked and hooked into command-line flags to enable this functionality.
>
> Additionally, individual platforms handle particular files differently.
> See for example how Android handles <source-file> elements [4], vs. how
> iOS handles <source-file> elements [5]. We'd have to make sure that these
> platform-specific handlers are also hooked into the command line flag
> appropriately.
>
> There is no issue currently filed for this but I can see this being a
> useful option. That being said, I am not sure if/when I will be able to
> tackle this problem, so pull requests/patches are welcome.
>
> [1]
> https://github.com/apache/cordova-plugman/blob/master/src/platforms/commo=
n.
> js
> [2]
> https://github.com/apache/cordova-plugman/blob/master/src/platforms/commo=
n.
> js#L10
> [3]
> https://github.com/apache/cordova-plugman/blob/master/src/platforms/commo=
n.
> js#L17
> [4]
> https://github.com/apache/cordova-plugman/blob/master/src/platforms/andro=
id
> .js#L37
> [5]
> https://github.com/apache/cordova-plugman/blob/master/src/platforms/ios.j=
s#
> L35
>
> On 6/20/13 10:31 AM, "Wargo, John" <john.wargo@sap.com> wrote:
>
> >We=B9re trying to install two plugins that share some of the same
> >dependencies and we=B9re getting an
> >
> >error. Is there a way to turn off checking if a file already exists?  If
> >not, do you have any suggestions
> >
> >on how to implement this?
> >
> >
> >
> >Error: "C:\temp\plug\test\libs\SDMCommon-2.3.0.183.jar" already exists!
> >
> >
> >
> >Looks like we need a -force or -f flag added to plugman to support this.
> >
> >John M. Wargo
> >SAP | Charlotte, NC | USA
> >Office: +1 704.321.0265 | Mobile: +1 704.249.7476
> >Email: john.wargo@sap.com<mailto:john.wargo@sap.com>
> >Twitter: @johnwargo
> >
>
>