Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C54C110748 for ; Wed, 26 Jun 2013 18:03:52 +0000 (UTC) Received: (qmail 32844 invoked by uid 500); 26 Jun 2013 18:03:52 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 32820 invoked by uid 500); 26 Jun 2013 18:03:51 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 32807 invoked by uid 99); 26 Jun 2013 18:03:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jun 2013 18:03:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7EC8E1CD114; Wed, 26 Jun 2013 18:03:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7133567848941607042==" MIME-Version: 1.0 Subject: Review Request 12114: [CB-3384] Rewrite of DataResource into UriResolver + UriResolvers From: "Andrew Grieve" To: "Braden Shepherdson" , "Joe Bowser" Cc: "Andrew Grieve" , "cordova" Date: Wed, 26 Jun 2013 18:03:42 -0000 Message-ID: <20130626180342.23541.37465@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrew Grieve" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/12114/ X-Sender: "Andrew Grieve" Reply-To: "Andrew Grieve" --===============7133567848941607042== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12114/ ----------------------------------------------------------- Review request for cordova, Joe Bowser and Braden Shepherdson. Bugs: CB-3384 https://issues.apache.org/jira/browse/CB-3384 Repository: cordova-android-git Description ------- [CB-3384] Rewrite of DataResource into UriResolver + UriResolvers Includes unit tests woot! Note that this remove CordovaPlugin.shouldInterceptRequest(). Should be fine since this method was introduced only a couple of releases ago, was never documented, and afaict was only used by the Chrome Cordova plugins. Diffs ----- framework/src/org/apache/cordova/CordovaWebView.java 67775a192b35ad1404665285ff1b59efbeb62413 framework/src/org/apache/cordova/FileHelper.java ebbdc8df941561734a6b115f001bf1a45e328e06 framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java 1e190b66d19a56ab2f6434b63660d717b167afca framework/src/org/apache/cordova/UriResolver.java PRE-CREATION framework/src/org/apache/cordova/UriResolvers.java PRE-CREATION framework/src/org/apache/cordova/api/CordovaPlugin.java 2b225e646345579f7a325441bfbc3238d2e5d2dc framework/src/org/apache/cordova/api/PluginManager.java 0a42b3abd2fc9c684728dbbdeb0cc62cd335c2b3 test/src/org/apache/cordova/test/UriResolversTest.java PRE-CREATION test/src/org/apache/cordova/test/actions/CordovaWebViewTestActivity.java 1185bad15fa3dddafa4152912bd5b7f755a5d47c Diff: https://reviews.apache.org/r/12114/diff/ Testing ------- Thanks, Andrew Grieve --===============7133567848941607042==--