cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: 2.9.0rc1 this coming monday??
Date Wed, 19 Jun 2013 20:41:46 GMT
I've pushed a "pl" branch to cordova-js that combines both loading
techniques in the plugin_loader.

I am in the process of testing on android/ios/bb10. Benn is working on
testing that on the Windows Phone platforms.

If it all works out I will merge this back into master on cordova-js,
cherry pick into the 2.9.x branch and retag the JS.

On 6/19/13 1:24 PM, "Jesse" <purplecabbage@gmail.com> wrote:

>Yeah, to Braden's point while it may work, the behavior is not guaranteed,
>and could break later. Also the contents of the file differ between the 2
>methods.
>
>Also discussing this in a quick chat with Fil, I think the best approach
>is:
>1. Plugman generates both files, a js and a json
>2. cordova.js attempts XHR, and catches the exception, in which case it
>continues on to a script injection attempt.
>
>
>@purplecabbage
>risingj.com
>
>
>On Wed, Jun 19, 2013 at 1:18 PM, Braden Shepherdson
><braden@chromium.org>wrote:
>
>> JSON files are not valid Javascript code.
>>
>>
>> On Wed, Jun 19, 2013 at 4:10 PM, Filip Maj <fil@adobe.com> wrote:
>>
>> > Can we not have the script tag point to the json file? Does the
>>extension
>> > have to be .js?
>> >
>> > On 6/19/13 12:10 PM, "Jesse" <purplecabbage@gmail.com> wrote:
>> >
>> > >I was just going to suggest outputting both.  That works for me.
>> > >
>> > >@purplecabbage
>> > >risingj.com
>> > >
>> > >
>> > >On Wed, Jun 19, 2013 at 12:06 PM, Braden Shepherdson
>> > ><braden@chromium.org>wrote:
>> > >
>> > >> Follow-up thought: No reason why we can't generate both
>> > >>cordova_plugins.js
>> > >> and cordova_plugins.json for a while.
>> > >>
>> > >> Braden
>> > >>
>> > >>
>> > >> On Wed, Jun 19, 2013 at 3:06 PM, Braden Shepherdson <
>> > braden@chromium.org
>> > >> >wrote:
>> > >>
>> > >> > Hm. This will of course require changing the name of the file
>> Plugman
>> > >> > generates, and it will mean users need to be very careful to be
>> using
>> > >> > sufficiently new plugman and cordova-js.
>> > >> >
>> > >> > In short: only the upgrade path for users bothers me about this;
>>the
>> > >> > change to use a .js file and <script> tag looks fine. It's
hard
>>to
>> > >>make
>> > >> > Plugman backward compatible, because it's hard to know which
>>version
>> > >>of
>> > >> > cordova.js it's going to be running against. Any ideas here?
>> > >> >
>> > >> > Braden
>> > >> >
>> > >> >
>> > >> > On Wed, Jun 19, 2013 at 3:00 PM, Filip Maj <fil@adobe.com>
wrote:
>> > >> >
>> > >> >> Ahh shit I think we need to retag the JS
>> > >> >>
>> > >> >> The dynamic loading of cordova_plugins.json doesn't work on
>>Windows
>> > >> Phone
>> > >> >> *, as we discussed in the 2.8.0rc1 tag thread. The workaround
>>that
>> > >>Jesse
>> > >> >> converged on has been sitting on a branch. You can compare
it to
>> > >> apache's
>> > >> >> master branch at [1]. Essentially it creates a script tag
>>pointing
>> to
>> > >> the
>> > >> >> cordova_plugins.json file instead of XHR'ing to it. The XHR
>> approach
>> > >> >> throws an "Access Denied" error on WP*.
>> > >> >>
>> > >> >> With this being the last release before 3.0, I think we need
to
>> > >>include
>> > >> >> this bit of functionality.
>> > >> >>
>> > >> >> Thoughts?
>> > >> >>
>> > >> >> [1] https://github.com/purplecabbage/cordova-js/compare/PL
>> > >> >>
>> > >> >> On 6/18/13 7:30 AM, "Shazron" <shazron@gmail.com> wrote:
>> > >> >>
>> > >> >> >I'm still testing https://issues.apache.org/jira/browse/CB-3530
>> > >>that I
>> > >> >> >wanted to get into rc1, but I don't want to rush it, I'll
get
>>to
>> all
>> > >> the
>> > >> >> >rc1 tasks for iOS this afternoon. OS X has barely had
changes
>>so I
>> > >>can
>> > >> >> get
>> > >> >> >that done.
>> > >> >> >
>> > >> >> >
>> > >> >> >On Mon, Jun 17, 2013 at 5:03 PM, Filip Maj <fil@adobe.com>
>>wrote:
>> > >> >> >
>> > >> >> >> I have the rc tag issues for mobile-spec and the
JS assigned
>>to
>> > >>me. I
>> > >> >> >>will
>> > >> >> >> tag them tomorrow morning unless I hear otherwise.
>> > >> >> >>
>> > >> >> >> On 6/17/13 2:01 PM, "James Jong" <wjamesjong@gmail.com>
>>wrote:
>> > >> >> >>
>> > >> >> >> >I'm back this week and will start looking at
a couple of the
>> ones
>> > >> Shaz
>> > >> >> >> >mentioned: CB-3757 , CB-3562.
>> > >> >> >> >-James Jong
>> > >> >> >> >
>> > >> >> >> >On Jun 17, 2013, at 3:21 PM, Andrew Grieve <
>> agrieve@chromium.org
>> > >
>> > >> >> >>wrote:
>> > >> >> >> >
>> > >> >> >> >> I would have liked to fix a few more bugs,
namely:
>> > >> >> >> >> - Those filed by Abel MuiƱo (Camera / FileTransfer)
(e.g.
>> > >>cb-3185)
>> > >> >> >> >> - iOS loading bugs (CB-3005, CB-3530, CB-3534)
>> > >> >> >> >> - DisallowOverscroll setting inconsistency
between Android
>> and
>> > >>iOS
>> > >> >> >> >>(Jesse
>> > >> >> >> >> brought this up - no bug filed for this
yet I think)
>> > >> >> >> >>
>> > >> >> >> >> I was also planning on working on adding
some
>> > >> Plugin-behaving-nicely
>> > >> >> >> >>checks
>> > >> >> >> >> on the native side. E.g. log a message if
a plugin takes
>> spends
>> > >> more
>> > >> >> >> >>than
>> > >> >> >> >> 50ms on the UI (for iOS) or WebCore (for
Android) thread.
>> > >> >> >> >>
>> > >> >> >> >> Of course, I haven't done anything for over
2 weeks, and
>>so I
>> > >> >> clearly
>> > >> >> >> >>won't
>> > >> >> >> >> get this all done in the next few hours
:P.
>> > >> >> >> >>
>> > >> >> >> >> So, I'm fine with starting the release now
so that we can
>> focus
>> > >> more
>> > >> >> >>on
>> > >> >> >> >> 3.0. It'll give us a chance to practice
our release-foo
>>some
>> > >>more,
>> > >> >> >>and
>> > >> >> >> >> hopefully make more enhancements to the
coho tool (Steven
>>-
>> I'm
>> > >> >> >>looking
>> > >> >> >> >>at
>> > >> >> >> >> you for the uploading a release part :P).
>> > >> >> >> >>
>> > >> >> >> >>
>> > >> >> >> >>
>> > >> >> >> >>
>> > >> >> >> >>
>> > >> >> >> >>
>> > >> >> >> >> On Mon, Jun 17, 2013 at 1:38 PM, Filip Maj
<fil@adobe.com>
>> > >>wrote:
>> > >> >> >> >>
>> > >> >> >> >>> Thanks Jeff!
>> > >> >> >> >>>
>> > >> >> >> >>> On 6/17/13 10:28 AM, "Jeffrey Heifetz"
>> > >><jheifetz@blackberry.com>
>> > >> >> >> wrote:
>> > >> >> >> >>>
>> > >> >> >> >>>> Yep, all BB10 work is being tracked
in JIRA. Check out
>> > >>CB-3797,
>> > >> >> >> >>>>CB-3799
>> > >> >> >> >>>>
>> > >> >> >> >>>> On 13-06-17 1:26 PM, "Filip Maj"
<fil@adobe.com> wrote:
>> > >> >> >> >>>>
>> > >> >> >> >>>>> Good stuff Bryan, is this being
tracked on issues
>> anywhere?
>> > >>I'd
>> > >> >> >>like
>> > >> >> >> >>>>>to
>> > >> >> >> >>>>> refer other issues (CLI) to
this feature you're
>>speaking
>> of.
>> > >> >> >> >>>>>
>> > >> >> >> >>>>> On 6/17/13 10:18 AM, "Bryan
Higgins"
>> > >><bryan@bryanhiggins.net>
>> > >> >> >>wrote:
>> > >> >> >> >>>>>
>> > >> >> >> >>>>>> For BB10, we're working
on moving out the environment
>> > >>settings
>> > >> >> >>from
>> > >> >> >> >>>>>> project
>> > >> >> >> >>>>>> to HOME.
>> > >> >> >> >>>>>>
>> > >> >> >> >>>>>> That work is pretty much
done. We should have it
>>tested
>> and
>> > >> >> >> >>>>>>committed
>> > >> >> >> >>>>>> within the next few hours.
>> > >> >> >> >>>>>>
>> > >> >> >> >>>>>>
>> > >> >> >> >>>>>> On Mon, Jun 17, 2013 at
1:04 PM, Ian Clelland
>> > >> >> >><iclelland@google.com
>> > >> >> >> >
>> > >> >> >> >>>>>> wrote:
>> > >> >> >> >>>>>>
>> > >> >> >> >>>>>>> The only thing that
I'm working on this morning that
>> could
>> > >> be a
>> > >> >> >> >>>>>>> candidate
>> > >> >> >> >>>>>>> for 2.9 is an extension
to FileWriter.write(Blob)
>>that
>> > >>will
>> > >> >> >>accept
>> > >> >> >> >>>>>>>a
>> > >> >> >> >>>>>>> Cordova File object
in place of a native Blob object.
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>> (FileWriter.write(Blob)
is CB-2406, and new for 2.9)
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>> If we consider this
a bug to be fixed, then I can
>>take
>> > >>care
>> > >> of
>> > >> >> >>it
>> > >> >> >> >>>>>>> post-rc1.
>> > >> >> >> >>>>>>> Otherwise, I'll work
quickly to get it in this
>>morning.
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>> On Mon, Jun 17, 2013
at 10:00 AM, Filip Maj
>> > >><fil@adobe.com>
>> > >> >> >>wrote:
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>>>> SO: we're doing
this today ya? Any objections?
>>Anyone
>> > >>still
>> > >> >> >> >>>>>>>>working
>> > >> >> >> >>>>>>> on
>> > >> >> >> >>>>>>>> something that they
are gunning to get in for 2.9?
>> > >> >> >> >>>>>>>>
>> > >> >> >> >>>>>>>> On 6/14/13 1:12
PM, "Michael Brooks" <
>> > >> >> michael@michaelbrooks.ca>
>> > >> >> >> >>>>>>> wrote:
>> > >> >> >> >>>>>>>>
>> > >> >> >> >>>>>>>>> Monday RC1 sounds
good to me.
>> > >> >> >> >>>>>>>>>
>> > >> >> >> >>>>>>>>>
>> > >> >> >> >>>>>>>>> On Thu, Jun
13, 2013 at 11:19 AM, Shazron <
>> > >> shazron@gmail.com
>> > >> >> >
>> > >> >> >> >>>>>>> wrote:
>> > >> >> >> >>>>>>>>>
>> > >> >> >> >>>>>>>>>> Looking
at iOS 2.9.0:
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>> Definitely
as you said:
>> > >> >> >> >>>>>>> https://issues.apache.org/jira/browse/CB-3757
>> > >> >> >> >>>>>>>>>> Then all
iOS cli and docs issues.
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>> If there
is time for iOS I am going to tackle:
>> > >> >> >> >>>>>>>>>> https://issues.apache.org/jira/browse/CB-3303
(to
>> fix)
>> > >> >> >> >>>>>>>>>> https://issues.apache.org/jira/browse/CB-3451
(to
>> > >> >> >>investigate,
>> > >> >> >> >>> no
>> > >> >> >> >>>>>>> fix
>> > >> >> >> >>>>>>>>>> yet)
>> > >> >> >> >>>>>>>>>> https://issues.apache.org/jira/browse/CB-3567
>>(there
>> > >>is a
>> > >> >> PR
>> > >> >> >>to
>> > >> >> >> >>>>>>>>>> investigate)
>> > >> >> >> >>>>>>>>>> https://issues.apache.org/jira/browse/CB-3562
(fix
>> in
>> > >>the
>> > >> >> >> issue,
>> > >> >> >> >>>>>>> to
>> > >> >> >> >>>>>>>>>> evaluate)
>> > >> >> >> >>>>>>>>>> https://issues.apache.org/jira/browse/CB-3534
(the
>> > >> reporter
>> > >> >> >>has
>> > >> >> >> >>>>>>> filed
>> > >> >> >> >>>>>>>> an
>> > >> >> >> >>>>>>>>>> excellent
bug report, to repro, and maybe fix)
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>> Maybe this
Untappd issue:
>> > >> >> >> >>>>>>> https://issues.apache.org/jira/browse/CB-3574
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>> On Thu,
Jun 13, 2013 at 11:10 AM, Lorin Beer <
>> > >> >> >> >>>>>>> lorin.beer.dev@gmail.com
>> > >> >> >> >>>>>>>>>>> wrote:
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>>>> be the
leaf in the wind, Shaz.
>> > >> >> >> >>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>> Anything
pressing on iOS that needs to be
>>resolved?
>> I
>> > >>am
>> > >> >> >>aware
>> > >> >> >> >>>>>>> of a
>> > >> >> >> >>>>>>>>>> bug
>> > >> >> >> >>>>>>>>>> in
>> > >> >> >> >>>>>>>>>>> Camera,
which I can take a look at. Anything else
>> you
>> > >> want
>> > >> >> >>in?
>> > >> >> >> >>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>> On Thu,
Jun 13, 2013 at 11:01 AM, Shazron
>> > >> >> >><shazron@gmail.com>
>> > >> >> >> >>>>>>> wrote:
>> > >> >> >> >>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>
I wish I could say there was more velocity in
>>the
>> > >>iOS /
>> > >> OS
>> > >> >> >>X
>> > >> >> >> >>>>>>> repos
>> > >> >> >> >>>>>>>>>> but
>> > >> >> >> >>>>>>>>>>>>
there hasn't been any with me being away at WWDC
>> this
>> > >> >> week,
>> > >> >> >> >>>>>>> but if
>> > >> >> >> >>>>>>>>>> that's
>> > >> >> >> >>>>>>>>>>>>
where the wind blows I am but a feather. Will
>>try
>> to
>> > >>get
>> > >> >> >>more
>> > >> >> >> >>>>>>> issues
>> > >> >> >> >>>>>>>>>>>>
resolved by rc2.
>> > >> >> >> >>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>
On Thu, Jun 13, 2013 at 9:27 AM, Lorin Beer
>> > >> >> >> >>>>>>>>>> <lorin.beer.dev@gmail.com
>> > >> >> >> >>>>>>>>>>>>>
wrote:
>> > >> >> >> >>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>
+1, let's tackle this early
>> > >> >> >> >>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>
On Wed, Jun 12, 2013 at 4:06 PM, Jesse
>> > >> >> >> >>>>>>> <purplecabbage@gmail.com
>> > >> >> >> >>>>>>>>
>> > >> >> >> >>>>>>>>>>> wrote:
>> > >> >> >> >>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>
meh
>> > >> >> >> >>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>
@purplecabbage
>> > >> >> >> >>>>>>>>>>>>>>
risingj.com
>> > >> >> >> >>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>
On Wed, Jun 12, 2013 at 4:03 PM, Filip Maj
>> > >> >> >> >>>>>>> <fil@adobe.com>
>> > >> >> >> >>>>>>>>>> wrote:
>> > >> >> >> >>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>
Huge +1!
>> > >> >> >> >>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>
On 6/12/13 3:56 PM, "Joe Bowser"
>> > >><bowserj@gmail.com>
>> > >> >> >> >>>>>>> wrote:
>> > >> >> >> >>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>>
Hey
>> > >> >> >> >>>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>>
I know this is pretty soon, but how does a
>> > >>2.9.0rc1
>> > >> on
>> > >> >> >> >>>>>>> Monday
>> > >> >> >> >>>>>>>>>>> sound?
>> > >> >> >> >>>>>>>>>>>>>>>>
Since this is supposed to be a hardening
>> release
>> > >> >> >> >>>>>>> anyway, I
>> > >> >> >> >>>>>>>>>> don't
>> > >> >> >> >>>>>>>>>>> see
>> > >> >> >> >>>>>>>>>>>>>>>>
why we shouldn't start with the RCs.
>> > >> >> >> >>>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>>
Any thoughts?
>> > >> >> >> >>>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>>
Joe
>> > >> >> >> >>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>>
>> > >> >> >> >>>>>>>>>>
>> > >> >> >> >>>>>>>>
>> > >> >> >> >>>>>>>>
>> > >> >> >> >>>>>>>
>> > >> >> >> >>>>>
>> > >> >> >> >>>>
>> > >> >> >> >>>>
>> > >> >> >> >>>>
>> > >> >>
>> >
>>>>>>---------------------------------------------------------------------
>> > >> >> >> >>>> This transmission (including any
attachments) may
>>contain
>> > >> >> >>confidential
>> > >> >> >> >>>> information, privileged material
(including material
>> > >>protected
>> > >> by
>> > >> >> >>the
>> > >> >> >> >>>> solicitor-client or other applicable
privileges), or
>> > >>constitute
>> > >> >> >> >>>> non-public information. Any use
of this information by
>> anyone
>> > >> >> other
>> > >> >> >> >>>>than
>> > >> >> >> >>>> the intended recipient is prohibited.
If you have
>>received
>> > >>this
>> > >> >> >> >>>> transmission in error, please immediately
reply to the
>> sender
>> > >> and
>> > >> >> >> >>>>delete
>> > >> >> >> >>>> this information from your system.
Use, dissemination,
>> > >> >> >>distribution,
>> > >> >> >> >>>>or
>> > >> >> >> >>>> reproduction of this transmission
by unintended
>>recipients
>> is
>> > >> not
>> > >> >> >> >>>> authorized and may be unlawful.
>> > >> >> >> >>>
>> > >> >> >> >>>
>> > >> >> >> >
>> > >> >> >>
>> > >> >> >>
>> > >> >>
>> > >> >>
>> > >> >
>> > >>
>> >
>> >
>>


Mime
View raw message