cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: Android: Use source files instead of .jar file
Date Mon, 17 Jun 2013 21:32:03 GMT
I'm ambivalent on this issue.

To play devil's advocate, Joe, it hasn't been an issue on iOS or Windows
Phone, so any speculation that this _will_ be an issue in the future is
just that: speculation.

If anything we should set an over/under on how long it will take after
introducing this change before we get "Hey gaiz I changed
CordovaWebView.java and now nothing works!" issues ;)

My bet is: a long time.

On 6/17/13 2:11 PM, "Benn Mapes" <benn.mapes@gmail.com> wrote:

>+1
>I really like having source code. On Windows Phone we have moved from a
>pre-compiled .dll to just the source as well. Like Kerri said, it is very
>helpful when stepping through your application and debugging any problems
>you might have, as well as getting more people looking at the code and
>understanding it better.
>
>If users don't want to look at the source at all they can just treat the
>cordovaLib folder like it's a .jar and not touch it.
>
>
>On Mon, Jun 17, 2013 at 1:04 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
>> -1
>>
>> This only caters to a minority of our users. Most of our users can't
>>debug
>> Cordova, since they can't write Java (or even Javascript) well.
>>
>> I think this will have far more things break and we'll have a huge
>>backlash
>> from our mainstream users, just like when we deprecated plugins.
>> On Jun 17, 2013 12:48 PM, "Andrew Grieve" <agrieve@chromium.org> wrote:
>>
>> > I'd like to propose that instead of having the create script compile a
>> > version of Cordova into a .jar, that instead it copies over the source
>> > files instead.
>> >
>> > My main motivation is that doing so will make debugging native code
>>much
>> > easier since the source code will show up in Eclipse / Android Studio
>>by
>> > default instead of needing to reconfigure your project to get this to
>> work.
>> >
>> > We did the same change on iOS a while ago (moving from a precompiled
>> > framework library to just copying over source files), and I think the
>> > results were quite positive. It helps users file better bug reports,
>>and
>> I
>> > think also encourages them to submit bug fixes. It will also make it
>> easier
>> > for Plugin developers to figure out our APIs since they'll be able to
>> see &
>> > tweak the code.
>> >
>> > Agree / object?
>> >
>>


Mime
View raw message