cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <>
Subject Re: [Android] Why is DataResource still in master?
Date Thu, 06 Jun 2013 03:37:48 GMT
The reverts were only on the 2.8.0 branch, not on master.  It's
currently totally broken right now.

On Wed, Jun 5, 2013 at 8:09 PM, Michal Mocny <> wrote:
> 100 yard summary: our intern Shravan from last term was adding this as part
> of his app-harness work.  This specific change landed a too hastily as
> there were some issues in corner cases (perhaps over-eagerness due to time
> pressure as he approach term end), but all actual uses of DataResource
> should have been reverted before 2.8 branch (right?), and so just idle code
> remains in the codebase.  The plan is to fix the remaining issues before
> re-adding its usage.. but Andrew was working on that, hence the delay.
> The specifics details of why it has been added / what its used for, I will
> defer to some others (Max/Braden?) who would know the answer.
> As far as I am aware, leaving it in isn't harmful, but perhaps leaving it
> in unfixed in isn't helpful either.  Lets see what Max/Braden say.
> On Wed, Jun 5, 2013 at 4:54 PM, Joe Bowser <> wrote:
>> Hey
>> Why is DataResouce still in master? I don't want this code to go into
>> 2.9.0 or 3.0.0, since I have no idea what this is trying to
>> accomplish.  I'm going to start ripping it out of master tomorrow if
>> someone doesn't tell me why it should still be here.
>> Seriously, WTF?

View raw message