cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Mocny" <mmo...@chromium.org>
Subject Re: Review Request: Fixing exec bug.
Date Mon, 24 Jun 2013 14:49:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12013/#review22327
-----------------------------------------------------------

Ship it!


Looks good.

Just for completeness, with this patch, it would be possible for an app that uses the bridge
heavily to remain using the UI thread indefinitely, right?  Can we assume that this is unlikely
to happen, ie, the exec queue will drain to 0 relatively quickly?

- Michal Mocny


On June 21, 2013, 5:21 p.m., Jeffrey Willms wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12013/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 5:21 p.m.)
> 
> 
> Review request for cordova and Andrew Grieve.
> 
> 
> Description
> -------
> 
> Fixing exec bug.
> 
> 
> This addresses bug CB-3927.
>     https://issues.apache.org/jira/browse/CB-3927
> 
> 
> Diffs
> -----
> 
>   framework/src/org/apache/cordova/api/PluginEntry.java 9b9af6bc303965e7263bca75037256da81868fb2

>   framework/src/org/apache/cordova/api/PluginManager.java adaec907e216c101cc78ee72ff30ec6b7d875a45

> 
> Diff: https://reviews.apache.org/r/12013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeffrey Willms
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message