cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Willms" <jbwil...@google.com>
Subject Re: Review Request: Fixing exec bug.
Date Thu, 20 Jun 2013 20:42:46 GMT


> On June 20, 2013, 8:28 p.m., Braden Shepherdson wrote:
> > framework/src/org/apache/cordova/api/PluginManager.java, line 220
> > <https://reviews.apache.org/r/12013/diff/1/?file=309778#file309778line220>
> >
> >     I realize these logs are at a high verbosity level (DEBUG). Are they intended
to be left in?

No, I don't intend to leave them in.


> On June 20, 2013, 8:28 p.m., Braden Shepherdson wrote:
> > framework/src/org/apache/cordova/api/PluginManager.java, line 223
> > <https://reviews.apache.org/r/12013/diff/1/?file=309778#file309778line223>
> >
> >     Doesn't the second case need to return true? It seems synchronous to me.

We are planning on removing the return value entirely, which Andrew will do in a separate
change, so for now the return value doesn't matter.


- Jeffrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12013/#review22184
-----------------------------------------------------------


On June 20, 2013, 8:16 p.m., Jeffrey Willms wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12013/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 8:16 p.m.)
> 
> 
> Review request for cordova and Andrew Grieve.
> 
> 
> Description
> -------
> 
> Fixing exec bug.
> 
> 
> This addresses bug CB-3927.
>     https://issues.apache.org/jira/browse/CB-3927
> 
> 
> Diffs
> -----
> 
>   framework/src/org/apache/cordova/api/PluginEntry.java 9b9af6bc303965e7263bca75037256da81868fb2

>   framework/src/org/apache/cordova/api/PluginManager.java 71fc25817b5d58bb2fbf5a29158ef2c7d424d4ab

> 
> Diff: https://reviews.apache.org/r/12013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeffrey Willms
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message