Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.219.54 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAJOjTCgjKZ8TSFXL_5DS8QoX_OP8hD1w3L42fsOMjCmPxvP5WQ@mail.gmail.com>
References: 
 <CAM1AYQDJyyVYe5cfe6eyL5WFKMVZO0p+HToqLBbB_WaKoDYF-Q@mail.gmail.com>
 <CAJOjTCgjKZ8TSFXL_5DS8QoX_OP8hD1w3L42fsOMjCmPxvP5WQ@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Tue, 14 May 2013 19:22:10 -0400
Message-ID: 
 <CABiQX1UVgwh_vSi3DGqXCnWibTLde-eD=Z_m3hHYmhbR952bHA@mail.gmail.com>
Subject: Re: Please look at this pull request
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b41ccd24f535404dcb5e868

--047d7b41ccd24f535404dcb5e868
Content-Type: text/plain; charset=ISO-8859-1

Thanks for testing it out Benn! I committed it and created an issue.
https://issues.apache.org/jira/browse/CB-3392


On Tue, May 14, 2013 at 5:33 PM, Benn Mapes <benn.mapes@gmail.com> wrote:

> Took a look at the request and found a few new errors with the windows
> create script since things have changed a bit. I just added quotes around
> the variables to keep it consistent with the other commands.
>
> I added a commit as well to fix the other changes. If someone with commit
> access to the repo could merge/rebase this in that would be great.
>
> Here is my pull request :
> https://github.com/apache/cordova-android/pull/55
>
>
> On Mon, May 13, 2013 at 6:21 PM, Simon MacDonald
> <simon.macdonald@gmail.com>wrote:
>
> > I don't have a PC right now to check this out but a lot of people on
> > WIndows have complained about this on the list and apparently this fixes
> > the issue:
> >
> > https://github.com/apache/cordova-android/pull/54
> >
> > Thanks...
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
>

--047d7b41ccd24f535404dcb5e868--