cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: [Android] Deprecate HTC 2.3 Android console.log support in 3.0
Date Tue, 14 May 2013 03:02:22 GMT
Yes, I want to get rid of that pretty bad piece of Java awfulness.

On Mon, May 13, 2013 at 5:55 PM, Simon MacDonald
<simon.macdonald@gmail.com> wrote:
> I believe Joe means this bit of code:
>
>         // Set the nav dump for HTC 2.x devices (disabling for ICS,
> deprecated entirely for Jellybean 4.2)
>
>         try {
>
>             Method gingerbread_getMethod =  WebSettings.class.getMethod(
> "setNavDump", new Class[] { boolean.class });
>
>
>
>             String manufacturer = android.os.Build.MANUFACTURER;
>
>             Log.d(TAG, "CordovaWebView is running on device made by: " +
> manufacturer);
>
>             if(android.os.Build.VERSION.SDK_INT < android.os.Build.
> VERSION_CODES.HONEYCOMB &&
>
>                     android.os.Build.MANUFACTURER.contains("HTC"))
>
>             {
>
>                 gingerbread_getMethod.invoke(settings, true);
>
>             }
>
>         } catch (NoSuchMethodException e) {
>
>             Log.d(TAG, "We are on a modern version of Android, we will
> deprecate HTC 2.3 devices in 2.8");
>
>         } catch (IllegalArgumentException e) {
>
>             Log.d(TAG, "Doing the NavDump failed with bad arguments");
>
>         } catch (IllegalAccessException e) {
>
>             Log.d(TAG, "This should never happen: IllegalAccessException
> means this isn't Android anymore");
>
>         } catch (InvocationTargetException e) {
>
>             Log.d(TAG, "This should never happen: InvocationTargetException
> means this isn't Android anymore.");
>
>         }
>
> I'm in favour of getting rid of it if that is indeed what Joe is
> suggestion.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Mon, May 13, 2013 at 8:43 PM, Andrew Grieve <agrieve@chromium.org> wrote:
>
>> Could you be more specific about what you'd like to get rid of?
>>
>> Logger plugin?
>> onConsoleMessage?
>>
>>
>> On Mon, May 13, 2013 at 5:47 PM, Jesse <purplecabbage@gmail.com> wrote:
>>
>> > console.log is pretty useful.
>> > This technically isn't our API, but a polyfill for platforms where
>> > console.log goes nowhere.
>> > WP7+8 have this broken into the DebugConsole plugin, and  clobber
>> > window.console as well as navigator.console.
>> >
>> > modulemapper.clobbers('cordova/plugin/windowsphone/console',
>> > 'navigator.console');
>> > modulemapper.clobbers('cordova/plugin/windowsphone/console', 'console');
>> >
>> > The actual implementation is bare bones[1], and does not have all the
>> > log-level bs in other versions.
>> >
>> >
>> > [1]
>> >
>> >
>> https://github.com/apache/cordova-js/blob/master/lib/windowsphone/plugin/windowsphone/console.js
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> >
>> > On Mon, May 13, 2013 at 2:22 PM, Joe Bowser <bowserj@gmail.com> wrote:
>> >
>> > > Hey
>> > >
>> > > There's a known bug in HTC's WebView that suppressed console.log on
>> > > old Gingerbread devices.  This is only on devices that run HTC Sense,
>> > > and not devices like the Nexus One.  How do people feel about
>> > > deprecating console.log in 3.0.  I know that Simon hated this
>> > > particular chunk of code, and wanted to toss it by the wayside a while
>> > > ago.
>> > >
>> > > It says it was supposed to be ripped out this release, but I don't see
>> > > it on the wiki, so I'm giving it until 3.0 to be removed.  Does that
>> > > sound reasonable?
>> > >
>> > > Joe
>> > >
>> >
>>

Mime
View raw message