cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: Android Audio isn't broken, the URIs being fed into the audio are
Date Fri, 24 May 2013 18:44:03 GMT
I've already fixed this bug!  We should be all good now!

On Fri, May 24, 2013 at 11:40 AM, Ian Clelland <iclelland@chromium.org> wrote:
> Definitely, Joe --
>
> It looks like Shravan was a little over-eager to apply the DataResource API
> to replace FileHelper, and this is definitely a bug.
>
> I'm going to revert the changes that he made to AudioHandler.java, and we
> can try the media tests again.
>
>
>
>
> On Fri, May 24, 2013 at 1:59 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
>> OK, I was wrong.  It turns out the DataResource code that was added in
>> doesn't have support for streaming audio.  We need to get this fixed
>> ASAP.  Seriously, we have these tests for a reason. Every time we
>> start changing how an API works, we should run the Mobile-Spec tests
>> to make sure that it's covered.  If it's not covered by mobile-spec,
>> we should create a ticket to write a test for the Android Test Suite.
>>
>> The culprit appears to be on line 60 of AudioHandler.java:
>>
>>     public String getFilePath(String url, String source){
>>         DataResource dataResource =
>> DataResource.initiateNewDataRequestForUri(url,
>> this.webView.pluginManager, cordova, source);
>>         return dataResource.getRealFile().getPath();
>>     }
>>
>> If it's an web URI, we shouldn't screw with it.  Seriously!
>>
>> Joe
>>
>> On Fri, May 24, 2013 at 10:36 AM, Joe Bowser <bowserj@gmail.com> wrote:
>> > Hey
>> >
>> > After looking into the bug further, for some reason URIs such as
>> > http://cordova.apache.org/downloads/BlueZedEx.mp3 are losing slashes
>> > after the protocol. (i.e.
>> > http:/cordova.apache.org/downloads/BlueZedEx.mp3).  This is causing
>> > Android to epic fail the media tests and I suspect that it would cause
>> > the same problem in other platforms.  Did anything change that would
>> > cause the URIs to be malformed? This is a pretty important thing to
>> > get fixed for 2.8.0rc1, and I don't want to tag until this is
>> > resolved.
>> >
>> > Joe
>>

Mime
View raw message