cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: plugin loader breakage from blackberry 10 merge into cordova js
Date Wed, 15 May 2013 22:07:20 GMT
This may be unpopular, but I'm wondering if the best solution might be to
drop jsmodule/cordova_plugins.json and go back to just including script
tags in plugin.xml that get added to your index.html/cordova.js. I know it
isn't as pretty, but it won't have to deal with these issues.




On Wed, May 15, 2013 at 12:36 PM, Bryan Higgins <bryan@bryanhiggins.net>wrote:

> That won't work for remotely hosted pages and wouldn't allow for the File
> API to be pulled out into a plugin.
>
> Based on the constraints, the only other solution I can think of is to
> require that cordova.js sits at the root of the project. The plugin loader
> scripts could then figure out the path based on the cordova-js script tag.
> The original plan was to inject directly into cordova-js, which would have
> imposed a similar constraint, but a decision was made to use a JSON file to
> avoid code generation issues.
>
> Keep in mind that the path is relative to the HTML file, not the script
> making the XHR.
>
>
> On Wed, May 15, 2013 at 3:12 PM, Filip Maj <fil@adobe.com> wrote:
>
> > Could we leverage our own File API to load the plugins json instead of
> > relying on (possibly unclear local vs remote) XHR semantics?
> >
> > On 5/15/13 12:03 PM, "Steven Gill" <stevengill97@gmail.com> wrote:
> >
> > >Hey All,
> > >
> > >If you haven't checked out issue CB-3393[1], you should. I believe this
> is
> > >a pretty big problem and brings into question the way we are loading
> > >plugins.
> > >
> > >Using an absolute path is not going to work as Braden suggests in the
> > >comments of the issue. He proposes adding code to cordova.js that will
> > >search for the cordova_plugins.json file and reference it correctly.
> This
> > >feels very hacky to me and will lead to more issues. I believe we need
> to
> > >reconsider how we are loading plugins.
> > >
> > >I am hoping more people decide to chime in on this discussion.
> > >
> > >[1] - https://issues.apache.org/jira/browse/CB-3393
> > >
> > >
> > >On Wed, May 15, 2013 at 9:12 AM, Steven Gill <stevengill97@gmail.com>
> > >wrote:
> > >
> > >> Hey Bryan,
> > >>
> > >> Thanks for chiming in. I realized this after I made the change
> > >>yesterday.
> > >> Tracking it with https://issues.apache.org/jira/browse/CB-3393
> > >>
> > >> Cheers,
> > >> -Steve
> > >> On May 15, 2013 5:34 AM, "Bryan Higgins" <bhiggins@blackberry.com>
> > >>wrote:
> > >>
> > >>> Thanks Steve. I meant to bring that commit up on the list.
> > >>>
> > >>> The problem is that the relative reference to cordova_plugins.json
> only
> > >>> works when the page is in the same directory as that file. Is that
> > >>>also an
> > >>> issue on ios/android? If so, is there a standard cross platform way
> to
> > >>> reference a file in the root of a cordova app?
> > >>>
> > >>> We had to do something similar in plugman. This has not yet been
> merged
> > >>> in:
> > >>>
> > >>>
> > >>>
> > >>>
> > https://github.com/blackberry/cordova-plugman/commit/7f8b704b6d4eb7419ca
> > >>>a56faee743f841bc987bd
> > >>>
> > >>>
> > >>> On Tue, May 14, 2013 at 8:03 PM, Steven Gill <stevengill97@gmail.com
> >
> > >>> wrote:
> > >>>
> > >>> > Hey All,
> > >>> >
> > >>> > The BB10 stuff got merged into cordova.js. The following commit
> > >>>breaks
> > >>> > plugin_loader for ios + android.
> > >>> >
> > >>> >
> > >>>
> > >>>
> > https://github.com/apache/cordova-js/commit/8d59461c6f796f2c88a0eae2467c
> > >>>c663897ccce9
> > >>> > .
> > >>> > I am going to remove the slash for now.
> > >>> >
> > >>> > -Steve
> > >>> >
> > >>>
> > >>
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message