cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: 2.8.0rc1
Date Thu, 23 May 2013 18:10:55 GMT
Given that our goal was to cut Tuesday, I think we should just stick with
the current code for now. I don't think there's any real reason to change
this code at the last second.


On Thu, May 23, 2013 at 1:40 PM, Braden Shepherdson <braden@chromium.org>wrote:

> I just merged the git_refs changes. They shouldn't affect anything else.
>
>
> On Thu, May 23, 2013 at 1:35 PM, Filip Maj <fil@adobe.com> wrote:
>
> > SORRY false alarm: not true. Not merged into plugman yet. On a branch.
> >
> > On 5/23/13 10:28 AM, "Jesse" <purplecabbage@gmail.com> wrote:
> >
> > >So are we going with the tagged version?
> > >Should I push off the plugin-loader changes until 2.9.0?
> > >
> > >@purplecabbage
> > >risingj.com
> > >
> > >
> > >On Thu, May 23, 2013 at 10:11 AM, Steven Gill
> > ><stevengill97@gmail.com>wrote:
> > >
> > >> Sweet. I will have to take a look at these new changes to coho later
> > >>today.
> > >>
> > >>
> > >> On Wed, May 22, 2013 at 9:40 PM, Andrew Grieve <agrieve@chromium.org>
> > >> wrote:
> > >>
> > >> > Okay, had to fix some things in the coho script (which I will push
> > >> > tomorrow).
> > >> >
> > >> > Parent bug is here: https://issues.apache.org/jira/browse/CB-3464
> > >> >
> > >> >
> > >> > On Wed, May 22, 2013 at 9:53 PM, Andrew Grieve <
> agrieve@chromium.org>
> > >> > wrote:
> > >> >
> > >> > > Awesome stuff! Getting cutting now.
> > >> > >
> > >> > >
> > >> > > On Wed, May 22, 2013 at 5:09 PM, Jesse <purplecabbage@gmail.com>
> > >> wrote:
> > >> > >
> > >> > >> Fixed CB-3307 for WP7, WP8, and Windows 8;
> > >> > >>
> > >> > >> @purplecabbage
> > >> > >> risingj.com
> > >> > >>
> > >> > >>
> > >> > >> On Wed, May 22, 2013 at 1:46 PM, Shazron <shazron@gmail.com>
> > wrote:
> > >> > >>
> > >> > >> > Fixed the OS X issue (CB-3443).
> > >> > >> >
> > >> > >> >
> > >> > >> > On Wed, May 22, 2013 at 1:13 PM, Andrew Grieve <
> > >> agrieve@chromium.org>
> > >> > >> > wrote:
> > >> > >> >
> > >> > >> > > LGTM so long as you've tested that the error even
actually
> > >>fires
> > >> (I
> > >> > >> know
> > >> > >> > it
> > >> > >> > > didn't use to on some older browsers).
> > >> > >> > >
> > >> > >> > > The other thing still outstanding is
> > >> > >> > > https://issues.apache.org/jira/browse/CB-3307 for
WP, BB,
> OSX.
> > >> > >> > >
> > >> > >> > > I suppose we could branch without that done, but
it's such a
> > >>small
> > >> > >> > change,
> > >> > >> > > it'd be great to get that fixed before tagging.
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > This time around I'd like to try without using
the automated
> > >> script
> > >> > >> that
> > >> > >> > > creates issues since I think they capture only
a small number
> > >>of
> > >> the
> > >> > >> > steps,
> > >> > >> > > and instead I'll create a master bug and one sub-bug
per
> repo.
> > >> Then,
> > >> > >> > let's
> > >> > >> > > follow the updated wiki steps as best as possible:
> > >> > >> > >
> > >> > >> > > http://wiki.apache.org/cordova/CuttingReleases
> > >> > >> > >
> > >> > >> > > and just keep adding comments to the JIRA bugs
whenever
> someone
> > >> does
> > >> > >> any
> > >> > >> > of
> > >> > >> > > the steps.
> > >> > >> > >
> > >> > >> > > I'm out to a movie tonight, but will be back 9ish
EST. I'll
> > >>look
> > >> to
> > >> > >> > branch
> > >> > >> > > & tag then.
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > On Wed, May 22, 2013 at 2:22 PM, Jesse
> > >><purplecabbage@gmail.com>
> > >> > >> wrote:
> > >> > >> > >
> > >> > >> > > > I am satisfied with the added error checking.
> > >> > >> > > > Please review the changes to plugin loading
[1]
> > >> > >> > > >
> > >> > >> > > > If possible I would like this in 2.8.0rc1,
but perhaps more
> > >> > >> > importantly,
> > >> > >> > > we
> > >> > >> > > > should do 2.8.0rc1 today.
> > >> > >> > > >
> > >> > >> > > > Cheers,
> > >> > >> > > >   Jesse
> > >> > >> > > >
> > >> > >> > > > [1] https://github.com/purplecabbage/cordova-js/tree/PL
> > >> > >> > > >
> > >> > >> > > >
> > >> > >> > > > @purplecabbage
> > >> > >> > > > risingj.com
> > >> > >> > > >
> > >> > >> > > >
> > >> > >> > > > On Tue, May 21, 2013 at 5:34 PM, Jesse
> > >><purplecabbage@gmail.com
> > >> >
> > >> > >> > wrote:
> > >> > >> > > >
> > >> > >> > > > > the error checking I am adding/testing
right now is
> > >>handling
> > >> > >> onerror
> > >> > >> > > > which
> > >> > >> > > > > does fire when the file is missing.
> > >> > >> > > > >
> > >> > >> > > > > @purplecabbage
> > >> > >> > > > > risingj.com
> > >> > >> > > > >
> > >> > >> > > > >
> > >> > >> > > > > On Tue, May 21, 2013 at 5:25 PM, Andrew
Grieve <
> > >> > >> agrieve@chromium.org
> > >> > >> > > > >wrote:
> > >> > >> > > > >
> > >> > >> > > > >> I like the change I think, but I
think it will fail if
> > >>users
> > >> > are
> > >> > >> > > missing
> > >> > >> > > > >> the cordova_plugins.js file (onload
will never fire). On
> > >>the
> > >> > plus
> > >> > >> > side
> > >> > >> > > > >> though, this change makes it easier
to combine
> cordova.js
> > >>and
> > >> > >> > > > >> cordova_plugins.js by concatenating
them together.
> > >> > >> > > > >>
> > >> > >> > > > >> Maybe we should just go all the way
with this and
> combine
> > >>the
> > >> > two
> > >> > >> > .js
> > >> > >> > > > >> files
> > >> > >> > > > >> into one right from the start? Then
we won't have to
> worry
> > >> > about
> > >> > >> > > loading
> > >> > >> > > > >> at
> > >> > >> > > > >> all.
> > >> > >> > > > >>
> > >> > >> > > > >>
> > >> > >> > > > >> On Tue, May 21, 2013 at 8:03 PM,
Jesse <
> > >> > purplecabbage@gmail.com>
> > >> > >> > > wrote:
> > >> > >> > > > >>
> > >> > >> > > > >> > Sorry for jumping in late ...
> > >> > >> > > > >> >
> > >> > >> > > > >> > On Friday Fil and I tested a
workaround for
> > >>plugin_loader's
> > >> > >> use of
> > >> > >> > > XHR
> > >> > >> > > > >> to
> > >> > >> > > > >> > load plugins.
> > >> > >> > > > >> > The gist is that instead of
XHR load, it would first
> > >>write
> > >> a
> > >> > >> > script
> > >> > >> > > > tag
> > >> > >> > > > >> for
> > >> > >> > > > >> > the cordova_plugins.js file,
which defines the list of
> > >> > plugins
> > >> > >> (
> > >> > >> > > much
> > >> > >> > > > >> the
> > >> > >> > > > >> > same way that cordova_plugins.json
was ) then the
> plugin
> > >> list
> > >> > >> was
> > >> > >> > > > >> processed
> > >> > >> > > > >> > in exactly the same way.
> > >> > >> > > > >> > This change affects all cordova-js
platforms as well
> as
> > >> > >> > > > cordova-plugman,
> > >> > >> > > > >> > and I would like to get it into
2.8.0rc1 if I can have
> > >>the
> > >> > next
> > >> > >> > > couple
> > >> > >> > > > >> > hours to do so.
> > >> > >> > > > >> >
> > >> > >> > > > >> > On Friday we verified that it
worked as expected for
> > >>iOS,
> > >> > >> Android,
> > >> > >> > > > >> > BlackBerry, WP7 and WP8.
> > >> > >> > > > >> >
> > >> > >> > > > >> > The small change to cordova-js
can be seen here [1]
> > >>minus
> > >> > some
> > >> > >> > extra
> > >> > >> > > > >> error
> > >> > >> > > > >> > checking.
> > >> > >> > > > >> > And the change to plugman [2]
> > >> > >> > > > >> >
> > >> > >> > > > >> > [1]
> https://github.com/purplecabbage/cordova-js/tree/PL
> > >> > >> > > > >> > [2] https://github.com/apache/cordova-plugman/tree/pl
> > >> > >> > > > >> >
> > >> > >> > > > >> > This fix puts in a better position
for dynamically
> > >>loading
> > >> > >> plugins
> > >> > >> > > > going
> > >> > >> > > > >> > forward, although that work
is ongoing in the 3.0.0
> > >>branch.
> > >> > >> > > > >> >
> > >> > >> > > > >> > Just a little background on
the issue:
> > >> > >> > > > >> > Currently Windows Phone 7 and
8 immediately fail to
> load
> > >> > >> anything
> > >> > >> > > > local
> > >> > >> > > > >> via
> > >> > >> > > > >> > XHR because of a misinformed
security policy that
> > >>prevents
> > >> > it.
> > >> > >> > >  After
> > >> > >> > > > >> > deviceready any local XHR requests
are serviced by the
> > >>File
> > >> > API
> > >> > >> > and
> > >> > >> > > an
> > >> > >> > > > >> XHR
> > >> > >> > > > >> > shim.
> > >> > >> > > > >> >
> > >> > >> > > > >> > @purplecabbage
> > >> > >> > > > >> > risingj.com
> > >> > >> > > > >> >
> > >> > >> > > > >> >
> > >> > >> > > > >> > On Tue, May 21, 2013 at 4:47
PM, Bryan Higgins <
> > >> > >> > > > bhiggins@blackberry.com
> > >> > >> > > > >> > >wrote:
> > >> > >> > > > >> >
> > >> > >> > > > >> > > Both of those BB10 issues
have now been resolved.
> > >> > >> > > > >> > >
> > >> > >> > > > >> > >
> > >> > >> > > > >> > > On Tue, May 21, 2013 at
1:09 PM, Bryan Higgins <
> > >> > >> > > > >> bryan@bryanhiggins.net
> > >> > >> > > > >> > > >wrote:
> > >> > >> > > > >> > >
> > >> > >> > > > >> > > > There are a couple
of BB10 related issues I'd like
> > >>to
> > >> get
> > >> > >> in:
> > >> > >> > > > >> > > > https://issues.apache.org/jira/browse/CB-3434
> > >> > >> > > > >> > > > https://issues.apache.org/jira/browse/CB-3415
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > > I should be able to
complete both by EOD.
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > > On Tue, May 21, 2013
at 1:01 PM, Michael Brooks <
> > >> > >> > > > >> > > michael@michaelbrooks.ca>wrote:
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > >> >
> > >> > >> > > > >> > > >> > The one thing
that I'd like to see finished up
> is
> > >> > >> > > > >> > > >> >
> > >> https://issues.apache.org/jira/browse/CB-3307(Renaming
> > >> > >> > > > >> > > >> cordova.VERSION.js
> > >> > >> > > > >> > > >> > -> cordova.js).
It's done for iOS & Android,
> but
> > >> still
> > >> > >> > needs
> > >> > >> > > to
> > >> > >> > > > >> be
> > >> > >> > > > >> > > done
> > >> > >> > > > >> > > >> for
> > >> > >> > > > >> > > >> > other platforms.
I'll create sub-tasks for them
> > >>now.
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >> Good catch Andrew.
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >> I've also created
tasks for updating the Hello
> > >>World
> > >> and
> > >> > >> CLI
> > >> > >> > as
> > >> > >> > > > >> well.
> > >> > >> > > > >> > > I'll
> > >> > >> > > > >> > > >> try to have these
finished by EOD.
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >> On Tue, May 21,
2013 at 9:13 AM, Filip Maj <
> > >> > fil@adobe.com
> > >> > >> >
> > >> > >> > > > wrote:
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >> > Yes good
call Andrew definitely need that done
> > >> across
> > >> > >> > > platforms
> > >> > >> > > > >> > before
> > >> > >> > > > >> > > >> we
> > >> > >> > > > >> > > >> > ship another
release.
> > >> > >> > > > >> > > >> >
> > >> > >> > > > >> > > >> > On 5/21/13
9:11 AM, "Andrew Grieve" <
> > >> > >> agrieve@chromium.org>
> > >> > >> > > > >> wrote:
> > >> > >> > > > >> > > >> >
> > >> > >> > > > >> > > >> > >Checking
back in to see if anyone has anything
> > >> > they're
> > >> > >> > > trying
> > >> > >> > > > to
> > >> > >> > > > >> > get
> > >> > >> > > > >> > > in
> > >> > >> > > > >> > > >> > >for
> > >> > >> > > > >> > > >> > >2.8.
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >If no
one has anything by the EOD, then I'll
> > >>take
> > >> > care
> > >> > >> of
> > >> > >> > > > >> > branching &
> > >> > >> > > > >> > > >> > >tagging
& JIRA'ing this time around. I've been
> > >> adding
> > >> > >> > > > branching
> > >> > >> > > > >> &
> > >> > >> > > > >> > > >> tagging
> > >> > >> > > > >> > > >> > >powers
to coho, so want to test out the
> changes
> > >> this
> > >> > >> > release
> > >> > >> > > > :).
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >The one
thing that I'd like to see finished up
> > >>is
> > >> > >> > > > >> > > >> > >
> > >> > https://issues.apache.org/jira/browse/CB-3307(Renaming
> > >> > >> > > > >> > > >> > cordova.VERSION.js
> > >> > >> > > > >> > > >> > >->
cordova.js). It's done for iOS & Android,
> but
> > >> > still
> > >> > >> > needs
> > >> > >> > > > to
> > >> > >> > > > >> be
> > >> > >> > > > >> > > done
> > >> > >> > > > >> > > >> > >for
> > >> > >> > > > >> > > >> > >other
platforms. I'll create sub-tasks for
> them
> > >> now.
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >On Fri,
May 17, 2013 at 7:29 PM, Steven Gill <
> > >> > >> > > > >> > stevengill97@gmail.com
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > >> > >wrote:
> > >> > >> > > > >> > > >> > >
> > >> > >> > > > >> > > >> > >>
Sounds good to me.
> > >> > >> > > > >> > > >> > >>
> > >> > >> > > > >> > > >> > >>
> > >> > >> > > > >> > > >> > >>
On Fri, May 17, 2013 at 2:48 PM, Filip Maj <
> > >> > >> > fil@adobe.com
> > >> > >> > > >
> > >> > >> > > > >> > wrote:
> > >> > >> > > > >> > > >> > >>
> > >> > >> > > > >> > > >> > >>
> +1!
> > >> > >> > > > >> > > >> > >>
>
> > >> > >> > > > >> > > >> > >>
> On 5/17/13 2:44 PM, "Jesse" <
> > >> > >> purplecabbage@gmail.com>
> > >> > >> > > > >> wrote:
> > >> > >> > > > >> > > >> > >>
>
> > >> > >> > > > >> > > >> > >>
> >Monday is a holiday in Canada, so I
> > >>propose we
> > >> > >> aim to
> > >> > >> > > do
> > >> > >> > > > >> our
> > >> > >> > > > >> > rc1
> > >> > >> > > > >> > > >> > >>ritual
> > >> > >> > > > >> > > >> > >>
on
> > >> > >> > > > >> > > >> > >>
> >Tuesday, May 14th
> > >> > >> > > > >> > > >> > >>
> >This still gives us a little time to
> close
> > >>the
> > >> > >> loop
> > >> > >> > on
> > >> > >> > > > any
> > >> > >> > > > >> > > >> > >>outstanding
> > >> > >> > > > >> > > >> > >>
> >items, and lots of time to test.
> > >> > >> > > > >> > > >> > >>
> >Thoughts?
> > >> > >> > > > >> > > >> > >>
> >
> > >> > >> > > > >> > > >> > >>
> >@purplecabbage
> > >> > >> > > > >> > > >> > >>
> >risingj.com
> > >> > >> > > > >> > > >> > >>
>
> > >> > >> > > > >> > > >> > >>
>
> > >> > >> > > > >> > > >> > >>
> > >> > >> > > > >> > > >> >
> > >> > >> > > > >> > > >> >
> > >> > >> > > > >> > > >>
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > > >
> > >> > >> > > > >> > >
> > >> > >> > > > >> >
> > >> > >> > > > >>
> > >> > >> > > > >
> > >> > >> > > > >
> > >> > >> > > >
> > >> > >> > >
> > >> > >> >
> > >> > >>
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message