cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Please look at this pull request
Date Tue, 14 May 2013 23:22:10 GMT
Thanks for testing it out Benn! I committed it and created an issue.
https://issues.apache.org/jira/browse/CB-3392


On Tue, May 14, 2013 at 5:33 PM, Benn Mapes <benn.mapes@gmail.com> wrote:

> Took a look at the request and found a few new errors with the windows
> create script since things have changed a bit. I just added quotes around
> the variables to keep it consistent with the other commands.
>
> I added a commit as well to fix the other changes. If someone with commit
> access to the repo could merge/rebase this in that would be great.
>
> Here is my pull request :
> https://github.com/apache/cordova-android/pull/55
>
>
> On Mon, May 13, 2013 at 6:21 PM, Simon MacDonald
> <simon.macdonald@gmail.com>wrote:
>
> > I don't have a PC right now to check this out but a lot of people on
> > WIndows have complained about this on the list and apparently this fixes
> > the issue:
> >
> > https://github.com/apache/cordova-android/pull/54
> >
> > Thanks...
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message