Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of iclelland@google.com
 designates 209.85.219.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOBL_k6puvpXmZc-du7x0hCg_qyFL08kg6Je0KTWbQ9wAqc_-A@mail.gmail.com>
References: 
 <CAOBL_k6puvpXmZc-du7x0hCg_qyFL08kg6Je0KTWbQ9wAqc_-A@mail.gmail.com>
Date: Mon, 29 Apr 2013 22:53:28 -0400
Message-ID: 
 <CAK_TSXJ32Z=zXrLPjLr+tomugzF4E83-CeFNCQpcZ+dTVxstYg@mail.gmail.com>
Subject: Re: [Android] Including okHttp as source might not be such a good
 idea
From: Ian Clelland <iclelland@google.com>
To: dev@cordova.apache.org
Content-Type: multipart/alternative; boundary=001a11c2ef86183d2304db8b1bdb

--001a11c2ef86183d2304db8b1bdb
Content-Type: text/plain; charset=UTF-8

Lets not try to force all developers to change their settings; that sounds
like a world of pain.

It should work as a jar -- I can't see any compelling reason to have the
source available in eclipse, except for debugging. If there are bugs in
that code, I would definitely prefer to be fixing them upstream, though,
rather than having our own fork.

Can we distribute the jar with cordova-android, rather than fetching it at
install time like with commons-codec? I'm fairly certain that the Apache
license allows that. Also, I don't think that OkHttp has tagged releases
like codec, and I think I would rather ship with tested versions rather
than pointing new users at whatever HEAD happens to be at at any given day.

If that's okay, I'll package it up, and replace the source with the jar on
master.


On Mon, Apr 29, 2013 at 6:17 PM, Joe Bowser <bowserj@gmail.com> wrote:

> Hey
>
> I'm currently working with Master and I'm noticing that Eclipse really
> hates all these @Override Annotations put in the code.  Since
> everyone's Eclipse will probably work slightly different in this
> regard, and I have no idea how fix this other than by deleting all the
> annotations, I propose that we use a jar for okHttp instead of the
> source, similar to how we use commons-codec.
>
> Alternatively, if we can figure out how to all agree on the same
> Eclipse settings for Java dev, perhaps that may help as well.  As of
> right now, I can't build master due to these stupid annotation errors.
>
> Joe
>

--001a11c2ef86183d2304db8b1bdb--