cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Kim <timki...@gmail.com>
Subject Re: Plugman Future Qs
Date Wed, 03 Apr 2013 20:51:42 GMT
Cool thanks!


On 3 April 2013 06:22, Braden Shepherdson <braden@google.com> wrote:

> 1. The assets are moved on --prepare now, based on the asset tags. The old
> behavior copied on install and expected the plugin to have a www directory.
>
> 2. That plugin fetching change looks fine at a glance. I've only been
> testing the local case, I don't actually know the state of the download
> repo. As long as it works for both cases, go for it.
>
> Braden
> On Apr 2, 2013 5:24 PM, "Tim Kim" <timkim85@gmail.com> wrote:
>
> > Hey Braden,
> >
> > I'm working on getting the plugman future branch tests running and I
> > noticed a couple of things:
> >
> > 1) Removal of moving the assets to the www/:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=commit;h=eeb5f0104f449ae5cac6045786874559fe1edf50
> >
> > Are we not doing this anymore?
> >
> > 2) Unable to fetch a plugin by name. ie, plugman --fetch --plugin
> > ChildBrowser --plugins_dir Foo
> >
> > I've got a fix for this to work in a branch here:
> >
> >
> https://github.com/timkim/plugman/commit/919f67fc386f4bd080ca67088e767a3190a36461
> >
> > But I am hesitant to merge it back since it kinda changes the flow of how
> > fetch works and maybe you had something different in mind.
> >
> > Let me know what you think.
> >
> >
> >
> >
> > --
> > Timothy Kim
> >
>



-- 
Timothy Kim

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message