cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: [cordova-cli] - config.xml handling: should that move into ./bin scripts?
Date Wed, 27 Mar 2013 00:00:34 GMT
I think as a first pass its ok to do things the brute force way until we
find a better way. And by expensive, what are we talking about? Seconds,
at most? Not a big deal IMO.

Can you expand on the variables thing, Anis?

On 3/26/13 11:00 AM, "Anis KADRI" <anis.kadri@gmail.com> wrote:

>Yeah that works but it's expensive and also would require users to
>re-enter
>some variables (in the case of C2M, facebook-connect and maps).
>
>
>On Tue, Mar 26, 2013 at 10:55 AM, Filip Maj <fil@adobe.com> wrote:
>
>> What if plugman worked a little more naively: on uninstall of plugin A,
>>it
>> runs through all plugins and uninstalls them, then runs through and
>> installs all plugins except for plugin A again.
>>
>> On 3/26/13 10:52 AM, "Anis KADRI" <anis.kadri@gmail.com> wrote:
>>
>> >Yeah. I've talking about that specific problem with one of the
>> >PhoneGap::Build guys. It's not easy. It is also not limited to
>>permissions
>> >but to every possible configuration entry including configuration that
>>has
>> >runtime variables in them (package names, api keys, etc...). The easy
>>and
>> >obvious solution would be to not delete configuration entries and
>>leave it
>> >up the to user but it's definitely not the cleanest solution ;-)
>> >
>> >
>> >On Mon, Mar 25, 2013 at 7:17 AM, Braden Shepherdson
>> ><braden@chromium.org>wrote:
>> >
>> >> Permissions require more clever handling than naive XML injection.
>>I'll
>> >>be
>> >> talking about that somewhat later. Permissions on Android need
>> >>de-duping,
>> >> and making sure that deleting one plugin that requires permission X
>> >>doesn't
>> >> remove that permission if another plugin still needs it.
>> >>
>> >> Braden
>> >>
>> >>
>> >> On Sun, Mar 24, 2013 at 2:57 AM, tommy-carlos Williams
>> >> <tommy@devgeeks.org>wrote:
>> >>
>> >> > +1
>> >> >
>> >> > On 24/03/2013, at 16:52, Dave Johnson <dave.c.johnson@gmail.com>
>> >>wrote:
>> >> >
>> >> > > it would make sense to have a separate project-level script that
>> >>would
>> >> > (for
>> >> > > android for example) contain stuff like setting the activity name
>> >> rather
>> >> > > than doing it all in create [1]. Ideally it would enable
>>changing of
>> >> app
>> >> > > package/id etc in an already existing project too.
>> >> > >
>> >> > > [1]
>> >> >
>> 
>>>>https://github.com/apache/cordova-android/blob/master/bin/create.js#L21
>>>>6
>> >> > >
>> >> > >
>> >> > > On Sat, Mar 23, 2013 at 7:20 PM, Filip Maj <fil@adobe.com>
wrote:
>> >> > >
>> >> > >>
>> >> > >>> In the future when we ship without core plugins it should
>>also, on
>> >> > android
>> >> > >>> at least, add appropriate permissions for the various
plugins.
>> >> > >>
>> >> > >> This is already handled by the plugin.xml spec, where you
can
>> >>attach
>> >> > >> arbitrary xml to any xml document that is platform-specific
>>(such
>> >>as
>> >> > >> android manifest).
>> >> > >>
>> >> > >>
>> >> >
>> >>
>>
>>


Mime
View raw message