cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryce Curtis <curtis.br...@gmail.com>
Subject Re: [Android] Seriously, WTF does baseUrl actually do?
Date Thu, 07 Mar 2013 15:58:32 GMT
If I recall, baseUrl was used for for a simplified whitelist checking
scheme.  It was the url path of the HTML page loaded with loadUrl().
If there are any problems with removing it, they would show up during
the manual tests.

On Wed, Mar 6, 2013 at 6:55 PM, Joe Bowser <bowserj@gmail.com> wrote:
> And when I say the tests pass, it didn't appear to break anything. :P
> On Mar 6, 2013 5:54 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
>
>> OK, I deleted it and all the tests pass. I'll check that in tomorrow.
>> On Mar 6, 2013 5:46 PM, "Andrew Grieve" <agrieve@chromium.org> wrote:
>>
>>> Yeah, I had a look at baseUrl last week and couldn't figure out what it
>>> was
>>> for. I figured it was something that you (joe) had added, but guess not!
>>> :P.
>>>
>>> Definitely agree that the best docs are inline with the code, except for
>>> maybe architectural type things.
>>>
>>>
>>> On Wed, Mar 6, 2013 at 8:42 PM, Marcel Kinard <cmarcelk@gmail.com> wrote:
>>>
>>> > I'd suggest putting the internal documentation inline with the code,
>>> such
>>> > as javadoc or block comments. Keep the docs right next to the code so
>>> they
>>> > are less likely to diverge over time.
>>> >
>>> > -- Marcel Kinard
>>> >
>>> > On Mar 6, 2013, at 7:31 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>> >
>>> > > Side note: We have too many weird obscure things in Cordova-Android
>>> > > that aren't well documented, like how we handle offline storage.
>>> > > Should we throw this in the wiki? Somwhere else?
>>> > >
>>> > > Joe
>>> >
>>> >
>>>
>>

Mime
View raw message