cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: [ALL PLATFORMS] <icon> element support in config.xml
Date Tue, 05 Mar 2013 18:05:25 GMT
I see no good reason for an online asset in a packaged app. I think we
can safely ignore that part of the spec. Slavish conformance will do
us no good. If somebody has an issue they can open an ... uhm ...
issue.

On Tue, Mar 5, 2013 at 9:54 AM, Joe Bowser <bowserj@gmail.com> wrote:
> OK, so the icon could exist online as well:
>
> <icon src="http://phonegap.com/foo/bar/res/hdpi/icon.png" />
>
> I have no idea what this problem is trying to solve, or why we need
> the icon tag other than to conform to the spec for the sake of
> conforming to the spec.  I don't think the icon should change at
> runtime, and I think it's fine if some of the paths don't exist on all
> platforms, since you can have multiple icon tags, right?
>
> On Tue, Mar 5, 2013 at 9:49 AM, Filip Maj <fil@adobe.com> wrote:
>> Right, the tool would certainly copy the icon into the right place. The
>> issue here is that config.xml is platform-agnostic, but we may coding
>> paths to icons that may or may not be platform-specific. Here's an
>> example, assuming paths are relative to native project root:
>>
>> <icon src="res/hdpi/icon.png" />
>> <icon src="www/res/icon.png" />
>>
>> The first one would be Android-specific, and the second one would NOT work
>> on Android. This is the kind of issue I'm looking to resolve.
>>
>> On 3/5/13 9:44 AM, "Joe Bowser" <bowserj@gmail.com> wrote:
>>
>>>Since it's compile time, the icon should be available anywhere.  Why
>>>would it need to be relative to the www directory?  I'm assuming the
>>>CLI would copy the appropriate files from wherever they are to where
>>>they would be on each platform, since I don't understand how it could
>>>work any other way.
>>>
>>>On Tue, Mar 5, 2013 at 9:41 AM, Filip Maj <fil@adobe.com> wrote:
>>>> That seems reasonable, thanks for your input guys.
>>>>
>>>> One more question that came up on the issue thread is, does the src
>>>>attrib
>>>> need to be relative to the www? The concern here being that you will
>>>>have
>>>> several megabytes of icon images in your application package that gets
>>>> used only for specific platforms, and only at compile time. I'm not sure
>>>> if there is some sort of convention we can come up with here to
>>>>alleviate
>>>> this problem (perhaps in the context of using the CLI tools?).
>>>>
>>>> On 3/4/13 10:19 PM, "Andrew Grieve" <agrieve@chromium.org> wrote:
>>>>
>>>>>I think we should plan for having all users using CLI. It really is a
>>>>>bit
>>>>>step forward. So... option b) is what sounds good to me. If users don't
>>>>>want to use CLI, then they shouldn't use the <icon> tag, and just
update
>>>>>the asset in the native spots manually.
>>>>>
>>>>>
>>>>>On Mon, Mar 4, 2013 at 1:18 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>>>>
>>>>>> This is compile-time, so I think that the CLI tool should take
>>>>>> responsibility for compile-time attributes.  Per-platform CLI is
>>>>>> already virtually unmaintainable as it is.
>>>>>>
>>>>>> On Mon, Mar 4, 2013 at 10:13 AM, Filip Maj <fil@adobe.com>
wrote:
>>>>>> > I've set up a parent issue to track progress [1].
>>>>>> >
>>>>>> > Since this is a compile-time property, how would we go about
>>>>>>supporting
>>>>>> it
>>>>>> > across all platforms? I'm thinking either a) need to add logic
into
>>>>>>each
>>>>>> > platform's CLI scripts to parse the contents of config.xml,
>>>>>>grab/verify
>>>>>> > icon assets, copy them over into appropriate place or b) move
that
>>>>>> > responsibility into the CLI tool, but then we'd need extra
>>>>>>documentation
>>>>>> > on how to update the icon on a per-platform basis in case users
are
>>>>>>not
>>>>>> > using the cli tools.
>>>>>> >
>>>>>> > Thoughts/questions/comments?
>>>>>> >
>>>>>> > [1] https://issues.apache.org/jira/browse/CB-2606
>>>>>> >
>>>>>>
>>>>
>>

Mime
View raw message