cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Jong <wjamesj...@gmail.com>
Subject Re: prompt dialog for the Notification API?
Date Tue, 12 Mar 2013 19:59:57 GMT
Great!  Thanks for all the feedback.  I'll start working on it.

Fil - on the helper scripts.  Is this something you want me to wait on before opening up the
JIRA for this?

Max - thanks for alerting me to the buttonLabels bug.

-James Jong

On Mar 12, 2013, at 3:32 PM, Filip Maj <fil@adobe.com> wrote:

> What Michal said!
> 
> I will sort out some helper scripts for filing issues like this soon-ish
> and let you guys know/provide an overview (came up in the F2F)
> 
> On 3/12/13 1:16 PM, "Michal Mocny" <mmocny@chromium.org> wrote:
> 
>> I think its generally the case that we don't want to hold back platforms
>> just because others will not have support, so I'de say go ahead with iOS
>> and Android without holding back.
>> 
>> However, whenever possible be cross platform friendly and make the job of
>> implementation elsewhere feasible.
>> 
>> The way to do this is to file a JIRA bug for the feature, and create
>> subtasks to implement on each platform (The major 4 are iOS, Android,
>> Windows Phone, BlackBerry), then assign the ones you plan to do to
>> yourself.
>> 
>> I'm not sure where best to document platform support for api's, but as
>> soon
>> as the feature lands anywhere, it should be documented publicly.
>> 
>> -Michal
>> 
>> 
>> On Tue, Mar 12, 2013 at 11:55 AM, Becky Gibson
>> <gibson.becky@gmail.com>wrote:
>> 
>>> +1
>>> 
>>> I think it would be worthwhile to add this.  We just need confirmation
>>> from
>>> the other platforms that this feature is available.
>>> 
>>> 
>>> 
>>> 
>>> On Mon, Mar 11, 2013 at 5:04 PM, James Jong <wjamesjong@gmail.com>
>>> wrote:
>>> 
>>>> I was looking at the Notification API and noticed that we have
>>> existing
>>>> support for alert and confirm dialogs but do not have one for prompt.
>>> I
>>>> think it would good to add this missing function to the Notification
>>> API.
>>>> It seems a natural fit alongside the alert and confirm methods.
>>>> 
>>>> To mirror the current dialogs in the Notification API, the js method
>>> would
>>>> look something like:
>>>> navigator.notification.prompt(message, promptCallback, [title],
>>>> [buttonLabels])
>>>> message: Dialog message to display (String)
>>>> promptCallback: Callback to invoke with index of button pressed (1 or
>>> 2).
>>>> (Function)
>>>> title: Dialog title (String) (Optional, Default: "Prompt")
>>>> buttonLabels: Comma separated string with button labels (String)
>>>> (Optional, Default: "OK,Cancel")
>>>> 
>>>> The goal would be to have this across all our supported platforms.  I
>>>> would like to create a JIRA item and have sub-tasks for each
>>> platform.  I
>>>> plan on contributing the code for iOS and Android.  I also will update
>>>> mobile-spec tests and write the API documentation.
>>>> 
>>>> My questions are:
>>>> (1) Is this a reasonable addition to the Notification API?
>>>> (2a) If so, can we initially have support for a few platforms and add
>>> more
>>>> as we go along?
>>>> (2b) Can we go ahead and publicly document the API or wait until we
>>> have
>>>> support across the platforms?
>>>> 
>>>> If we agree this is good to have, here's the summary of tasks I plan
>>> to
>>>> proceed with:
>>>> create a JIRA issue with sub-tasks for each platform
>>>> contribute the code for iOS and Android
>>>> add prompt tests to mobile-spec
>>>> create the prompt API documentation
>>>> 
>>>> Thoughts or comments?
>>>> 
>>>> -James Jong
>>> 
> 


Mime
View raw message