cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Jong <wjamesj...@gmail.com>
Subject Re: Image Meta Data workaround for iOS
Date Sat, 09 Mar 2013 17:26:25 GMT
Sounds good.  Thanks Lorin!

-James Jong

On Mar 9, 2013, at 11:24 AM, Lorin Beer <lorin.beer.dev@gmail.com> wrote:

> James:
> 2.6 will include the permanent fix. The workaround alters the expected
> return value for camera.getPicture from the image picker source only. This
> would be an undesirable unevenness in the api on iOS. When this issue was
> originally being discussed, it was deemed that full Exif header writing
> support was the most desirable solution.
> 
> The exif writing support currently lives here:
> https://github.com/lorinbeer/incubator-cordova-ios/tree/CB-1246
> Specifically, the files CDVImageHeaderWriter.h, CDVImageHeaderWriter.m, and
> ExifData.h
> 
> I will be migrating the code to the new repos early this week, and making
> sure it is fully commented, then asking Shaz and the list for feedback. The
> commenting is especially important, because given the nature of Exif
> headers (opaque is one word) the code would be very difficult to maintain
> without complete explanations.
> 
> - Lorin
> 
> 
> On Sat, Mar 9, 2013 at 5:59 AM, James Jong <wjamesjong@gmail.com> wrote:
> 
>> Lorin:
>> Will 2.6 include the permanent fix or the workaround in your branch?
>> 
>> -James Jong
>> 
>> On Mar 7, 2013, at 11:18 PM, Lorin Beer <lorin.beer.dev@gmail.com> wrote:
>> 
>>> I've written a small workaround for getting at image meta data for images
>>> taken through camera.getPicture on iOS
>>> 
>>> Currently, UIImagePickerController embeds only a couple exif data entries
>>> in the jpeg header of the resulting image. We've put together exif
>> support,
>>> and it should make it to 2.6.0. Until then, if anyone's interested, I
>> have
>>> a workaround in my github forks
>>> 
>>> The branch:
>>> https://github.com/lorinbeer/cordova-ios/tree/cb1285_hack
>>> The change:
>>> 
>> https://github.com/lorinbeer/cordovaios/commit/a0ba48700c8e13f1d873ded361bf91a1a2271dce
>>> 
>>> This modifies the camera return value, converting the metadata dictionary
>>> returned by UIImagePickerController to a json string, and returns it
>>> bundled with image url in the return value.
>>> 
>>> Example usage can be found here:
>>> https://github.com/lorinbeer/cordova-mobile-spec/tree/camdatahack]
>>> here specifically:
>>> 
>> https://github.com/lorinbeer/cordova-mobile-spec/blob/camdatahack/camera/index.html
>>> 
>>> Note that this is a temporary workaround, and not a suggestion to alter
>> the
>>> camera.getPicture return values in any official way.
>>> 
>>> Ping me if you are interested in any further details.
>>> 
>>> - Lorin
>> 
>> 


Mime
View raw message