Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of purplecabbage@gmail.com
 designates 209.85.128.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAESi+4-FLSGt-1FboqDAeiq+mQ7cQd1zdGNg8DpOQ6Bo8jRKXQ@mail.gmail.com>
References: 
 <CAESi+4-FLSGt-1FboqDAeiq+mQ7cQd1zdGNg8DpOQ6Bo8jRKXQ@mail.gmail.com>
Date: Thu, 14 Feb 2013 17:25:38 -0800
Message-ID: 
 <CAKP6k2ujON1AUO7Q5pUNhE9pQ8c0ec8aNRAA9VDGDbmVfCFDNQ@mail.gmail.com>
Subject: Re: Small change to CompassHeading object
From: Jesse <purplecabbage@gmail.com>
To: dev@cordova.apache.org
Content-Type: multipart/alternative; boundary=f46d043892e1c0b7c404d5b94027

--f46d043892e1c0b7c404d5b94027
Content-Type: text/plain; charset=ISO-8859-1

No reliance on null in WP7+8 or Windows 8.

On Thu, Feb 14, 2013 at 4:19 PM, Gord Tanner <gtanner@gmail.com> wrote:

> I noticed a bug when working on Ripple in Compass Heading:
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commitdiff;h=6133a7e05bcd2ddc4a15591cf79cda965cbaf1ab
>
> When any of these values were 0 (which is a valid heading if you are facing
> perfectly north) it would set the value of the property to null.
>
> I figured setting to undefined was just as good as setting to null so I got
> rid of the fallback OR case.
>
> Does any platform rely on these values being null if they are not provided
> in the constructor?
>
> I am going to also do a larger sweep of the javascript layer to see if we
> have any of these other falsy bugs.
>


-- 
@purplecabbage
risingj.com

--f46d043892e1c0b7c404d5b94027--