Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B9FDEF09 for ; Wed, 20 Feb 2013 14:57:11 +0000 (UTC) Received: (qmail 52350 invoked by uid 500); 20 Feb 2013 14:57:10 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 51916 invoked by uid 500); 20 Feb 2013 14:57:04 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 51864 invoked by uid 99); 20 Feb 2013 14:57:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Feb 2013 14:57:02 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mmocny@google.com designates 209.85.214.46 as permitted sender) Received: from [209.85.214.46] (HELO mail-bk0-f46.google.com) (209.85.214.46) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Feb 2013 14:56:57 +0000 Received: by mail-bk0-f46.google.com with SMTP id j5so3674654bkw.33 for ; Wed, 20 Feb 2013 06:56:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=/SjR0zOmGvN89Xq9+mnNyTrjdoV1ViVCu47rYagQBOw=; b=RNodZzOyBLOidv92vSa0X95OflGkAYdhTeCCuahesxc1MzIYKw/nhBObXRIFb68jvN lpDvd6kbHi+TRTSN251SSOqbDIhdU+jo4sn/xyyPEgjDZctpoO36HccQI+i+s5ZOwXdg BpsreZ0bAassRi6/zmhLaDRLTjoje/kxFtyVrjqLNXrRmaBmZ88k7oh4fLTH2m6qW3mW fuJFtTmz8jX2q54qbJOlUaQgif36H2ZdkkdW/Z6xct6jKpKXyKr30rtJoKj5BYtlDwbo xqOWLDEFjWIEhsAz1J+5nNMb2oRPmcTjbas1Wc5yUA7Am2w7JMPLlIs6TDydEaPHyjJ6 1bZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=/SjR0zOmGvN89Xq9+mnNyTrjdoV1ViVCu47rYagQBOw=; b=HzSEouRkR9RL6YOlQ7ON7osyCSTxIWOyZa4q1oxVJjU1klgQ8YlDJ/XK3RfTybh/k4 wvHmhXwX4SrM0s9jtAzyEqgWQQqNu2mlWFqhSpFRnW0YNGim0zq+3DPwH2yyWnsQhPiH hdjWxhFwdxqxVl3WbVadS5uX+skhjfi+8diZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :x-gm-message-state; bh=/SjR0zOmGvN89Xq9+mnNyTrjdoV1ViVCu47rYagQBOw=; b=n2YslWUenCg7nPRHMHVv7a2JR3v7MPUkBZCoTrWu/K7KkglEznIGUJWbqe2TKlBWbE ODhareIobV2n1k/FtPju0phv/zDzp2ecuD3/DS4GfmzNEyZ51Mw9dE4+DeLaIRmBVDIK /NeHsnCfAB0ZG3RtMWCXliaVWHVFGXTGsZTHiwswKerzLvWxrZ30jtI0v/YZCgcbTkLv oO49yEi/12vvy15yN7lC5VtkM/l+z1ht1wmp8k2KSSqT1jhyBZgjNLQNrniaNsmCOlVX 0FHJSDvH8e1PcGtfnoHb5qIG+hiAXcrdwOG6m/T3iatajUzy+OdNpbVMwCptR9JrYQ/M A80Q== MIME-Version: 1.0 X-Received: by 10.204.155.73 with SMTP id r9mr8828667bkw.51.1361372195524; Wed, 20 Feb 2013 06:56:35 -0800 (PST) Sender: mmocny@google.com Received: by 10.205.141.197 with HTTP; Wed, 20 Feb 2013 06:56:35 -0800 (PST) In-Reply-To: References: Date: Wed, 20 Feb 2013 09:56:35 -0500 X-Google-Sender-Auth: 3LE1Av3yjGn0D9CmnK4bYimZxSc Message-ID: Subject: Re: CDVViewController.commandDelegate From: Michal Mocny To: dev Content-Type: multipart/alternative; boundary=0015175cfa8e1f107a04d6292af3 X-Gm-Message-State: ALoCoQn1c0A5dMNdzD98fK3DujDs+nfa9CPI1JjBJzwo3/Wk+HheCJBsI5lq9oRwFc7rHykxYzWndgBkM2pLNx1Z2Lhm7j5BUV0FfNd/+rZGqOD8Gf0/4aBA2fjX5VDJtEtxhWpDFB9w+OFnkJzzVz7RCRwLjN6heIDeGj+eqMQUHi2eN4QcDvuMOWtVUU1za/ddjwq5RIkW X-Virus-Checked: Checked by ClamAV on apache.org --0015175cfa8e1f107a04d6292af3 Content-Type: text/plain; charset=ISO-8859-1 Thanks for mentioning this. Would you like to file that bug and/or submit a pull request? Also, do you have some motivating reason for moving to a "more protocol-based property"? I understand your twitch, but am curious if you are trying to replace with another implementation? -Michal On Tue, Feb 19, 2013 at 7:59 PM, Kevin Hawkins < kevin.hawkins.cordova@gmail.com> wrote: > Hi all, > > I'm looking through the CDVViewController implementation details on iOS, > and I'm not clear why its (public) commandDelegate property references the > concrete implementation class of the CDVCommandDelegate protocol > (CDVCommandDelegateImpl), as opposed to defining a more generic > protocol-based property. From an object-oriented design standpoint, that's > something I didn't expect. Is there a reason that this is different than > CDVPlugin's property definition? > > It's not a super big deal, though it sets off something twitchy in my > brain. ;-) What does need to change if it stays as-is, however, is that > CDVViewController.h should be #importing CDVCommandDelegateImpl.h, not > CDVCommandDelegate.h. The way it is currently, the responsibility of the > former header's inclusion is being improperly passed on to the inheriting > view controller class. And the latter header file's inclusion is > superfluous. > > I figured I'd get thoughts before filing a bug one way or another. > > Thanks, > Kevin > --0015175cfa8e1f107a04d6292af3--