cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: Testing MobileSpecTest
Date Wed, 27 Feb 2013 03:50:51 GMT
Its true, boils down to adding another script tag to cordova.android.js or
cordova.ios.js. *shrugs*

On 2/26/13 6:49 PM, "Michal Mocny" <mmocny@chromium.org> wrote:

>So I am trying to simplify making changes to mobile-spec itself.  With
>your
>workflow, its easy enough to run mobile-spec after making changes to
>js/platform, but if you make changes to mobile-spec which you want to
>push,
>you have to first clean up your repo.  Especially annoying when I want to
>run the spec again both ios and android.
>
>With my change, you can add symlinks that arent added to git repo and then
>you just push away.
>
>But I was just looking for other proposals/curious about others' workflow.
> I think my change shouldn't affect anyone, and will make my life easier
>(and hopefully yours too).
>
>-Michal
>
>
>On Tue, Feb 26, 2013 at 4:53 PM, Jesse <purplecabbage@gmail.com> wrote:
>
>> Yes, we all have our own processes, and Michal has his.
>> I don't think there is value in dictating how people should do it.
>>
>> On Tue, Feb 26, 2013 at 1:50 PM, Tim Kim <timkim85@gmail.com> wrote:
>>
>> > Ya I do pretty much that same thing that Fil does but for BlackBerry.
>>I'm
>> > not sure where the speed up would be for the BlackBerry side.
>> >
>> >
>> > On 26 February 2013 13:18, Filip Maj <fil@adobe.com> wrote:
>> >
>> > > I copy over the built cordova.xxx.js file to my project www/ folder
>>as
>> > > "cordova.js" and overwrite the "loader" script that is in
>>mobile-spec
>> > > currently under cordova.js.
>> > >
>> > > Doesn't that solve this problem?
>> > >
>> > > I.e.
>> > >
>> > >     $ cd cordova-android
>> > >     $ ./bin/create ../tmp
>> > >     $ cd ../cordova-js
>> > >     $ jake
>> > >     $ cp pkg/cordova.xxx.js ../tmp/assets/www/cordova.js
>> > >     $ cd ../tmp && ./cordova/debug
>> > >
>> > > On 2/26/13 11:53 AM, "Michal Mocny" <mmocny@chromium.org> wrote:
>> > >
>> > > >Thanks for heads up.
>> > > >
>> > > >-Michal
>> > > >
>> > > >
>> > > >On Tue, Feb 26, 2013 at 2:40 PM, Michael Brooks
>> > > ><michael@michaelbrooks.ca>wrote:
>> > > >
>> > > >> Perhaps wait for someone to verify that this works on their
>>system.
>> > > >>
>> > > >> A good number of us are at ApacheCon today and running at half
>> speed.
>> > > >>
>> > > >> Michael
>> > > >>
>> > > >> On Tue, Feb 26, 2013 at 11:26 AM, Michal Mocny
>><mmocny@chromium.org
>> >
>> > > >> wrote:
>> > > >>
>> > > >> > Bump.
>> > > >> >
>> > > >> > Is there any opposition to me landing this?  It should simplify
>> > > >> > testing&making changes to mobile-spec tests on dev work
in a
>>way
>> > that
>> > > >> > doesn't hurt normal git workflow.
>> > > >> >
>> > > >> > -Michal
>> > > >> >
>> > > >> >
>> > > >> > On Mon, Feb 25, 2013 at 4:00 PM, Michal Mocny <
>> mmocny@chromium.org>
>> > > >> wrote:
>> > > >> >
>> > > >> > > Actually, got this working, pushed a remote branch for
>>feedback:
>> > > >> > >
>> > > >> > > Commit:
>> > > >> > >
>> > > >> >
>> > > >>
>> > > >>
>> > >
>> >
>> 
>>http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/commit/9ec39e9
>> > > >>3
>> > > >> > >
>> > > >> > > We can add the other platforms, of course, and on windows
you
>> can
>> > > >>hard
>> > > >> > > link the file, I think?
>> > > >> > >
>> > > >> > > -Michal
>> > > >> > >
>> > > >> > >
>> > > >> > > On Mon, Feb 25, 2013 at 2:59 PM, Michal Mocny <
>> > mmocny@chromium.org>
>> > > >> > wrote:
>> > > >> > >
>> > > >> > >> Yeah I'm trying to prototype what I proposed and
I cannot
>>find
>> a
>> > > >>way
>> > > >> to
>> > > >> > >> test for file existence in a sync way, and the mobile
spec
>> tests
>> > > >>don't
>> > > >> > deal
>> > > >> > >> well with having cordova.js injected after page
load.  This
>>is
>> > > >> solvable
>> > > >> > but
>> > > >> > >> I'll shelve it until I get more feedback/interest
expressed.
>> > > >> > >>
>> > > >> > >> -Michal
>> > > >> > >>
>> > > >> > >>
>> > > >> > >> On Mon, Feb 25, 2013 at 2:43 PM, Jesse MacFadyen
<
>> > > >> > purplecabbage@gmail.com
>> > > >> > >> > wrote:
>> > > >> > >>
>> > > >> > >>> For every version, I do the following for WP7
and WP8 :
>> > > >> > >>>
>> > > >> > >>> - create a new project from the latest template
>> > > >> > >>> - remove the dll and link to the repo project
directly
>> > > >> > >>> - copy over mobile-spec
>> > > >> > >>> - modify cordova.js to include cordova.windowsphone.js
>> > > >> > >>> - add visual studio link to cordova-js output
pkg version
>> > > >> > >>>
>> > > >> > >>> Run tests, debug, fix, rebuild, retest...
>> > > >> > >>>
>> > > >> > >>> With this setup, I can modify cordova-js, rebuild
and
>>retest,
>> as
>> > > >>well
>> > > >> > >>> as do the same on the native side.
>> > > >> > >>>
>> > > >> > >>> Fwiw, I don't think there is a generic solution.
Any sim
>>link
>> > idea
>> > > >> you
>> > > >> > >>> have is likely gonna fail in windows, and this
will
>>ultimately
>> > > >>make
>> > > >> > >>> things more difficult for someone. I could be
wrong.
>> > > >> > >>>
>> > > >> > >>> Cheers,
>> > > >> > >>>   Jesse
>> > > >> > >>>
>> > > >> > >>> Sent from my iPhone5
>> > > >> > >>>
>> > > >> > >>> On 2013-02-25, at 11:15 AM, Michal Mocny
>><mmocny@google.com>
>> > > >>wrote:
>> > > >> > >>>
>> > > >> > >>> How do other devs test mobile spec locally?
>> > > >> > >>>
>> > > >> > >>> Specifically, how do you set up your repo to
test with your
>> > > >>working
>> > > >> > >>> cordova.js version, in a way that you can make
changes to
>> > > >>mobile-spec
>> > > >> > >>> tests, push local changes merge changes coming
from remote.
>> > > >> > >>>
>> > > >> > >>> I'm always overriding/clearing/overriding the
default
>> cordova.js
>> > > >>file
>> > > >> > in
>> > > >> > >>> order to test/merge/push etc.
>> > > >> > >>>
>> > > >> > >>> Proposal:
>> > > >> > >>> I change the current cordova.js file to: If
a local
>> > > >> cordova.PLATFORM.js
>> > > >> > >>> file exists, load that.  Otherwise, load cordova-VERSION.js
>> the
>> > > >>way
>> > > >> we
>> > > >> > do
>> > > >> > >>> now.
>> > > >> > >>>
>> > > >> > >>> Then, all you have to do is create a local symlink
to your
>> > > >>cordova.js
>> > > >> > and
>> > > >> > >>> never add that file to your git commits.
>> > > >> > >>>
>> > > >> > >>> Or, do others already have a good solution?
>> > > >> > >>>
>> > > >> > >>> -Michal
>> > > >> > >>>
>> > > >> > >>
>> > > >> > >>
>> > > >> > >
>> > > >> >
>> > > >>
>> > >
>> > >
>> >
>> >
>> > --
>> > Timothy Kim
>> >
>>
>>
>>
>> --
>> @purplecabbage
>> risingj.com
>>


Mime
View raw message