cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: Tag 2.5.0rc1?
Date Wed, 20 Feb 2013 20:07:02 GMT
K I've updated the JS tag. Platforms should grab the latest 2.5.0rc1 tag
from cordova-js and retag + retest.

On 2/20/13 12:02 PM, "Shazron" <shazron@gmail.com> wrote:

>Not clear (?) but I think so. I suppose all platforms get the new js and
>re-test, and re-tag.
>
>
>
>On Wed, Feb 20, 2013 at 11:53 AM, Filip Maj <fil@adobe.com> wrote:
>
>> So the JS needs to be retagged ya?
>>
>> On 2/20/13 11:03 AM, "Andrew Grieve" <agrieve@chromium.org> wrote:
>>
>> >Not this time actually. This was a refactor in cordova-js where I
>>forgot
>> >to
>> >"git add" the new files. It broke all existing tests.
>> >
>> >
>> >On Wed, Feb 20, 2013 at 1:37 PM, Michal Mocny <mmocny@chromium.org>
>> wrote:
>> >
>> >> Huzzah!
>> >>
>> >> I take it you pushed mobile spec test changes without the cordova-js
>> >>code
>> >> needed for them to pass?  This is the downside of multi-repo :(
>> >>
>> >> -Michal
>> >>
>> >>
>> >> On Wed, Feb 20, 2013 at 1:33 PM, Andrew Grieve
>> >><agrieve@chromium.org>wrote:
>> >>
>> >>> Okay, checked them into next branch, and merged them into master as
>> >>>well.
>> >>>
>> >>> Likely filetransfer is broken on all platforms without these files.
>> >>>
>> >>>
>> >>> On Wed, Feb 20, 2013 at 1:31 PM, Andrew Grieve
>><agrieve@chromium.org>
>> >>> wrote:
>> >>>
>> >>> > I think I've figured it out:
>> >>> >
>> >>> > agrieve@agrieve-macbookpro ~/git/cordova-js (next) $ git status
>> >>> > # On branch next
>> >>> > # Untracked files:
>> >>> > #   (use "git add <file>..." to include in what will be committed)
>> >>> > #
>> >>> > # lib/common/plugin/filetransfer/
>> >>> > # lib/windowsphone/plugin/filetransfer/
>> >>> > nothing added to commit but untracked files present (use "git
>>add" to
>> >>> > track)
>> >>> >
>> >>> > Whoops!
>> >>> >
>> >>> >
>> >>> > On Wed, Feb 20, 2013 at 1:07 PM, Becky Gibson <
>> gibson.becky@gmail.com
>> >>> >wrote:
>> >>> >
>> >>> >> For added data,  I also  fail using the tagged cordova-js
>> >>> >> (04e4ceafdcd59cdd937e873cc9006766c1e5940a) built locally.
>> >>> >>
>> >>> >>
>> >>> >> On Wed, Feb 20, 2013 at 12:40 PM, Shazron <shazron@gmail.com>
>> wrote:
>> >>> >>
>> >>> >> > I just generated the js from cordova-js on tag 2.5.0rc1
(hash
>> >>> >> > 04e4ceafdcd59cdd937e873cc9006766c1e5940a) and I get the
same
>> >>>results
>> >>> as
>> >>> >> > I've always had :/
>> >>> >> >
>> >>> >> > On Wed, Feb 20, 2013 at 9:34 AM, Andrew Grieve
>> >>><agrieve@chromium.org
>> >>> >
>> >>> >> > wrote:
>> >>> >> >
>> >>> >> > > Using the JS built from cordova-js it's working fine...
>> >>> >> > >
>> >>> >> > >
>> >>> >> > > On Wed, Feb 20, 2013 at 12:32 PM, Shazron <shazron@gmail.com>
>> >>> wrote:
>> >>> >> > >
>> >>> >> > > > Could be the symbol mapping.
>> >>> >> > > > Using Safari 6 iPhone Simulator debugging --
>> >>>window.FileTransfer
>> >>> is
>> >>> >> not
>> >>> >> > > > defined, but I can do a
>> >>> >> cordova.require("cordova/plugin/FileTransfer").
>> >>> >> > > >
>> >>> >> > > >
>> >>> >> > > > On Wed, Feb 20, 2013 at 9:27 AM, Shazron
>><shazron@gmail.com>
>> >>> wrote:
>> >>> >> > > >
>> >>> >> > > > > Don't know what's wrong - with mob-spec
3e3d075 on iOS
>> >>> 2.5.0rc1 it
>> >>> >> > > still
>> >>> >> > > > > all fails. Trying iOS 2.4.0 (with latest
mob-spec), it
>>all
>> >>> >> passes. I
>> >>> >> > > > > suspect its in the cordova-js, not mob-spec
>> >>> >> > > > >
>> >>> >> > > > >
>> >>> >> > > > > On Wed, Feb 20, 2013 at 9:17 AM, Shazron
>><shazron@gmail.com
>> >
>> >>> >> wrote:
>> >>> >> > > > >
>> >>> >> > > > >> Andrew, I re-verified and re-downloaded
2.5.0rc1 of iOS
>>and
>> >>> >> 2.5.0rc1
>> >>> >> > > of
>> >>> >> > > > >> mobile-spec, created a new project
- I get the same
>>results
>> >>> as I
>> >>> >> had
>> >>> >> > > > (both
>> >>> >> > > > >> in Simulator and device as well).
>> >>> >> > > > >>
>> >>> >> > > > >>
>> >>> >> > > > >>
>> >>> >> > > > >> On Wed, Feb 20, 2013 at 8:46 AM, Andrew
Grieve <
>> >>> >> > agrieve@chromium.org
>> >>> >> > > > >wrote:
>> >>> >> > > > >>
>> >>> >> > > > >>> Just tried the tests and they are
all passing for me
>>(on
>> >>> >> simulator)
>> >>> >> > > > >>>
>> >>> >> > > > >>>
>> >>> >> > > > >>> On Wed, Feb 20, 2013 at 11:38 AM,
Becky Gibson <
>> >>> >> > > gibson.becky@gmail.com
>> >>> >> > > > >>> >wrote:
>> >>> >> > > > >>>
>> >>> >> > > > >>> > This morning I did   git pull
apache next for
>> >>>mobile-spec
>> >>> and
>> >>> >> got
>> >>> >> > > > this:
>> >>> >> > > > >>> > Updating 3e3d075..842e603
>> >>> >> > > > >>> > Fast-forward
>> >>> >> > > > >>> >  VERSION                 
            |  2 +-
>> >>> >> > > > >>> >  autotest/tests/file.tests.js
        | 14
>> >>>++++++++++----
>> >>> >> > > > >>> >  autotest/tests/filetransfer.tests.js
| 27
>> >>> >> > > > +++++++++++++++++++++------
>> >>> >> > > > >>> >  cordova.js              
            |  2 +-
>> >>> >> > > > >>> >  index.html              
            |  1 +
>> >>> >> > > > >>> >  misc/index.html         
            |  3 ++-
>> >>> >> > > > >>> >  misc/page2.html         
            | 27
>> >>> >> > > > ++++++++++++++++++++++-----
>> >>> >> > > > >>> >  splashscreen/index.html 
            | 47
>> >>> >> > > > >>> > +++++++++++++++++++++++++++++++++++++++++++++++
>> >>> >> > > > >>> >  8 files changed, 105 insertions(+),
18 deletions(-)
>> >>> >> > > > >>> >  create mode 100644 splashscreen/index.html
>> >>> >> > > > >>> >
>> >>> >> > > > >>> > Does that help?
>> >>> >> > > > >>> >
>> >>> >> > > > >>> >
>> >>> >> > > > >>> >
>> >>> >> > > > >>> > On Wed, Feb 20, 2013 at 11:27
AM, Shazron <
>> >>> shazron@gmail.com>
>> >>> >> > > wrote:
>> >>> >> > > > >>> >
>> >>> >> > > > >>> > > That was my suspicion
but i have no data on this
>>yet.
>> >>> Which
>> >>> >> > > > >>> > > mob-spec version? I can
verify.
>> >>> >> > > > >>> > >
>> >>> >> > > > >>> > > On Wednesday, February
20, 2013, Becky Gibson
>>wrote:
>> >>> >> > > > >>> > >
>> >>> >> > > > >>> > > > Just an FYI - I
ran mobile-spec yesterday (using
>>an
>> >>> older
>> >>> >> > > > version)
>> >>> >> > > > >>> and
>> >>> >> > > > >>> > I
>> >>> >> > > > >>> > > > only had one failure
so maybe the issue is with
>>the
>> >>> tests
>> >>> >> > > > >>> themselves.
>> >>> >> > > > >>> > > >
>> >>> >> > > > >>> > > >
>> >>> >> > > > >>> > > > On Wed, Feb 20,
2013 at 11:11 AM, Shazron <
>> >>> >> shazron@gmail.com
>> >>> >> > > > >>> > > <javascript:;>>
>> >>> >> > > > >>> > > > wrote:
>> >>> >> > > > >>> > > >
>> >>> >> > > > >>> > > > > On iOS just
touch and hold, drag then copy :)
>> >>> >> > > > >>> > > > >
>> >>> >> > > > >>> > > > > On Wednesday,
February 20, 2013, Michal Mocny
>> >>>wrote:
>> >>> >> > > > >>> > > > >
>> >>> >> > > > >>> > > > > > Shaz how
did you generate that text file
>>output?
>> >>>  Did
>> >>> >> you
>> >>> >> > > > open
>> >>> >> > > > >>> > remote
>> >>> >> > > > >>> > > > > > inspector
and copy console output manually?
>> >>> >> > > > >>> > > > > >
>> >>> >> > > > >>> > > > > >
>> >>> >> > > > >>> > > > > > On Wed,
Feb 20, 2013 at 3:33 AM, Shazron <
>> >>> >> > > shazron@gmail.com
>> >>> >> > > > >>> > > <javascript:;>
>> >>> >> > > > >>> > > > <javascript:;>>
>> >>> >> > > > >>> > > > > > wrote:
>> >>> >> > > > >>> > > > > >
>> >>> >> > > > >>> > > > > > > Tried
mob-spec on an iPhone 3GS running
>>6.0.1
>> >>>(to
>> >>> >> rule
>> >>> >> > > out
>> >>> >> > > > >>> any
>> >>> >> > > > >>> > > errors
>> >>> >> > > > >>> > > > > due
>> >>> >> > > > >>> > > > > > > to
the new 6.1.2 update) - same number of
>> >>>errors
>> >>> as
>> >>> >> the
>> >>> >> > > > >>> previous
>> >>> >> > > > >>> > > two
>> >>> >> > > > >>> > > > > > > devices.
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > > > On
Wed, Feb 20, 2013 at 12:23 AM, Shazron <
>> >>> >> > > > shazron@gmail.com
>> >>> >> > > > >>> > > <javascript:;>
>> >>> >> > > > >>> > > > > <javascript:;>>
>> >>> >> > > > >>> > > > > > wrote:
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > > > >
I tagged iOS 2.5.0rc1 but there are 22
>> >>> mobile-spec
>> >>> >> > > > >>> failures (21
>> >>> >> > > > >>> > > > > related
>> >>> >> > > > >>> > > > > > > to
>> >>> >> > > > >>> > > > > > > >
filetransfer). I'll examine them tomorrow
>> >>>and
>> >>> fix
>> >>> >> > for a
>> >>> >> > > > >>> re-tag.
>> >>> >> > > > >>> > > The
>> >>> >> > > > >>> > > > > > > >
mobile-spec failures are attached as a
>>text
>> >>> file.
>> >>> >> > > Tested
>> >>> >> > > > >>> on an
>> >>> >> > > > >>> > > > > iPhone 5
>> >>> >> > > > >>> > > > > > > >
with iOS 6.1.2 and iPhone 4 with iOS
>>5.1.1,
>> >>> exact
>> >>> >> > same
>> >>> >> > > > >>> > failures.
>> >>> >> > > > >>> > > > > > > >
>> >>> >> > > > >>> > > > > > > >
>> >>> >> > > > >>> > > > > > > >
On Tue, Feb 19, 2013 at 3:16 PM, Herm
>>Wong <
>> >>> >> > > > >>> > > > >
>> >>>kingoftheoaks@hotmail.com<javascript:;><javascript:;>
>> >>> >> > > > >>> > > > > > > >wrote:
>> >>> >> > > > >>> > > > > > > >
>> >>> >> > > > >>> > > > > > > >>
webOS has been tagged 2.5.0rc1.
>> >>> >> > > > >>> > > > > > > >>
>> >>> >> > > > >>> > > > > > > >>
> From: shazron@gmail.com <javascript:;>
>> >>> >> > > <javascript:;>
>> >>> >> > > > >>> > > > > > > >>
> Date: Tue, 19 Feb 2013 14:46:08 -0800
>> >>> >> > > > >>> > > > > > > >>
> Subject: Re: Tag 2.5.0rc1?
>> >>> >> > > > >>> > > > > > > >>
> To:
>>dev@cordova.apache.org<javascript:;>
>> >>> >> > > > >>> <javascript:;>
>> >>> >> > > > >>> > > > > > > >>
>
>> >>> >> > > > >>> > > > > > > >>
> Will do the same EOD today for
>> >>>Eye-Oh-Ess,
>> >>> >> > wrapping
>> >>> >> > > > >>> things
>> >>> >> > > > >>> > up.
>> >>> >> > > > >>> > > > > > > >>
>
>> >>> >> > > > >>> > > > > > > >>
>
>> >>> >> > > > >>> > > > > > > >>
> On Tue, Feb 19, 2013 at 11:55 AM, Joe
>> >>> Bowser <
>> >>> >> > > > >>> > > bowserj@gmail.com<javascript:;>
>> >>> >> > > > >>> > > > > <javascript:;>
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > > > wrote:
>> >>> >> > > > >>> > > > > > > >>
>
>> >>> >> > > > >>> > > > > > > >>
> > Gone through the same process with
>>Fil.
>> >>>  If
>> >>> >> we
>> >>> >> > > fail,
>> >>> >> > > > >>> we
>> >>> >> > > > >>> > fail
>> >>> >> > > > >>> > > > > > > >>
together!!!!
>> >>> >> > > > >>> > > > > > > >>
> >
>> >>> >> > > > >>> > > > > > > >>
> > On Tue, Feb 19, 2013 at 11:50 AM,
>>Filip
>> >>> Maj <
>> >>> >> > > > >>> > fil@adobe.com
>> >>> >> > > > >>> > > <javascript:;>
>> >>> >> > > > >>> > > > > <javascript:;>>
>> >>> >> > > > >>> > > > > > wrote:
>> >>> >> > > > >>> > > > > > > >>
> > > I've creatd the JIRA issues for
>> >>>2.5.0rc1
>> >>> >> > > tagging.
>> >>> >> > > > >>> > > > > > > >>
> > >
>> >>> >> > > > >>> > > > > > > >>
> > > Also created a new "next" branch
>> >>>under
>> >>> the
>> >>> >> > > > >>> javascript
>> >>> >> > > > >>> > and
>> >>> >> > > > >>> > > > > tagged
>> >>> >> > > > >>> > > > > > > >>
2.5.0rc1
>> >>> >> > > > >>> > > > > > > >>
> > > from that branch.. Hope I did it
>> >>>right
>> >>> :s
>> >>> >> > > > >>> > > > > > > >>
> > >
>> >>> >> > > > >>> > > > > > > >>
> > > On 2/19/13 11:32 AM, "Brian
>>LeRoux" <
>> >>> >> > b@brian.io
>> >>> >> > > > >>> > > <javascript:;>
>> >>> >> > > > >>> > > > <javascript:;>>
>> >>> >> > > > >>> > > > > > wrote:
>> >>> >> > > > >>> > > > > > > >>
> > >
>> >>> >> > > > >>> > > > > > > >>
> > >>Sounds about right. Lets aim to
>>get
>> >>>this
>> >>> >> thing
>> >>> >> > > > >>> > > tagged/bagged
>> >>> >> > > > >>> > > > > > > today.
>> >>> >> > > > >>> > > > > > > >>
> > >>
>> >>> >> > > > >>> > > > > > > >>
> > >>On Tue, Feb 19, 2013 at 11:23 AM,
>> >>>Filip
>> >>> >> Maj <
>> >>> >> > > > >>> > > fil@adobe.com<javascript:;>
>> >>> >> > > > >>> > > > > <javascript:;>
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > > > wrote:
>> >>> >> > > > >>> > > > > > > >>
> > >>
>> >>> >> > > > >>> > > > > > > >>
> > >>> I fear change! But let's do it.
>> >>> >> > > > >>> > > > > > > >>
> > >>>
>> >>> >> > > > >>> > > > > > > >>
> > >>> On 2/19/13 11:19 AM, "Joe
>>Bowser" <
>> >>> >> > > > >>> bowserj@gmail.com
>> >>> >> > > > >>> > > <javascript:;>
>> >>> >> > > > >>> > > > > <javascript:;>>
>> >>> >> > > > >>> > > > > > wrote:
>> >>> >> > > > >>> > > > > > > >>
> > >>>
>> >>> >> > > > >>> > > > > > > >>
> > >>> >So, how does this work? Do we
>> >>>create
>> >>> the
>> >>> >> > next
>> >>> >> > > > >>> branch
>> >>> >> > > > >>> > > now
>> >>> >> > > > >>> > > > > and
>> >>> >> > > > >>> > > > > > > >>
throw
>> >>> >> > > > >>> > > > > > > >>
> > >>> >things in that?
>> >>> >> > > > >>> > > > > > > >>
> > >>>
>> >>> >> > > > >>> > > > > > > >>
> > >>>
>> >>> >> > > > >>> > > > > > > >>
> > >
>> >>> >> > > > >>> > > > > > > >>
> >
>> >>> >> > > > >>> > > > > > > >>
>> >>> >> > > > >>> > > > > > > >>
>> >>> >> > > > >>> > > > > > > >
>> >>> >> > > > >>> > > > > > > >
>> >>> >> > > > >>> > > > > > >
>> >>> >> > > > >>> > > > > >
>> >>> >> > > > >>> > > > >
>> >>> >> > > > >>> > > >
>> >>> >> > > > >>> > >
>> >>> >> > > > >>> >
>> >>> >> > > > >>>
>> >>> >> > > > >>
>> >>> >> > > > >>
>> >>> >> > > > >
>> >>> >> > > >
>> >>> >> > >
>> >>> >> >
>> >>> >>
>> >>> >
>> >>> >
>> >>>
>> >>
>> >>
>>
>>


Mime
View raw message