Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Date: Tue, 15 Jan 2013 19:18:14 +0000 (UTC)
From: "Andrew Grieve (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <JIRA.12622842.1354842967453.139211.1358277494599@arcas>
In-Reply-To: <JIRA.12622842.1354842967453@arcas>
References: <JIRA.12622842.1354842967453@arcas>
Subject: [jira] [Resolved] (CB-1978) Cordova 2.2 iOS does not work with
 RequireJS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CB-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve resolved CB-1978.
-------------------------------

    Resolution: Fixed

Okay, thanks for being patient with us! I've added a test to our suite and fixed the problem for real.

If anyone wants to patch their existing 2.3 code to fix the problem, you can change:
    [self.commandDelegate evalJs:nativeReady];
to:
    [self.webView stringByEvaluatingJavaScriptFromString:nativeReady];
within:
    CDVViewController.m
    - (void)webViewDidFinishLoad:(UIWebView*)theWebView


iOS Change:
https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=fc45dde676274228867949d11359165b5ab22017

Mobile-Spec:
https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=commit;h=794d58346a4d72d3215ee3c32c51c70b56b7c1ef
                
> Cordova 2.2 iOS does not work with RequireJS
> --------------------------------------------
>
>                 Key: CB-1978
>                 URL: https://issues.apache.org/jira/browse/CB-1978
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0, 2.2.0
>         Environment: Use RequireJS to loading cordova.js
> http://requirejs.org/
>            Reporter: Kenichi Yonekawa
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: Master
>
>         Attachments: www.tar.gz
>
>
> Cordova does not fire `deviceready` when using RequireJS to loading cordova.js
> Because, cordova-ios accesses `window.cordova` object at `webViewDidFinishLoad`
> However, window.cordova is undefined. It occurs JavaScript error.
> I create monkey patch for my project.
> it works for me.
> https://gist.github.com/4159669
> So, cordova-2.1.0 has same problem.
> My monkey patch is here.
> https://gist.github.com/3824310

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira