Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of brian.leroux@gmail.com
 designates 209.85.220.180 as permitted sender)
MIME-Version: 1.0
Sender: brian.leroux@gmail.com
In-Reply-To: <CD22FDAC.1615C%fil@adobe.com>
References: 
 <CAOBL_k7eGQfG0RMeSLO=NVoWPj6Azi7AK_Mcy1CO58q4go-J4Q@mail.gmail.com>
	<CD22FDAC.1615C%fil@adobe.com>
Date: Mon, 21 Jan 2013 19:44:42 -0600
Message-ID: 
 <CADVgkyOmK_LnO1JFwxRcxO8zMnJWOSMK==VmMf6cr81b1kAxqQ@mail.gmail.com>
Subject: Re: CordovaJS is broken on Android 2.x, rollback and re-tag?
From: Brian LeRoux <b@brian.io>
To: dev@cordova.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

man, sure is nice having continuous integration. which is to say: thank you=
 fil

On Mon, Jan 21, 2013 at 4:14 PM, Filip Maj <fil@adobe.com> wrote:
> BTW: the last commit on Android bumped the latest results on the ci
> dashboard from ~84% to 97%. Thank you everyone for resolving this promptl=
y!
>
> On 1/21/13 1:48 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
>
>>Cool.  I re-tagged the JS and Android to include the fix for Android
>>2.3.0, since it's early enough.
>>
>>On Mon, Jan 21, 2013 at 1:19 PM, Andrew Grieve <agrieve@chromium.org>
>>wrote:
>>> Yikes, I somehow missed that we're trying to do a 2.4 release. I see no=
w
>>> that there were bugs created for it, but was there any kind of "hey,
>>>let's
>>> do a release"-type email? I thought we'd at least figure out this
>>>master vs
>>> dev/Next/Stable branch thing before we cut a 2.4.
>>>
>>> I think the JS fix should be pretty trivial & easier than rolling back
>>> since I think we'd need to roll back the related changes on the android
>>> code-base as well.
>>>
>>>
>>> On Mon, Jan 21, 2013 at 3:15 PM, Filip Maj <fil@adobe.com> wrote:
>>>
>>>> According to the CI this isn't working properly on Android 4.x either.
>>>>
>>>> I think part of this is the array check in the android exec:
>>>>
>>>>
>>>>https://git-wip-us.apache.org/repos/asf?p=3Dcordova-android.git;a=3Dblo=
b;f=3Df
>>>>ram
>>>>
>>>>ework/assets/js/cordova.android.js;h=3D8d8b80889c140210012ac57a3fbc8c63=
2e1
>>>>51d<https://git-wip-us.apache.org/repos/asf?p=3Dcordova-android.git;a=
=3Dblob
>>>>;f=3Dframework/assets/js/cordova.android.js;h=3D8d8b80889c140210012ac57=
a3fbc
>>>>8c632e151d>
>>>> cb;hb=3Ddbfe12a9933632700fc5e220777bc617c2356670#l1055
>>>>
>>>>
>>>> If args[i] is null or undefined, then it will error out. That=B9s why
>>>>some
>>>> of the APIs which are unrelated to the array buffer work are failing.
>>>>See
>>>> ci.cordova.io for details.
>>>>
>>>> Another issue is
>>>>
>>>>https://git-wip-us.apache.org/repos/asf?p=3Dcordova-android.git;a=3Dblo=
b;f=3Df
>>>>ram
>>>>
>>>>ework/assets/js/cordova.android.js;h=3D8d8b80889c140210012ac57a3fbc8c63=
2e1
>>>>51d<https://git-wip-us.apache.org/repos/asf?p=3Dcordova-android.git;a=
=3Dblob
>>>>;f=3Dframework/assets/js/cordova.android.js;h=3D8d8b80889c140210012ac57=
a3fbc
>>>>8c632e151d>
>>>> cb;hb=3Ddbfe12a9933632700fc5e220777bc617c2356670#l1056
>>>>
>>>> `window.btoa` is probably not available/undefined on the older
>>>>androids.
>>>>
>>>> My vote would be to rollback the array buffer work, and land it in
>>>> cordova-js + the underlying platforms only once we have full support
>>>>for
>>>> android, iOS, blackberry and windows phone.
>>>>
>>>> On 1/21/13 11:56 AM, "Joe Bowser" <bowserj@gmail.com> wrote:
>>>>
>>>> >Hey
>>>> >
>>>> >We're going through the motions for release, and it seems that the we
>>>> >may have to roll back the recent changes to the JS so that we can tag
>>>> >for a release.  It seems that there were issues with the ArrayBuffer
>>>> >changes on Android (and likely others) and the most recent work is
>>>> >displaying alert errors when I start it up in Mobile-Spec.
>>>> >
>>>> >Should we rollback and re-tag the JS (and Android)? Or should we have
>>>> >an RC2 ASAP, because this candidate clearly has failed.
>>>> >
>>>> >Joe
>>>>
>>>>
>