cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Maj (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CB-2204) ./bin/create script should exit out with non-zero code if fails
Date Fri, 11 Jan 2013 00:38:12 GMT
Filip Maj created CB-2204:
-----------------------------

             Summary: ./bin/create script should exit out with non-zero code if fails
                 Key: CB-2204
                 URL: https://issues.apache.org/jira/browse/CB-2204
             Project: Apache Cordova
          Issue Type: Bug
          Components: Android
    Affects Versions: 2.3.0
            Reporter: Filip Maj
            Assignee: Joe Bowser
             Fix For: 2.4.0


I noticed this problem when setting up medic with android.

In this commit: 25aef94 (https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=25aef945d14eae7167ece73c11e32d8471114bee),
the jar fails to compile, and as such the create script fails.

However, it exits with code 0. I believe this line is the culprit:

https://github.com/apache/cordova-android/blob/master/bin/create#L72

I suggest patching it so it just exits with a code of 1, instead of trying to be fancy. Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message