cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-2168) HTML Escaping on iOS FileReader may be unnecessary
Date Fri, 11 Jan 2013 17:24:13 GMT

     [ https://issues.apache.org/jira/browse/CB-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Grieve resolved CB-2168.
-------------------------------

    Resolution: Fixed

Removed the specialization and all tests still pass.

iOS Change:
https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=20b20b8d48bcd39ebe509cd302a43b1781d5431c

JS Change:
https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commit;h=f9bcabb68f3139458192f34a71ed3c6ae8a25123
                
> HTML Escaping on iOS FileReader may be unnecessary
> --------------------------------------------------
>
>                 Key: CB-2168
>                 URL: https://issues.apache.org/jira/browse/CB-2168
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>    Affects Versions: 2.3.0
>            Reporter: Braden Shepherdson
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.4.0
>
>
> The iOS FileReader's readAsText handler encodes the result with HTML percent escapes,
and the iOS-specific Javascript code decodes it. This platform-specific Javascript code doesn't
support slicing.
> Either the encoding is there for a reason and I'll implement slicing for the iOS JS code,
or we can remove the encoding and the unnecessary separate implementation. We need to know
why that encoding was added in the first place.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message