cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse MacFadyen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-1662) jake build script puts Windows carriage return in Version String on Windows
Date Thu, 17 Jan 2013 23:58:12 GMT

     [ https://issues.apache.org/jira/browse/CB-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jesse MacFadyen resolved CB-1662.
---------------------------------

    Resolution: Fixed

This has been addressed, assuming the default git settings for windows.  
ie.
$ git config --global core.autocrlf true 

This was addressed with this addition to the jake file :
var version = fs.readFileSync("VERSION", "utf-8").toString().split(/\r?\n/).join('');

In general everyone should be using the windows friendly line ending regex /\r?\n/ when dealing
with text in files.
                
> jake build script puts Windows carriage return in Version String on Windows
> ---------------------------------------------------------------------------
>
>                 Key: CB-1662
>                 URL: https://issues.apache.org/jira/browse/CB-1662
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 2.1.0, 2.2.0, 2.3.0
>            Reporter: Joe Bowser
>            Assignee: Jesse MacFadyen
>             Fix For: 2.4.0
>
>
> Jesse found this bug where if you run the Jake script, you find that it modifies the
version in the device.js files on Bada, Tizen and Webworks.  The problem is that it also puts
a Windows Carriage Return into the field.  This is present if you look at this file on a Mac:
> this.cordova = "2.1.0^M";^M
> This basically makes it more difficult to work on Cordova on Windows, which would affect
various platforms (Bada, Webworks, Android, WP7, etc).  This needs to be fixed so we can have
a better dev workflow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message