cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yaniv De Ridder <yderi...@adobe.com>
Subject Re: Intro + First contribution
Date Wed, 23 Jan 2013 07:51:44 GMT
Thanks guys for welcoming me! ;)

My ICLA has been filed by now as well so I'm ready to do some pull
requests !

Cheers
/yaniv

On 23/01/13 00:53, "Michael Brooks" <michael@michaelbrooks.ca> wrote:

>Welcome Yaniv!
>
>Another opportunity for contribution is to review and revise our
>ContributorWorkflow [1] article. It's often hard for us to review our
>getting started documentation, because it's easy to forget the steps
>involved. Having new contributors edit these articles and fill in the
>missing gaps is extremely helpful.
>
>[1] http://wiki.apache.org/cordova/ContributorWorkflow
>
>Michael
>
>On Mon, Jan 21, 2013 at 7:34 AM, Andrew Grieve <agrieve@chromium.org>
>wrote:
>
>> Hi Yaniv!
>>
>> Very excited to see new contributors! I think what you propose sounds
>> great.
>>
>> If you haven't seen it yet, be sure to give this wiki page a read
>>through:
>> http://wiki.apache.org/cordova/ContributorWorkflow
>>
>> You'll need to sign an ICLA before committing any code.
>>
>> Had a look at your commits, and they seem good to me :). You're right in
>> that the first step is to create JIRA issues for them, and mark the as
>>"fix
>> for 2.4" so that we can use them for release notes and tracking
>>purposes.
>>
>> Andrew
>>
>>
>>
>>
>>
>>
>> On Mon, Jan 21, 2013 at 4:41 AM, Yaniv De Ridder <yderidde@adobe.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I would like to contribute to Cordova, more precisely to the iOS side
>>of
>> > it but first of all let me present myself.
>> >
>> > I'm a computer scientist at Adobe in the Experience Design team mainly
>> > working on seed-products and researches. For more information you can
>> look
>> > at my linkedIn profile: http://www.linkedin.com/in/yderidder.
>> >
>> > Recently for one of our project, we extensively used Cordova to
>>produce
>> an
>> > iOS app using web technologies and we ended up writing a bunch of
>>native
>> > plugins which I think would be valuable contributions.
>> >
>> > I already started to factor out some of the enhancements we did into a
>> > fork of the cordova-ios github repo which you can find here:
>> > https://github.com/yderidde/cordova-ios/
>> >
>> > My first contribution is related to the splash screen in iOS:
>> >
>> > -  Splash-Screen Fade IN/OUT feature
>> > The first commit is about adding the ability to fade in and out the
>> splash
>> > screen. It uses 2 new properties in the xml config file:
>> > 'FadeSplashScreen' a boolean to enable or disable the fading.
>> > 'FadeSplashScreenDuration' a float, which is the duration of the fade
>>in
>> > seconds.
>> >
>> >
>> 
>>https://github.com/yderidde/cordova-ios/commit/42ab472a29efd5f3568d832523
>>57dbfabc0c3575
>> >
>> > - Cordova splash-screen enhancement with smooth iOS-like rotation on
>> > re-orientation
>> > The second commit is about nice and smooth rotation transition while
>>the
>> > splash is still visible and reorienting the device. Before it was
>> abruptly
>> > switching the image when the orientation changed which was not very
>> > iOS-like. I basically re-wrote the entire routine which to me looks
>> simpler
>> > and 'just works'. This said, the previous routine seemed complex to me
>> and
>> > I couldn't really understand why. So I hope that I didn't introduce a
>> > regression here.
>> >
>> >
>> 
>>https://github.com/yderidde/cordova-ios/commit/8e0069d2fb689d11eed7d1e3b6
>>b62a0a2b9c6b30
>> >
>> > While I'm at it, I can also probably look at these 2 issues related to
>> the
>> > splash screen in iOS:
>> > https://issues.apache.org/jira/browse/CB-2220
>> > https://issues.apache.org/jira/browse/CB-1505
>> >
>> > ---
>> > I believe at this point, the next step would be to open an issue for
>>each
>> > on Jira ? and start getting some feedback from you guys before I do a
>> pull
>> > request.
>> >
>> >
>> > Cheers,
>> > /yaniv
>> >
>>


Mime
View raw message