cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: CordovaJS is broken on Android 2.x, rollback and re-tag?
Date Mon, 21 Jan 2013 21:48:35 GMT
Cool.  I re-tagged the JS and Android to include the fix for Android
2.3.0, since it's early enough.

On Mon, Jan 21, 2013 at 1:19 PM, Andrew Grieve <agrieve@chromium.org> wrote:
> Yikes, I somehow missed that we're trying to do a 2.4 release. I see now
> that there were bugs created for it, but was there any kind of "hey, let's
> do a release"-type email? I thought we'd at least figure out this master vs
> dev/Next/Stable branch thing before we cut a 2.4.
>
> I think the JS fix should be pretty trivial & easier than rolling back
> since I think we'd need to roll back the related changes on the android
> code-base as well.
>
>
> On Mon, Jan 21, 2013 at 3:15 PM, Filip Maj <fil@adobe.com> wrote:
>
>> According to the CI this isn't working properly on Android 4.x either.
>>
>> I think part of this is the array check in the android exec:
>>
>> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=fram
>> ework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e151d<https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=framework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e151d>
>> cb;hb=dbfe12a9933632700fc5e220777bc617c2356670#l1055
>>
>>
>> If args[i] is null or undefined, then it will error out. That¹s why some
>> of the APIs which are unrelated to the array buffer work are failing. See
>> ci.cordova.io for details.
>>
>> Another issue is
>> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=fram
>> ework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e151d<https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=framework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e151d>
>> cb;hb=dbfe12a9933632700fc5e220777bc617c2356670#l1056
>>
>> `window.btoa` is probably not available/undefined on the older androids.
>>
>> My vote would be to rollback the array buffer work, and land it in
>> cordova-js + the underlying platforms only once we have full support for
>> android, iOS, blackberry and windows phone.
>>
>> On 1/21/13 11:56 AM, "Joe Bowser" <bowserj@gmail.com> wrote:
>>
>> >Hey
>> >
>> >We're going through the motions for release, and it seems that the we
>> >may have to roll back the recent changes to the JS so that we can tag
>> >for a release.  It seems that there were issues with the ArrayBuffer
>> >changes on Android (and likely others) and the most recent work is
>> >displaying alert errors when I start it up in Mobile-Spec.
>> >
>> >Should we rollback and re-tag the JS (and Android)? Or should we have
>> >an RC2 ASAP, because this candidate clearly has failed.
>> >
>> >Joe
>>
>>

Mime
View raw message