cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: Can we talk about large features before they arrive in master?
Date Mon, 21 Jan 2013 18:50:08 GMT
Agree, but this should be just the regular flow rather than a formal
check in. Anything big should be in a branch and ideally ppl should
socialize branches on the list before the merge.

On Mon, Jan 21, 2013 at 12:41 PM, Joe Bowser <bowserj@gmail.com> wrote:
> Recently we've been noticing that there's been a lot of new features
> going into Cordova this release, especially in Android.  Now, I know
> that I've been guilty of this in the past, which is partly why I'm
> saying this now.
>
> I think that we need to talk about features and make sure they work
> before we push them into the master repository. We can't add new
> methods that break how Cordova works for our older users without
> having a really good reason for it.  We have time to actually review
> things before they arrive in the master branch, and it's trickier for
> us to pull a feature out of master once it's in there, especially when
> people commit to the branch after.  That's why I think we should have
> a review process in place.
>
> What are people's thoughts on this?
>
> Joe

Mime
View raw message