cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian M Dube <>
Subject Re: Can we talk about large features before they arrive in master?
Date Tue, 22 Jan 2013 01:43:20 GMT
On 01/21/2013 01:24 PM, Joe Bowser wrote:
> On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve <> wrote:
>> As for code reviews:
>> I'd certainly be interested in more code-reviews. I think it's really
>> useful to get feedback on changes. The only time when it becomes a burden
>> is when turn-around time gets too long (e.g. you submit for review and no
>> one looks at it for over a day).
>> Up until now, we've been using the github pull-request interface to have
>> others review our changes, but this isn't done very frequently. I also
>> don't love this approach because comments through it don't get posted back
>> to the cordova mailing-list.
> I'm not super thrilled by this either, because our GitHub pull request
> system is completely broken since we can't actually close requests and
> indicate when we think things are a good idea or not. I think we
> should do what Android does with Gerrit (see
> , but that'll involve
> additional infrastructure and another war with INFRA about whether
> it's the Apache way or whatever.

An instance of ReviewBoard [1] exists at Apache [2], so I don't think it
means war about the Apache way. Is that something that could fill this need?



View raw message