Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70BA1E4D3 for ; Mon, 3 Dec 2012 19:09:37 +0000 (UTC) Received: (qmail 56540 invoked by uid 500); 3 Dec 2012 19:09:37 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 56489 invoked by uid 500); 3 Dec 2012 19:09:37 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 56481 invoked by uid 99); 3 Dec 2012 19:09:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 19:09:37 +0000 X-ASF-Spam-Status: No, hits=1.7 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of timkim85@gmail.com designates 209.85.216.54 as permitted sender) Received: from [209.85.216.54] (HELO mail-qa0-f54.google.com) (209.85.216.54) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 19:09:30 +0000 Received: by mail-qa0-f54.google.com with SMTP id j15so31439qaq.6 for ; Mon, 03 Dec 2012 11:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=nJXe4CzM4/fdzrATuB/+38OD/7b2WTfwqU6n9j1sm8M=; b=ENBFK2rBDaJKC0FT2k9x9ngXILlXHN+Crn/pN21reV0Qo+3q9EYF2D86XhP98fE1vf O79lHIR9pMFeCr+Wtcq3WRA81TKMMD8vXfP6HDvTz4ObuAduhL8M/7/P3HLNJwGiEU4P UBKvnaMTyLU37y0203tXP6bgfVE7OgDFVYkeU3b3h4qIvjB0SYJbW9BgyyBSGyeBmCEC 0pP48B1THq7DgwPfpXWe7JPX05vJkQIRs48emsEy4S1skTQKPSXJxpwnby8DZijOfZFK ZHZHFOZ6HiKwxtUxPyOlpQqPKDaw8iD4kBUwS0CeQfhUBqKjwj52GpNuykfepcWC9RL1 4SJg== MIME-Version: 1.0 Received: by 10.224.187.198 with SMTP id cx6mr18851639qab.56.1354561749366; Mon, 03 Dec 2012 11:09:09 -0800 (PST) Received: by 10.49.129.166 with HTTP; Mon, 3 Dec 2012 11:09:09 -0800 (PST) In-Reply-To: <957F1ECDA90E004B8DBDE23CFC94E3A33A5B41E0@XMB103ECNC.rim.net> References: <957F1ECDA90E004B8DBDE23CFC94E3A33A5B3B46@XMB103ECNC.rim.net> <957F1ECDA90E004B8DBDE23CFC94E3A33A5B41E0@XMB103ECNC.rim.net> Date: Mon, 3 Dec 2012 11:09:09 -0800 Message-ID: Subject: Re: WARNING: Updated BlackBerry 10 SDK From: Tim Kim To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=485b397dd491e5b7e104cff77b97 X-Virus-Checked: Checked by ClamAV on apache.org --485b397dd491e5b7e104cff77b97 Content-Type: text/plain; charset=ISO-8859-1 Oh sorry, I thought you were talking about something else. My mistake! On 3 December 2012 10:42, Josh Soref wrote: > Tim Kim wrote: > > Is it? > > I keep seeing questions being popped up about people looking for > webworks.js > > even if they developing for bb5-7/playbook. > > Usually they are trying it in ripple and errors out when it can't find > it so it leads to some confusion. > > I wrote: > | > > Here the comment says "js/webworks.js" > > | - > > Here the code used to say "js/webworks.js", at which point the code and > comment agreed. > > | + > > This change caused the comment to no longer be in sync with the code, as > it now says "local:///chrome/webworks.js". Anyone looking for > "js/webworks.js" in the code won't find it. > > This is roughly a reminder to people "please don't forget to update > comments when you change nearby lines of code", this applies both to > comments which are visible in diff -U3 and in comments which aren't visible > in diff -U3, although from my perspective it should have been spotted by a > reviewer since it was visible in this case.... > > --------------------------------------------------------------------- > This transmission (including any attachments) may contain confidential > information, privileged material (including material protected by the > solicitor-client or other applicable privileges), or constitute non-public > information. Any use of this information by anyone other than the intended > recipient is prohibited. If you have received this transmission in error, > please immediately reply to the sender and delete this information from > your system. Use, dissemination, distribution, or reproduction of this > transmission by unintended recipients is not authorized and may be unlawful. > -- Timothy Kim --485b397dd491e5b7e104cff77b97--