cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ambarish Chaudhari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2071) InAppBrowser: follow EnableViewportScale setting from config
Date Sun, 16 Dec 2012 21:02:12 GMT

    [ https://issues.apache.org/jira/browse/CB-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533515#comment-13533515
] 

Ambarish Chaudhari commented on CB-2071:
----------------------------------------

Just noticed that "scalesPageToFit" property is set first to YES and later to NO in the same
block of code.

https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/CDVInAppBrowser.m#L215

https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/CDVInAppBrowser.m#L224

Possibly unintended?

Hope this helps.

Thanks,

-ambarish
                
> InAppBrowser: follow EnableViewportScale setting from config
> ------------------------------------------------------------
>
>                 Key: CB-2071
>                 URL: https://issues.apache.org/jira/browse/CB-2071
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.3.0
>            Reporter: Ambarish Chaudhari
>            Assignee: Shazron Abdullah
>
> InAppBrowser instance must follow EnableViewportScale setting from config (and allow
it to be manipulated using the meta viewport setting from HTML), just like the main Cordova
WebView.
> In fact, it would be great if it can also be controlled using an options parameter in
window.open call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message