cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anis KADRI <anis.ka...@gmail.com>
Subject Re: 3rd party Plugin code structure
Date Sat, 22 Dec 2012 12:54:55 GMT
Could you elaborate a little bit on the differences ?


On Thu, Dec 20, 2012 at 12:18 PM, Michal Mocny <mmocny@chromium.org> wrote:

> So the docs in https://github.com/imhotep/plugman differ slightly from
> https://github.com/alunny/cordova-plugin-spec
>
> And the Readme in phonegap-plugin doesn't do a good job of pointing the
> right place to look (other than indirectly through Shaz's post).
>
> Shall I add a line to the readme pointing to
> https://github.com/alunny/cordova-plugin-spec ?
>
> -Michal
>
>
> On Thu, Dec 20, 2012 at 3:00 PM, Don Coleman <don.coleman@gmail.com>
> wrote:
>
> > +1 for using Andrew's cordova-plugin-spec
> >
> >
> > On Thu, Dec 20, 2012 at 2:52 PM, Brian LeRoux <b@brian.io> wrote:
> >
> > > This is pretty close to Lunny's pluginstall spec:
> > >
> > > https://github.com/alunny/cordova-plugin-spec
> > >
> > > For which the tools are being built. View the current
> > > phonegap/phonegap-plugins repo as a stepping stone. It bought us time
> > > to sorted out our own backyard before inviting everyone in to play. =)
> > >
> > >
> > > On Thu, Dec 20, 2012 at 11:03 AM, Michal Mocny <mmocny@google.com>
> > wrote:
> > > > Seems that our thirdparty plugins are platform-centric; with
> javascript
> > > not
> > > > written to be shared across platforms.
> > > >
> > > > Even if individual contributors are not willing to write
> > implementations
> > > > for other platforms, or if a plugin only really applies to a single
> > > > platform, I think we should still provide good plugin structure
> > > conventions
> > > > that could scale to multiple platform implementations in the future.
> > > >
> > > > As far as I'm aware, this was the case with core plugins at some
> point,
> > > and
> > > > we made a big change to unify the js, right?
> > > >
> > > > Well, I think that plugin structure should be more like:
> > > >
> > > > plugin_name/
> > > > - common/ [js code]
> > > > - platform/
> > > >  - ios/ [native code]
> > > >  - android/ [native code]
> > > >  - etc..
> > > >
> > > > and less like we have now
> > > >
> > > > ios/plugin_name/
> > > >  - [js code]
> > > >  - [native code]
> > > >
> > > > android/plugin_name/
> > > >  - [js code -- different api]
> > > >  - [native code]
> > > >
> > > > I don't think we need to redo whats there now, but it would be nice
> to
> > > > decide on a structure, put up a skeleton for starting with, and
> mention
> > > it
> > > > in the Readme.
> > > >
> > > > (I ask before I'm going to be adding an android version of
> > > WebNotifications
> > > > some day, and I really don't want to fork the JS)
> > > >
> > > > -Michal
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message