Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7C08D307 for ; Tue, 6 Nov 2012 00:27:12 +0000 (UTC) Received: (qmail 2640 invoked by uid 500); 6 Nov 2012 00:27:12 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 2606 invoked by uid 500); 6 Nov 2012 00:27:12 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 2596 invoked by uid 99); 6 Nov 2012 00:27:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2012 00:27:12 +0000 X-ASF-Spam-Status: No, hits=2.5 required=5.0 tests=FREEMAIL_REPLY,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of anis.kadri@gmail.com designates 209.85.161.175 as permitted sender) Received: from [209.85.161.175] (HELO mail-gg0-f175.google.com) (209.85.161.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2012 00:27:06 +0000 Received: by mail-gg0-f175.google.com with SMTP id p1so1148428ggn.6 for ; Mon, 05 Nov 2012 16:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=o8bboEzgen/gxss0j2sa1xLMFoMPhzKY23LMcPft43c=; b=Zhs2tygsTLVAnekP+8diZSDIs67v1LMPdSDqf+M7Ex0APZcIyyo5cIwDH42nwmVVT1 13vrbNhdnrDxN/CCGke5XHzgNb6oMklQ2i5vwn/vGKF9vPp/bO8rEmSVWH8QjDWc/Q8u /55SnxzVk2hk7On+itzdNe6t3L0Akl9jxs3Goyf+2kd7YLpJD3lw4qCtytMkUgAps0Op mM/ZqKz58AvYHcmSVHBb4goBjSaUpLBaIiPvY48D2NrLdVD1wt1/VsLILukj6qEVcvme ADGXysoNkI4yviAF0UKE5bS+34sA+pgfpwh7Rm2/8AZmXfgiGEdwB9uUmrphx2wiWYET mLog== MIME-Version: 1.0 Received: by 10.236.143.4 with SMTP id k4mr10866661yhj.111.1352161605849; Mon, 05 Nov 2012 16:26:45 -0800 (PST) Received: by 10.236.148.41 with HTTP; Mon, 5 Nov 2012 16:26:45 -0800 (PST) In-Reply-To: References: <20121102023230.7774340.57294.351@rim.com> Date: Mon, 5 Nov 2012 16:26:45 -0800 Message-ID: Subject: Re: Whitelist defaults From: Anis KADRI To: dev@cordova.apache.org Content-Type: multipart/alternative; boundary=20cf303a2fc932135604cdc8a8af X-Virus-Checked: Checked by ClamAV on apache.org --20cf303a2fc932135604cdc8a8af Content-Type: text/plain; charset=ISO-8859-1 I confirm that Android also uses config.xml. On Mon, Nov 5, 2012 at 4:22 PM, Shazron wrote: > I would think all unsupported devices for the whitelist feature remain > unsupported (and is documented as such: > > http://docs.phonegap.com/en/2.2.0/guide_whitelist_index.md.html#Domain%20Whitelist%20Guide > ) > > > On Mon, Nov 5, 2012 at 4:14 PM, Jesse wrote: > > > Does this mean that whitelists should be added to Bada, Symbian, > > WebOS, Windows Phone, and Windows 8? > > > > Also, while we are discussing it, wouldn't it be good to have all > > platforms have a consistent way of defining access-permissions ? > > > > Android:: res/xml/cordova.xml > > Blackberry:: www/config.xml > > iOS:: Cordova.plist > > Tizen:: config.xml > > > > > > > > > > > > On Mon, Nov 5, 2012 at 3:58 PM, Shazron wrote: > > > What Anis said last is what I meant. Since BB and Android have this > > > behaviour already this doesn't impact those platforms as much. Will > wait > > > for comments until tomorrow then I will add some JIRA task(s). > > > > > > > > > On Mon, Nov 5, 2012 at 3:43 PM, Anis KADRI > wrote: > > > > > >> On Mon, Nov 5, 2012 at 3:36 PM, Brian LeRoux wrote: > > >> > > >> > Why would we require a new property? We're just talking about adding > > * as > > >> > the default property. > > >> > > > >> > > >> I believe this applied only if we did a debug/release mode strategy. > > Adding > > >> (*) as default doesn't require a new property from what I understand. > > >> > > >> > > >> > > > >> > (Also, Jesse, I have talked to many Cordova devs whom have expressed > > >> > frustration with our default.) > > >> > > > >> > I feel we have consensus enough to document and add this default. > > >> > > > >> > > > >> > On Mon, Nov 5, 2012 at 3:26 PM, Shazron wrote: > > >> > > > >> > > Well it's all or nothing. There is no "dev" mode with respect to > the > > >> > plist > > >> > > itself as it is right now, unless we want to add yet another plist > > >> > > property. > > >> > > > > >> > > > > >> > > On Mon, Nov 5, 2012 at 3:22 PM, Anis KADRI > > >> wrote: > > >> > > > > >> > > > I guess the consensus is to whitelist everything (*) all the > time. > > >> > > > > > >> > > > My opinion is that there should be some dev mode where (*) is > set > > and > > >> > > then > > >> > > > a release mode where you'd specify your hosts. > > >> > > > > > >> > > > > > >> > > > On Mon, Nov 5, 2012 at 3:11 PM, Shazron > > wrote: > > >> > > > > > >> > > > > We've had the discussion. So what is the decision/consensus? > > Leave > > >> as > > >> > > is, > > >> > > > > or add "*" to default settings for all, with a warning in the > > >> console > > >> > > > log? > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > On Fri, Nov 2, 2012 at 11:33 AM, Joe Bowser < > bowserj@gmail.com> > > >> > wrote: > > >> > > > > > > >> > > > > > On Fri, Nov 2, 2012 at 10:59 AM, Shazron > > > >> > wrote: > > >> > > > > > > Echoing Anis here. The easiest use case is for corporate > use > > >> > > > > (internal), > > >> > > > > > > where any connections are restricted to a certain domain > for > > >> > > paranoid > > >> > > > > IT > > >> > > > > > > types. > > >> > > > > > > > > >> > > > > > > I can see the case of us allowing everything _by default_ > > >> though > > >> > > (eg > > >> > > > > > adding > > >> > > > > > > the '*'), which really should have been the default so as > > to be > > >> > > > > > "backwards > > >> > > > > > > compatible" with how it was before the whitelist came in. > > The > > >> > > system > > >> > > > > > could > > >> > > > > > > detect this sole wildcard entry, and print out a warning > in > > the > > >> > > > console > > >> > > > > > > log, as well as the documentation of course pointing this > > out > > >> -- > > >> > > the > > >> > > > > > latter > > >> > > > > > > which we should have done in the first place. > > >> > > > > > > > >> > > > > > OK, that sounds cool, but does that mean that in six months, > > >> we're > > >> > > > > > going to deprecate this behaviour and get more aggressive > with > > >> the > > >> > > > > > whitelist? > > >> > > > > > > > >> > > > > > BTW: In the event that the whitelist isn't found based on > the > > >> code > > >> > > > > > that I'm looking at here, Android should block everything > and > > >> fire > > >> > > > > > default web intents. If it's not doing this, that's a bug! > > When > > >> we > > >> > > > > > refer to defaults, are we referring to the config.xml that > > we're > > >> > > > > > circulating? > > >> > > > > > > > >> > > > > > Also, how are we testing this whitelisting feature? I can > tell > > >> you > > >> > > > > > that doing it in JS alone wouldn't be enough. > > >> > > > > > > > >> > > > > > Joe > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > > > > > > -- > > @purplecabbage > > risingj.com > > > --20cf303a2fc932135604cdc8a8af--