Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DCA41DE0F for ; Fri, 2 Nov 2012 22:44:27 +0000 (UTC) Received: (qmail 13549 invoked by uid 500); 2 Nov 2012 22:44:27 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 13525 invoked by uid 500); 2 Nov 2012 22:44:27 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 13516 invoked by uid 99); 2 Nov 2012 22:44:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2012 22:44:27 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of shazron@gmail.com designates 209.85.212.47 as permitted sender) Received: from [209.85.212.47] (HELO mail-vb0-f47.google.com) (209.85.212.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2012 22:44:23 +0000 Received: by mail-vb0-f47.google.com with SMTP id ez10so4334449vbb.6 for ; Fri, 02 Nov 2012 15:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=7VlD1wXZyrAyoI23PSGZNVdW2hq1PZ95KdOQ1qn4+Y4=; b=Ju6eon5loGWOAxqr2shfToTHlQZ8C1ympJ+xMw/w5EHi3SB9oAjiMo7UkDrpfga65z f1vlEilqxV2WBWHt5vlQnZEkbFh+5ic3QzhQuQ2+W9Cqfh32TDJ0gw+K33skVuAwsYkQ TR1N9x0jXBhCztYDhWpKZHfGykYvaJ6FE1PPay/3soCRgqqPjgHb8L/KEI4Rz5aGUca+ ECi+m8NormKfBy6htJK3OJ1T2C4HMh+61mu087bIXYMv2MGRrC4lrM3OCvyTK1ZnqIGW r065o5rg1J73++iFW74niAMfMPSTLWUHvqBZdjIExW9oBgjFt0iI5p8zlh5etB/baZEU HxyQ== Received: by 10.221.1.81 with SMTP id np17mr3119866vcb.66.1351896242389; Fri, 02 Nov 2012 15:44:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.106.114 with HTTP; Fri, 2 Nov 2012 15:43:22 -0700 (PDT) In-Reply-To: References: From: Shazron Date: Fri, 2 Nov 2012 15:43:22 -0700 Message-ID: Subject: Re: REMOVE ME To: "dev@cordova.apache.org" , antony.sastre@gmail.com Content-Type: multipart/alternative; boundary=bcaec54ee6ac4d014e04cd8adfcf X-Virus-Checked: Checked by ClamAV on apache.org --bcaec54ee6ac4d014e04cd8adfcf Content-Type: text/plain; charset=ISO-8859-1 Anthony, send an email to callback-dev-unsubscribe@incubator.apache.org to unsubscribe. For others, the other mailing list addresses to manage your subscription are here: http://mail-archives.apache.org/mod_mbox/incubator-callback-dev/ On Fri, Nov 2, 2012 at 3:26 PM, Antony Sastre wrote: > On Fri, Nov 2, 2012 at 11:20 PM, Shazron wrote: > > > Ok I found out its actually in two locations, it's in the > > CordovaLibAppTests/www folder as well as the bin/template. > > > > Yeah having one location would be best -- we did have it not having the > > version before though, with copying/updates based on the Makefile. > > > > I'm thinking we only update: > > CordovaLib/cordova.ios.js with the latest from cordova-js > > > > Then for a release, run a script/Makefile target to update: > > 1. CordovaLibAppTests/www/cordova.ios.js > > 2. bin/templates/project/www with the versioned .js > > > > > > On Fri, Nov 2, 2012 at 2:49 PM, Andrew Grieve > > wrote: > > > > > It actually does bother me a little bit too, to have the file name > have a > > > version in it when we're developing. > > > > > > I don't really care where we put the file so long as there is only one > > copy > > > of it and not multiple. > > > > > > > > > On Wed, Oct 31, 2012 at 4:22 PM, Shazron wrote: > > > > > > > On iOS, the cordova.js used to (inertia really because of the legacy > > > > location) be in the CordovaLib folder, and also the template. Since > it > > > > was redundant, we only put it in the default template in > > > > bin/templates/project now. > > > > > > > > Even this is not ideal with respect to people upgrading and using it > > > > as an embedded WebView -- to grab the new .js they have to create a > > > > new project (or spelunk into the bin/templates folder). Ideally it > > > > should be put back also into CordovaLib because the .js is tightly > > > > coupled to a specific CordovaLib library and version, and for easy > > > > discovery. Don't know what the ideal situation can be here. > > > > > > > > On Tue, Oct 30, 2012 at 5:34 PM, Kevin Hawkins < > > khawkins@salesforce.com> > > > > wrote: > > > > > Hi all, > > > > > > > > > > Apologies if/that I've missed this discussion previously. I'm not > > > clear > > > > on why the cordova.js file name changes in the iOS repo, particularly > > > given > > > > the fact that great lengths seem to have been taken everywhere to be > > > > agnostic about what the originating name is, opting to dynamically > > update > > > > the destination name in build scripts, template generation, etc.? > > > > > > > > > > Changing the originating file name with each new iteration/revision > > of > > > > Cordova makes it hard to follow its history on GitHub (though it's > easy > > > > enough locally with git log and --follow), and just generally seems > > > > unnecessary. > > > > > > > > > > Thanks, > > > > > Kevin > > > > > > > > > > > > > > > --bcaec54ee6ac4d014e04cd8adfcf--