Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.219.47 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAM1AYQBa-30B1vxZBAm15-cMtL+wv-+4qgim2=cZ1FcD398Dgw@mail.gmail.com>
References: 
 <CAE6O_-bpUAXdqfBNW00et4FVqWHKTV3k3Hy-PZTo28qKo5uyUw@mail.gmail.com>
 <CABiQX1XYHpVAmbDM_OPzbFyLQNd1363S5jRWWq=ABiWt+V5q-A@mail.gmail.com>
 <CAE6O_-ZpnCTS76xB8U4LObJe+iJn-FmK9deuC_bpR7j1UpTeiw@mail.gmail.com>
 <CABiQX1U+=u+_OGnyrJRMx9OCn0iQoZmVK4NiZ0cSX0-OPP22_g@mail.gmail.com>
 <CAE6O_-b8gqWhCHj9FLMszcNoeap=GJCUsGecf8ahLVFXDCT6Gg@mail.gmail.com>
 <CAM1AYQD8iehs=Z3QUrN6PvPCnJV+jx6vwfQHHotRCAk2yzwStA@mail.gmail.com>
 <CAM1AYQBa-30B1vxZBAm15-cMtL+wv-+4qgim2=cZ1FcD398Dgw@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Thu, 22 Nov 2012 18:40:18 -0500
Message-ID: 
 <CABiQX1XYaAep2VQ7oBy_XBihyJD8F_NB_T_t2QP9L5muhP_Vjg@mail.gmail.com>
Subject: Re: InAppBrowser - events
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=e89a8fb2030288e12604cf1dfefc

--e89a8fb2030288e12604cf1dfefc
Content-Type: text/plain; charset=ISO-8859-1

The more events the better! :) Really though, it would be good if someone
knew of an app that used ChildBrowser for the purposes of OAuth. That seems
like one of the most important use-cases, so we should make sure to have
all of the events that it requires.


On Thu, Nov 22, 2012 at 4:26 PM, Simon MacDonald
<simon.macdonald@gmail.com>wrote:

> Just looking at this again and...
>
>   webview.addEventListener('exit', handleExit);
>   webview.addEventListener('loadstart', handleLoadStart);
>
> would seem to map to our:
>
> onClose
> onLocationChanged
>
> methods from the ChildBrowser. At least on Android I fire location changed
> event when the page starts to load not when it is finished.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Thu, Nov 22, 2012 at 1:53 PM, Simon MacDonald
> <simon.macdonald@gmail.com>wrote:
>
> > Is this required for the 2.3.0 release?
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> >
> > On Wed, Nov 21, 2012 at 11:30 PM, Shazron <shazron@gmail.com> wrote:
> >
> >> Great! Let's stick with one API, since we have Chrome members on the
> >> Cordova team the choice is obvious :)
> >>
> >>
> >> On Wed, Nov 21, 2012 at 8:06 PM, Andrew Grieve <agrieve@chromium.org>
> >> wrote:
> >>
> >> > Looks that way. Given how similar they are, I don't think it matters
> >> which
> >> > one we go with (or if we come up with our own event names), but it'd
> be
> >> > good to follow the same pattern of having events and an API like
> >> > canGoBack(), goForward(), etc. If they ever move to standardize, then
> we
> >> > can follow suit.
> >> >
> >> >
> >> > On Wed, Nov 21, 2012 at 7:18 PM, Shazron <shazron@gmail.com> wrote:
> >> >
> >> > > Mozilla's 'locationchange' is similar to what we have for
> >> ChildBrowser,
> >> > but
> >> > > I don't see the equivalent in the Chrome example - I suppose it is
> >> > > 'loadstop'?
> >> > >
> >> > > I suppose if we were to adopt either, it would go something like
> this:
> >> > >
> >> > > var iab = window.open('http://apache.org', '_blank');
> >> > > // Firefox
> >> > > iab.addEventListener('locationchange', handleLocationChange);
> >> > > // Chrome
> >> > > iab.addEventListener('loadstop', handleLoadStop);
> >> > >
> >> > > // Firefox
> >> > > function handleLocationChange(e) {
> >> > >      console.log('location changed to: ' + e.detail);
> >> > > }
> >> > > // Chrome
> >> > > function handleLoadStop(e) {
> >> > >      console.log('location changed to: ' + e.url);
> >> > > }
> >> > >
> >> > > On Wed, Nov 21, 2012 at 1:32 PM, Andrew Grieve <
> agrieve@chromium.org>
> >> > > wrote:
> >> > >
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> https://github.com/GoogleChrome/chrome-app-samples/blob/master/browser/browser.js
> >> > >
> >> >
> >>
> >
> >
>

--e89a8fb2030288e12604cf1dfefc--