Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates
 209.85.214.175 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAM1AYQBss00HCTfbDbU0b5RdwtR84ovSuPqrtO5ds16TTSFSNA@mail.gmail.com>
References: 
 <CAM1AYQAE=jBwEgUPMUp4zHTbFpXkKV5JRuuFuAbc91k_mei+1g@mail.gmail.com>
 <CAEeF2Tc_Fg0TNe6yMMJZRC0rrBxhaCzHAGMrrq4g2e65hcvjYg@mail.gmail.com>
 <CAM1AYQCB264YxwggKxndJdO6-mLaocAXpmL1Gak0unjQbHPahQ@mail.gmail.com>
 <CABiQX1UvGi8vfohad7EDgJStZixapcycVjTPhx2yktUTxfT32g@mail.gmail.com>
 <CAM1AYQAXZFKHgopabXCNYVCF4gAdDTFd_VhNGWtQOHyBA-T+FQ@mail.gmail.com>
 <CABiQX1VDShWdD79XrATm7t47_6_A_0K64NVusNxv6ZyM01cSzQ@mail.gmail.com>
 <CABiQX1VUzhULZCK3dv2hGo_KZiEKW4vEPgKNEy+Ky0hq3DoqRg@mail.gmail.com>
 <CAM1AYQCKvSJGioJF5yUJjn83ayV2X6gVCjzhifB7fut84gSV-A@mail.gmail.com>
 <CABiQX1VQLzh+=a3ferj47tDWVy3sMcRkUfXzGHx9mYbK8P7+9Q@mail.gmail.com>
 <CAM1AYQBCiOfsrUg3FoBFO5uJKWNGF8BNCc5Hfr70M_mKtPfFmw@mail.gmail.com>
 <CABiQX1US=qTnMAr3U3qYtLbGS+u5fyQj-Q+QfR85GzLbLkM0pA@mail.gmail.com>
 <CABiQX1XOhBKxk5XxDCyZ4vbieFD=0s7+Vj-sftNr7Fznu9TA5A@mail.gmail.com>
 <CAM1AYQBss00HCTfbDbU0b5RdwtR84ovSuPqrtO5ds16TTSFSNA@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Thu, 15 Nov 2012 17:21:18 -0500
Message-ID: 
 <CABiQX1Woe81ybQLRJezfXf3mTECVQHZpRsjtUcrDUe_EL3cugw@mail.gmail.com>
Subject: Re: Changes to the JS?
To: Simon MacDonald <simon.macdonald@gmail.com>, dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=bcaec550b6f638bea604ce90132f

--bcaec550b6f638bea604ce90132f
Content-Type: text/plain; charset=ISO-8859-1

Whoops, didn't notice that! Done!


On Thu, Nov 15, 2012 at 4:25 PM, Simon MacDonald
<simon.macdonald@gmail.com>wrote:

> Yup, all File tests are passing for me too. In FileTransfer only one of
> the abort tests fails to run. BTW this thread is only me and you. You might
> want to post to the list letting them know everything is back to normal.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Thu, Nov 15, 2012 at 4:20 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>
>> Okay, just pushed and have run spec tests before / after changes. They
>> File ones failed before and are fixed now.
>>
>> I'm seeing file transfer tests failing as well as contact ones. The
>> contact ones have always been flakey for me, but I'm not sure what's up
>> with FT. Maybe because I upgraded to 4.2? I'll have to look into it.
>>
>>
>> On Thu, Nov 15, 2012 at 3:34 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>>
>>> I didn't. I'm just about finished the rename from
>>> objects->defaults/clobbers and then will run the tests.
>>>
>>>
>>> On Thu, Nov 15, 2012 at 3:32 PM, Simon MacDonald <
>>> simon.macdonald@gmail.com> wrote:
>>>
>>>> Did you run it against mob-spec? It doesn't seem to change anything for
>>>> me. Could be me though.
>>>>
>>>> Simon Mac Donald
>>>> http://hi.im/simonmacdonald
>>>>
>>>>
>>>> On Thu, Nov 15, 2012 at 3:24 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>>>>
>>>>> Fix pushed.
>>>>>
>>>>>
>>>>> On Thu, Nov 15, 2012 at 3:23 PM, Simon MacDonald <
>>>>> simon.macdonald@gmail.com> wrote:
>>>>>
>>>>>> np
>>>>>>
>>>>>> Simon Mac Donald
>>>>>> http://hi.im/simonmacdonald
>>>>>>
>>>>>>
>>>>>> On Thu, Nov 15, 2012 at 3:22 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>>>>>>
>>>>>>> I'll fix the typo, and rename the keys. Thanks for finding this
>>>>>>> Simon.
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Nov 15, 2012 at 3:20 PM, Andrew Grieve <agrieve@chromium.org
>>>>>>> > wrote:
>>>>>>>
>>>>>>>> Oh snap. yeah, I see. Andrew broke it. Who can spot the typo?:
>>>>>>>>
>>>>>>>>                     if (platform.object) {
>>>>>>>>
>>>>>>>> builder.build(platform.objects).intoAndClobber(context);
>>>>>>>>                     }
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Nov 15, 2012 at 3:14 PM, Simon MacDonald <
>>>>>>>> simon.macdonald@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Actually, I don't think the items in module.exports.objects in
>>>>>>>>> platform.js *do* clobber. At least what I'm seeing right now with the edge
>>>>>>>>> JS code File, FileReader and FileError are not clobbered.
>>>>>>>>>
>>>>>>>>> When I run the mobile spec file tests these test cases fail but if
>>>>>>>>> I revert back to 2.2.0 JS then all tests pass.
>>>>>>>>>
>>>>>>>>> Simon Mac Donald
>>>>>>>>> http://hi.im/simonmacdonald
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Nov 15, 2012 at 2:49 PM, Andrew Grieve <
>>>>>>>>> agrieve@chromium.org> wrote:
>>>>>>>>>
>>>>>>>>>> Oh! This reminds me...
>>>>>>>>>>
>>>>>>>>>> When I was doing the navigator.connection work, I had a tough
>>>>>>>>>> time figuring
>>>>>>>>>> out how to get the builder to do the correct thing. It's a bit
>>>>>>>>>> confusing
>>>>>>>>>> because module.exports.objects in common.js don't clobber, but
>>>>>>>>>> module.exports.objects in platform.js *do* clobber.
>>>>>>>>>>
>>>>>>>>>> I wanted to propose a change:
>>>>>>>>>> for both common and platform:
>>>>>>>>>> "merges" --> intoAndMerge
>>>>>>>>>> "clobbers" --> intoAndClobber
>>>>>>>>>> "defaults" --> intoButDoNotClobber
>>>>>>>>>>
>>>>>>>>>> get rid of "objects"
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
>>>>>>>>>> <simon.macdonald@gmail.com>wrote:
>>>>>>>>>>
>>>>>>>>>> > Nope, it was a change to the JS. The objects are no longer
>>>>>>>>>> being clobbered
>>>>>>>>>> > correctly. I know who to bug now.
>>>>>>>>>> >
>>>>>>>>>> > Thanks all.
>>>>>>>>>> >
>>>>>>>>>> > Simon Mac Donald
>>>>>>>>>> > http://hi.im/simonmacdonald
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <
>>>>>>>>>> mmocny@chromium.org> wrote:
>>>>>>>>>> >
>>>>>>>>>> > > Just a wild guess:
>>>>>>>>>> > >
>>>>>>>>>> > > Way back when ios 6.0 beta came out, same thing happened due
>>>>>>>>>> to
>>>>>>>>>> > > webview adding a semi complete implementation, and we weren't
>>>>>>>>>> forcing
>>>>>>>>>> > > a clobber.
>>>>>>>>>> > > Perhaps you updated to android 4.2 and perhaps its webview
>>>>>>>>>> also added
>>>>>>>>>> > > something and also needs a forced clobber..
>>>>>>>>>> > >
>>>>>>>>>> > > -Michal
>>>>>>>>>> > >
>>>>>>>>>> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
>>>>>>>>>> > > <simon.macdonald@gmail.com> wrote:
>>>>>>>>>> > > > Hey,
>>>>>>>>>> > > >
>>>>>>>>>> > > > I'm noticing something weird today running mobile spec on
>>>>>>>>>> Android. I'm
>>>>>>>>>> > > get
>>>>>>>>>> > > > File test failures and I think it is related to the Android
>>>>>>>>>> WebView
>>>>>>>>>> > > > implementations File, FileReader and FileError objects not
>>>>>>>>>> being
>>>>>>>>>> > > clobbered
>>>>>>>>>> > > > like they should be.
>>>>>>>>>> > > >
>>>>>>>>>> > > > Were their any changes around that area of the code?
>>>>>>>>>> > > >
>>>>>>>>>> > > > Simon Mac Donald
>>>>>>>>>> > > > http://hi.im/simonmacdonald
>>>>>>>>>> > >
>>>>>>>>>> >
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

--bcaec550b6f638bea604ce90132f--