Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates
 209.85.214.175 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
From: Andrew Grieve <agrieve@chromium.org>
Date: Thu, 22 Nov 2012 22:21:14 -0500
Message-ID: 
 <CABiQX1WRw0D0mfzCPsC3Ct=eb-TP6juJOPTQmf5mf7btffidxA@mail.gmail.com>
Subject: iOS Changes to InAppBrowser
To: Shazron Abdullah <shazron@gmail.com>
Cc: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=bcaec550b6f6b2986104cf211405

--bcaec550b6f6b2986104cf211405
Content-Type: text/plain; charset=ISO-8859-1

Just pushed a few. Let me know if you have concerns about any of them.

1. I changed the User-Agent from appending a GUID to appending the VC's
memory location
I was hoping this would let me get rid of the vc header field in the
bridge all together, but it turns out that the User-Agent isn't being sent
for all requests. (Maybe because they are file:// requests?). Anyways, it
still gets rid of having two sets in the URLProtocol, and now the JS gets
the value from the UA instead of cordova.iOSVCAddr

2. Added a helper to InvokedCommand for getting arguments. There was a bug
in InAppBrowser with NSNull vs nil, which I've run into many times before,
so it pushed me over the edge! Makes a lot of sense I think though, to have
such a helper method. I'll probably update other plugins to use it instead
of checking NSNull themselves

3. I made InAppBrowser's UA the default UA instead of having a GUID
appended to it. I don't think a GUID in this case makes a difference since
we're not registering them with the URIProtocol, but if you had a use in
mind we can just roll back that commit.

Andrew

--bcaec550b6f6b2986104cf211405--