cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anis KADRI <anis.ka...@gmail.com>
Subject Re: WebNotifications plugin
Date Thu, 29 Nov 2012 07:13:17 GMT
On Wed, Nov 28, 2012 at 10:43 PM, Brian LeRoux <b@brian.io> wrote:

> would this not be an indication that we need to modify the plugin api?
> (code munging would be a bad code smell for a pluggable architecture
> imo)
>

Yes. The current specification does not support this use case.
I can't seem to find a clean/elegant solution to the problem. diff'ing does
not work well if there are multiple plugins appending code to existing
files. One option would just be to prompt the user to append the code
manually (but that would not be too cool with cordova-client).

Shaz, I believe I understand that we can expand AppDelegate to support even
more overrides (including the didReceiveLocalNotification) but I believe
the real issue here is appending code in general and this issue is not
limited to iOS. We can keep this on the backburner for now as it is not
required by most plugins.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message