cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: Changes to the JS?
Date Fri, 16 Nov 2012 08:44:20 GMT
+1


On Fri, Nov 16, 2012 at 6:49 AM, Andrew Grieve <agrieve@chromium.org> wrote:

> Oh! This reminds me...
>
> When I was doing the navigator.connection work, I had a tough time figuring
> out how to get the builder to do the correct thing. It's a bit confusing
> because module.exports.objects in common.js don't clobber, but
> module.exports.objects in platform.js *do* clobber.
>
> I wanted to propose a change:
> for both common and platform:
> "merges" --> intoAndMerge
> "clobbers" --> intoAndClobber
> "defaults" --> intoButDoNotClobber
>
> get rid of "objects"
>
>
>
>
> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
> <simon.macdonald@gmail.com>wrote:
>
> > Nope, it was a change to the JS. The objects are no longer being
> clobbered
> > correctly. I know who to bug now.
> >
> > Thanks all.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mmocny@chromium.org>
> wrote:
> >
> > > Just a wild guess:
> > >
> > > Way back when ios 6.0 beta came out, same thing happened due to
> > > webview adding a semi complete implementation, and we weren't forcing
> > > a clobber.
> > > Perhaps you updated to android 4.2 and perhaps its webview also added
> > > something and also needs a forced clobber..
> > >
> > > -Michal
> > >
> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> > > <simon.macdonald@gmail.com> wrote:
> > > > Hey,
> > > >
> > > > I'm noticing something weird today running mobile spec on Android.
> I'm
> > > get
> > > > File test failures and I think it is related to the Android WebView
> > > > implementations File, FileReader and FileError objects not being
> > > clobbered
> > > > like they should be.
> > > >
> > > > Were their any changes around that area of the code?
> > > >
> > > > Simon Mac Donald
> > > > http://hi.im/simonmacdonald
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message