cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1832) iOS: CDVCordovaView should not inherit from UIWebView
Date Fri, 09 Nov 2012 23:55:12 GMT

    [ https://issues.apache.org/jira/browse/CB-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494444#comment-13494444
] 

Andrew Grieve commented on CB-1832:
-----------------------------------

Yeah, I did the exact same thing when I started working on the code. I cringed when I saw
us extending UIWebView because the docs are quite clear, but if nothing's broken... I agree
let's just pretend like it's not there :)
                
> iOS: CDVCordovaView should not inherit from UIWebView
> -----------------------------------------------------
>
>                 Key: CB-1832
>                 URL: https://issues.apache.org/jira/browse/CB-1832
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>            Assignee: Shazron Abdullah
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CDVCordovaView inherits from UIWebView.  Apple's documentation for UIWebView states that
classes should not inherit from this class.  Most straightforward recommendation is to simply
remove CDVCordovaView, and make CDVViewController's webView property actually be a UIWebView.
 There's currently no custom logic in CDVCordovaView to support a custom view anyway.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message