Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of kingoftheoaks@hotmail.com
 designates 65.55.34.215 as permitted sender)
Message-ID: <COL002-W76D6E3595D8B01B9B9AA77A27A0@phx.gbl>
Content-Type: multipart/alternative;
	boundary="_cea2ea15-b4e6-4440-9c78-7ee516813b06_"
From: Herm Wong <kingoftheoaks@hotmail.com>
To: "callback-dev@incubator.apache.org" <callback-dev@incubator.apache.org>
Subject: RE: cordova-js webOS
Date: Mon, 22 Oct 2012 14:26:10 -0700
Importance: Normal
In-Reply-To: <CCAB0729.1018F%fil@adobe.com>
References: 
 <COL002-W69F5413E3D71693B6AB07BA27A0@phx.gbl>,<CCAB0729.1018F%fil@adobe.com>
MIME-Version: 1.0

--_cea2ea15-b4e6-4440-9c78-7ee516813b06_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Yeap. Tried that as well. It's looking like the exec call is being made but=
 the banner isn't being displayed. The palm-log isn't displaying any errors=
.
Will continue to debug the issue.

> From: fil@adobe.com
> To: callback-dev@incubator.apache.org
> Date: Mon=2C 22 Oct 2012 14:24:02 -0700
> Subject: Re: cordova-js webOS
>=20
> https://github.com/apache/incubator-cordova-js/blob/master/lib/webos/exec=
.j
> s#L43
>=20
>=20
> The notification API is defined in exec with uppercase Notification in
> webOS' case. Try "Notification" as the param into exec=2C as per the comm=
on
> notification plugin:
>=20
> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plu=
gi
> n/notification.js#L41
>=20
>=20
> On 10/22/12 1:41 PM=2C "Herm Wong" <kingoftheoaks@hotmail.com> wrote:
>=20
> >The webOS cordova-js will boot up properly and fire the deviceReady even=
t
> >with Gord's & Anis' changes merged.
> >However I'm still having troubles getting the APIs to work.
> >For example:
> >Cordova.exec(null=2C null=2C "notification"=2C "showBanner"=2C "hello wo=
rld")=3B
> >returns the following error in the palm log: [20121022-11:47:05.902046]
> >error: TypeError: Cannot call method 'showBanner' of undefined=2C
> >cordova.webos.js:951
> >It looks like the plugin mapping isn't able to find the notification
> >class since it's undefined.
> >I also tried testing the cordova.webos.js file with the webOS kitchen
> >sink sample app and wasn't able to get the app to
> >work.https://github.com/hermwong/PhoneGap-webOS-kitchen-sink-app
> >We may want to tag cordova-js 2.2.0rc2 and release it without cordova-js
> >webOS until we're able to track down & resolve this issue.
> >
> >> From: kingoftheoaks@hotmail.com
> >> To: callback-dev@incubator.apache.org
> >> Subject: RE: cordova-js webOS
> >> Date: Sat=2C 20 Oct 2012 09:07:15 -0700
> >>=20
> >> I'll test it Monday when I'm back in SF (where my webOS devices are
> >>located).
> >>=20
> >> > From: gord@tinyhippos.com
> >> > Date: Fri=2C 19 Oct 2012 22:17:41 -0400
> >> > Subject: Re: cordova-js webOS
> >> > To: callback-dev@incubator.apache.org
> >> >=20
> >> > That wouldn't have caught it=2C the main problem was code that wasn'=
t
> >> > indented to the correct level=2C check out the diff to see what I di=
d.
> >> >=20
> >> >=20
> >> > On Fri=2C Oct 19=2C 2012 at 8:28 PM=2C Anis KADRI <anis.kadri@gmail.=
com>
> >>wrote:
> >> >=20
> >> > > I=2C myself=2C just called fixwhitespace task. Isn't that supposed=
 to
> >>fix the
> >> > > indentation issues ? Jake stopped barking after I did it=2C so I
> >>assumed
> >> > > everything was alright.
> >> > >
> >> > > On Fri=2C Oct 19=2C 2012 at 4:44 PM=2C Gord Tanner <gord@tinyhippo=
s.com>
> >>wrote:
> >> > >
> >> > > > Hey=2C
> >> > > >
> >> > > > I took a look at the webos code and it had a number of
> >>indentation issues
> >> > > > and some other papercuts that I cleaned up on a personal branch.
> >> > > >
> >> > > >
> >> > > >
> >> > >=20
> >>https://github.com/gtanner/incubator-cordova-js/commit/d123863e089dc5f9=
98
> >>d68c2867d2bc17636262ab
> >> > > >
> >> > > > I don't have a webos device to test that everything still works
> >>but it
> >> > > > should since most of what I fixed was just cleaning up the code
> >> > > formatting
> >> > > > issues.
> >> > > >
> >> > > > Could someone with a webos device do a quick test of this branch
> >>to see
> >> > > if
> >> > > > it still works and we can get this merged in to master.
> >> > > >
> >> > > > Thanks=2C
> >> > > >
> >> > > > Gord
> >> > > >
> >> > > > On Fri=2C Oct 12=2C 2012 at 12:02 PM=2C Josh Soref <jsoref@rim.c=
om>
> >>wrote:
> >> > > >
> >> > > > > Markus wrote:
> >> > > > > > Fixed=2C every file has now a new line at the end
> >> > > > >
> >> > > > > As a vcs purity note=2C your fix for this had an unrelated cha=
nge
> >>in the
> >> > > > > commit:
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > >
> >> > >=20
> >>https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9=
b1
> >>163b71734f4e999bd4d6512#L1L23
> >> > > > >
> >> > > > > @@ -20=2C7 +20=2C6 @@ var plugins =3D {
> >> > > > > -    /*"File" : require('cordova/plugin/webos/filereader')=2C*=
/
> >> > > > >
> >> > > > > @@ -35=2C4 +34=2C4 @@ module.exports =3D function(success=2C f=
ail=2C
> >>service=2C
> >> > > > > action=2C args) {
> >> > > > > -}=3B
> >> > > > > \ No newline at end of file
> >> > > > > +}=3B
> >> > > > >
> >> > > > > Personally=2C I'd rewrite all the changesets:
> >> > > > > * folding in the newlines into the original commit
> >> > > > > * possibly keeping the indentation consistency thing as a
> >>distinct
> >> > > >  commit
> >> > > > > * definitely splitting the comment removal into its own commit
> >>if it is
> >> > > > > meaningful=2C or folding it into the original commit otherwise=
.
> >> > > > >
> >> > > > > -- but this is easy for me to do with mercurial and would
> >>probably
> >> > > result
> >> > > > > in me pulling more hairs with git -- and it would give me the
> >>pain of
> >> > > > > trying to figure out if I need to close/open new pull requests
> >>with
> >> > > > github
> >> > > > > whose ui inevitably trips me up.
> >> > > > >
> >> > > > >=20
> >>---------------------------------------------------------------------
> >> > > > > This transmission (including any attachments) may contain
> >>confidential
> >> > > > > information=2C privileged material (including material protect=
ed
> >>by the
> >> > > > > solicitor-client or other applicable privileges)=2C or constit=
ute
> >> > > > non-public
> >> > > > > information. Any use of this information by anyone other than
> >>the
> >> > > > intended
> >> > > > > recipient is prohibited. If you have received this transmissio=
n
> >>in
> >> > > error=2C
> >> > > > > please immediately reply to the sender and delete this
> >>information from
> >> > > > > your system. Use=2C dissemination=2C distribution=2C or reprod=
uction
> >>of this
> >> > > > > transmission by unintended recipients is not authorized and ma=
y
> >>be
> >> > > > unlawful.
> >> > > > >
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Gord Tanner
> >> > > > Senior Developer / Code Poet
> >> > > > tinyHippos Inc.
> >> > > > @tinyhippos
> >> > > >
> >> > >
> >> >=20
> >> >=20
> >> >=20
> >> > --=20
> >> > Gord Tanner
> >> > Senior Developer / Code Poet
> >> > tinyHippos Inc.
> >> > @tinyhippos
> >>  		 	   		 =20
> > 		 	   		 =20
>=20
 		 	   		  =

--_cea2ea15-b4e6-4440-9c78-7ee516813b06_--