Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A6A8DC54 for ; Wed, 31 Oct 2012 16:39:18 +0000 (UTC) Received: (qmail 33497 invoked by uid 500); 31 Oct 2012 16:39:18 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 33411 invoked by uid 500); 31 Oct 2012 16:39:16 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 33219 invoked by uid 500); 31 Oct 2012 16:39:15 -0000 Delivered-To: apmail-incubator-callback-dev@incubator.apache.org Received: (qmail 33215 invoked by uid 99); 31 Oct 2012 16:39:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Oct 2012 16:39:15 +0000 Date: Wed, 31 Oct 2012 16:39:14 +0000 (UTC) From: "Patrick Mueller (JIRA)" To: callback-dev@incubator.apache.org Message-ID: <221499138.51093.1351701555017.JavaMail.jiratomcat@arcas> In-Reply-To: <695902715.9090.1335784487713.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CB-604) doesn't work in strict mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487928#comment-13487928 ] Patrick Mueller commented on CB-604: ------------------------------------ Did a quick check to see where in weinre we're using arguments, .callee and .caller. Do a {noformat} cd [path-to-weinre-source]/weinre.web {noformat} Then run {noformat} grep -r "\(arguments\)\|\(\.callee\)\|\(\.caller\)" . | grep \.coffee {noformat} Here is a list of the affected files: * modules/weinre/client/Client.coffee * modules/weinre/client/DOMTemplates.coffee * modules/weinre/client/InspectorBackendImpl.coffee * modules/weinre/client/InspectorFrontendHostImpl.coffee * modules/weinre/common/Binding.coffee * modules/weinre/common/Callback.coffee * modules/weinre/common/EventListeners.coffee * modules/weinre/common/Ex.coffee * modules/weinre/common/HookLib.coffee * modules/weinre/common/IDLTools.coffee * modules/weinre/common/MessageDispatcher.coffee * modules/weinre/common/StackTrace.coffee * modules/weinre/common/WebSocketXhr.coffee * modules/weinre/common/Weinre.coffee * modules/weinre/target/Console.coffee * modules/weinre/target/SqlStepper.coffee * modules/weinre/target/Target.coffee * modules/weinre/target/Timeline.coffee * modules/weinre/target/WiCSSImpl.coffee * modules/weinre/target/WiDOMImpl.coffee * modules/weinre/target/WiDOMStorageImpl.coffee * modules/weinre/target/WiInspectorImpl.coffee Note, this is just the weinre source, and likely only the common and target files are implicated. But there is also some injected code from Web Inspector itself, and it showed up in a different scan I did. Bummer. > doesn't work in strict mode > --------------------------- > > Key: CB-604 > URL: https://issues.apache.org/jira/browse/CB-604 > Project: Apache Cordova > Issue Type: Bug > Components: weinre > Environment: ubuntu/windows > Reporter: hongbo lu > Assignee: Patrick Mueller > > weinre doesn't work in strict mode ,because it trys to access "func.caller" which isn't allowed in strict mode -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira