cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gord Tanner <g...@tinyhippos.com>
Subject Re: 2.2.0rc2 Monday?
Date Fri, 26 Oct 2012 17:11:12 GMT
anyone have any objections of getting this fix into blackberry for 2.2?

https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-blackberry-webworks.git;a=commit;h=6ae80d9ac480f01c2d5734656a7f33c044d11139

also I fail at teh git so if there is no objections could someone retag
blackberry for me?

On Fri, Oct 26, 2012 at 10:42 AM, Andrew Grieve <agrieve@chromium.org>wrote:

> Sounds good. I've now re-tagged the JS and Android.
>
>
> On Thu, Oct 25, 2012 at 10:56 PM, Simon MacDonald <
> simon.macdonald@gmail.com
> > wrote:
>
> > I'm still seeing the bug but I don't think it should hold up the tagging
> of
> > 2.2.0rc2 at this point. I created a small sync Plugin for testing and it
> > runs fine in my mobile spec test case. Now the same plugin called in the
> > downstream app which uses the same Android library project for Cordova
> and
> > the same .js file returns the wrong value when I call the plugin. At this
> > point I'm not convinced it is a Cordova issue.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> > On Thu, Oct 25, 2012 at 8:56 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> >
> > > Joe - my thinking here is that it's fine to re-tag and re-tag until we
> > > actually produce an RC with everything tagged. rc2 is still in the
> > process
> > > of being tagged, and until the tagging is all done, it just causes more
> > > work to scratch it and have to re-tag all of the other repos. Once we
> > > create an rc2 archive though, no more adjusting.
> > >
> > > Marcel - yes, my intention is to retag the JS with the Android changes,
> > and
> > > to update the JS in android repo and then re-tag that as well. Simon
> was
> > > still seeing a bug with one of his projects though, even after the fix,
> > so
> > > I'd like to wait for his verification before continuing.
> > >
> > >
> > > On Thu, Oct 25, 2012 at 5:13 PM, Michael Brooks <
> > michael@michaelbrooks.ca
> > > >wrote:
> > >
> > > > Sorry, just catching up on the conversations.
> > > >
> > > >
> > > > > Ey Mr. Brooks do you have a script or something that we can use to
> > > > > easily/quickly clone/create the behemoth "tag all the things"
> parent
> > > > issue
> > > > > with subtasks in JIRA? This seems like a worthwhile pursuit.
> > > >
> > > >
> > > > Just find go to the parent issue (e.g. Tag
> > > > 2.2.0rc1<https://issues.apache.org/jira/browse/CB-1622#>),
> > > > click "More Actions", and click "Clone." JIRA will do the rest by
> > > spamming
> > > > everyone.
> > > >
> > > > For the most part, I've worded each task in a generic manner, but you
> > may
> > > > need to edit the odd sub-tasks description if it mentions a version.
> > > >
> > > > Michael
> > > >
> > > > On Thu, Oct 25, 2012 at 2:08 PM, Marcel Kinard <cmarcelk@gmail.com>
> > > wrote:
> > > >
> > > > > I'm interested in the latest fix that Andrew put in the js repo:
> > > > > https://git-wip-us.apache.org/**repos/asf?p=incubator-cordova-**
> > > > > js.git;a=commitdiff;h=**97a05cb0f672ee1bfb7e9e14a0dfd4**52d7763ba9<
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commitdiff;h=97a05cb0f672ee1bfb7e9e14a0dfd452d7763ba9
> > > > >
> > > > > https://issues.apache.org/**jira/browse/CB-1745<
> > > > https://issues.apache.org/jira/browse/CB-1745>
> > > > >
> > > > > When I browse the Apache repos, I see that:
> > > > > 1) this fix was committed to the js repo after the rc2 tag. Is this
> > > > thread
> > > > > going to include this fix inside the rc2 tag?
> > > > > 2) the corresponding js artifact in the android repo needs to be
> > > > refreshed
> > > > > to pick up this fix, and I don't see that commit at all. Is someone
> > > going
> > > > > to do that? And then will the rc2 tag on this repo include this
> > > refresh?
> > > > >
> > > > > Thanks!
> > > > >
> > > > > -- Marcel Kinard
> > > > >
> > > > >
> > > > > On 10/25/2012 4:03 PM, Andrew Grieve wrote:
> > > > >
> > > > >> Okay. I'll co-ordinate with Simon on the re-tagging. He's still
> > > working
> > > > >> through one of the bugs.
> > > > >>
> > > > >>
> > > > >> On Thu, Oct 25, 2012 at 3:23 PM, Filip Maj <fil@adobe.com>
wrote:
> > > > >>
> > > > >>  You just need to delete the tag and re-add it. Then when you
push
> > > with
> > > > >>> --tags it'll move the tag to the newer commit.
> > > > >>>
> > > > >>> And yeah retagging just android is fine.
> > > > >>>
> > > > >>> On 10/25/12 12:20 PM, "Andrew Grieve" <agrieve@chromium.org>
> > wrote:
> > > > >>>
> > > > >>>  What I think we want to do is just update the existing 2.2.0rc2
> > tag
> > > to
> > > > >>>> point to HEAD, unless we want to call rc2 a fail and
move to
> rc3.
> > I
> > > > >>>> think
> > > > >>>> it'll be fine to re-tag though since only android code
changed.
> > > > >>>>
> > > > >>>> I don't know the git command for it though. git tag --foce
> > 2.2.0rc2.
> > > > but
> > > > >>>> then how to push it?
> > > > >>>>
> > > > >>>>
> > > > >>>> On Thu, Oct 25, 2012 at 3:14 PM, Filip Maj <fil@adobe.com>
> wrote:
> > > > >>>>
> > > > >>>>  To retag JS, change the value of the VERSION file, then
run a
> > build
> > > > >>>>> (jake)
> > > > >>>>>
> > > > >>>>> It will modify the 3 or 4 files that hard-code the
version into
> > > them.
> > > > >>>>> You'll need to follow up the build with a git commit
-am
> 'bumping
> > > to
> > > > >>>>> 2.2.0rcx'
> > > > >>>>>
> > > > >>>>> On 10/25/12 12:10 PM, "Andrew Grieve" <agrieve@chromium.org>
> > > wrote:
> > > > >>>>>
> > > > >>>>>  Alright. fixed up. JS should be re-tagged (what's
the command
> > for
> > > > >>>>>> doing
> > > > >>>>>> this?)
> > > > >>>>>>
> > > > >>>>>> Joe, do you want to re-tag android after you
address CB-1568?
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>> On Thu, Oct 25, 2012 at 2:46 PM, Andrew Grieve
<
> > > > agrieve@chromium.org>
> > > > >>>>>> wrote:
> > > > >>>>>>
> > > > >>>>>>  I still need to re-tag android. Just finishing
up fixes for
> > > CB-1744
> > > > >>>>>>>
> > > > >>>>>> and
> > > > >>>>>
> > > > >>>>>> CB-1745
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>> On Thu, Oct 25, 2012 at 2:45 PM, Filip Maj
<fil@adobe.com>
> > > wrote:
> > > > >>>>>>>
> > > > >>>>>>>  Cordova-mac, docs and WP7 are all that零
left
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> On 10/25/12 11:44 AM, "Herm Wong" <
> kingoftheoaks@hotmail.com>
> > > > >>>>>>>>
> > > > >>>>>>> wrote:
> > > > >>>
> > > > >>>> webOS tagged 2.2.0rc2.
> > > > >>>>>>>>>
> > > > >>>>>>>>>  From: simon.macdonald@gmail.com
> > > > >>>>>>>>>> Date: Thu, 25 Oct 2012 12:08:38
-0400
> > > > >>>>>>>>>> Subject: Re: 2.2.0rc2 Monday?
> > > > >>>>>>>>>> To: callback-dev@incubator.apache.**org<
> > > > callback-dev@incubator.apache.org>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> If I had know about the bug before
you tagged I would have
> > > > >>>>>>>>>>
> > > > >>>>>>>>> opened an
> > > > >>>>>
> > > > >>>>>> issue.
> > > > >>>>>>>>>> It was exposed by running mobile
spec on an Android 2.2
> > > emulator
> > > > >>>>>>>>>>
> > > > >>>>>>>>> while
> > > > >>>>>>>> I
> > > > >>>>>>>>
> > > > >>>>>>>>> was in the gym. Over 50% of the automated
tests failed.
> > > Basically
> > > > >>>>>>>>>> anything
> > > > >>>>>>>>>> that was returning a string payload
from the Java side did
> > not
> > > > >>>>>>>>>>
> > > > >>>>>>>>> work.
> > > > >>>>>
> > > > >>>>>> Simon Mac Donald
> > > > >>>>>>>>>> http://hi.im/simonmacdonald
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> On Wed, Oct 24, 2012 at 4:38
PM, Joe Bowser <
> > > bowserj@gmail.com>
> > > > >>>>>>>>>>
> > > > >>>>>>>>> wrote:
> > > > >>>>>>>>
> > > > >>>>>>>>> What bug? Do we have a way to test
it?
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> We're still in an RC, so
it's ok for there to be bugs.
> That
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>> being
> > > > >>>>>
> > > > >>>>>> said, I wish this was in JIRA so that I knew
about it before
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>> tagging.
> > > > >>>>>>>>
> > > > >>>>>>>>> Joe
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> On Wed, Oct 24, 2012 at 1:33
PM, Simon MacDonald
> > > > >>>>>>>>>>> <simon.macdonald@gmail.com>
wrote:
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>> Okay JS and Android re-tagged
to 2.2.0 cause of soem
> > Android
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>> 2.2
> > > > >>>>>
> > > > >>>>>> craziness.
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>> Simon Mac Donald
> > > > >>>>>>>>>>>> http://hi.im/simonmacdonald
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>> On Wed, Oct 24, 2012
at 4:24 PM, Simon MacDonald
> > > > >>>>>>>>>>>> <simon.macdonald@gmail.com>**wrote:
> > > > >>>>>>>>>>>>
> > > > >>>>>>>>>>>>  I have to re-tag JS
and Android. There is a bug that
> > causes
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> almost
> > > > >>>>>>>>
> > > > >>>>>>>>> everything to fail on Android 2.2.
The code is in the
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> Android
> > > > >>>>>
> > > > >>>>>> version of
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> exec so other platforms will
not need to pick up the new
> > JS.
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> Simon Mac Donald
> > > > >>>>>>>>>>>>> http://hi.im/simonmacdonald
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> On Wed, Oct 24, 2012
at 4:00 PM, Joe Bowser
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>>>>> <bowserj@gmail.com
> > > > >>>>>
> > > > >>>>>> wrote:
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> Tagged Android. It's ready
to go!
> > > > >>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>> On Wed, Oct 24,
2012 at 12:57 PM, Shazron
> > > > >>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>> <shazron@gmail.com>
> > > > >>>>>
> > > > >>>>>> wrote:
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> I'll update the iOS bits
right now.
> > > > >>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>> On Wed, Oct
24, 2012 at 11:57 AM, Filip Maj
> > > > >>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>> <fil@adobe.com>
> > > > >>>>>
> > > > >>>>>> wrote:
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> JS. Mobile spec and hello
world app is tagged.
> > > > >>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>> Gogo!
> > > > >>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>> On 10/19/12
1:41 AM, "Leutwyler, Markus"
> > > > >>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>> <markus.leutwyler@hp.com>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> wrote:
> > > > >>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>> +1
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>>> Let
me know if you need any help
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>>> Markus
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>>> -----Original
Message-----
> > > > >>>>>>>>>>>>>>>>> From:
Filip Maj [mailto:fil@adobe.com]
> > > > >>>>>>>>>>>>>>>>> Sent:
Donnerstag, 18. Oktober 2012 20:47
> > > > >>>>>>>>>>>>>>>>> To:
callback-dev@incubator.apache.**org<
> > > > callback-dev@incubator.apache.org>
> > > > >>>>>>>>>>>>>>>>> Subject:
2.2.0rc2 Monday?
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>>> That
cool? Would be good to get a cordova-js
> friendly
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>> version
> > > > >>>>>>>>
> > > > >>>>>>>>> of
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> webos
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>> out there.
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>>>>>
> > > > >>>>>>>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>
> > > > >>>
> > > > >
> > > >
> > >
> >
>



-- 
Gord Tanner
Senior Developer / Code Poet
tinyHippos Inc.
@tinyhippos

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message