Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1257)
Subject: Re: [jira] [Resolved] (CB-442) FileTransfer download should not block
 the UI
From: Marcus Wu <wum@bibliolabs.com>
In-Reply-To: 
 <CAE6O_-YSzyHujcG+b5Lho+3+tgW0knWqif8UdL8x9bfgMq65Rw@mail.gmail.com>
Date: Tue, 10 Apr 2012 12:16:43 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <1FD9881B-9790-4512-9D0C-998F59D66260@bibliolabs.com>
References: <955762835.235.1333750577421.JavaMail.tomcat@hel.zones.apache.org>
 <133F3F67-3DC5-4B2E-A873-997DB313C0CC@bibliolabs.com>
 <CAE6O_-ZMsk-ejRuiNULfvkbKd+KONnDzMFf4-w07Liv8j4KfGw@mail.gmail.com>
 <CAE6O_-YSzyHujcG+b5Lho+3+tgW0knWqif8UdL8x9bfgMq65Rw@mail.gmail.com>
To: callback-dev@incubator.apache.org

As in revert the download blocking fixes for 1.6.0? I don't think that =
will entirely fix the issue as the callback casts are also causing =
problems with the 1.6.0 javascript.

On Apr 10, 2012, at 11:59 AM, Shazron wrote:

> I'll have to revert the change for 1.6.0
>=20
> On Tue, Apr 10, 2012 at 8:56 AM, Shazron <shazron@gmail.com> wrote:
>> Re-open the issue
>>=20
>> On Tue, Apr 10, 2012 at 7:19 AM, Marcus Wu <wum@bibliolabs.com> =
wrote:
>>> I've noticed some problems with my fix for this since I committed =
it. I noticed two things.
>>>=20
>>> First, my error callbacks were never being called. This was because =
I didn't realize the first time around that there is a different call =
for converting the error callback string.
>>> Second, the success callbacks were failing. I tracked this down to =
errors in the success callback string due to the cast now being =
integrated into the success callback code.
>>>=20
>>> I have some changes to properly call the error callbacks and to =
eliminate the cast in calling the success callback for the download. I =
was about to create another pull request when I realized that the upload =
code is also using a cast which appears to no longer be valid (although =
I am not as familiar with this code as I am sure others are). Should I =
go ahead and eliminate that upload cast before creating another pull =
request?
>>>=20
>>> Another question is does a ticket need to be created (or the =
original ticket reopened) prior to creating a pull request?
>>>=20
>>> Thanks,
>>> Marcus
>>>=20
>>> On Apr 6, 2012, at 6:16 PM, Shazron Abdullah (Resolved) (JIRA) =
wrote:
>>>=20
>>>>=20
>>>>     [ =
https://issues.apache.org/jira/browse/CB-442?page=3Dcom.atlassian.jira.plu=
gin.system.issuetabpanels:all-tabpanel ]
>>>>=20
>>>> Shazron Abdullah resolved CB-442.
>>>> ---------------------------------
>>>>=20
>>>>       Resolution: Fixed
>>>>    Fix Version/s: 1.6.0
>>>>=20
>>>> Fix commit merged in (from Marcus Wu): =
http://git-wip-us.apache.org/repos/asf?p=3Dincubator-cordova-ios.git;a=3Dc=
ommit;h=3D2bf695b0bc7ec47e2ec1f40842035106811e35f2
>>>>=20
>>>>> FileTransfer download should not block the UI
>>>>> ---------------------------------------------
>>>>>=20
>>>>>                Key: CB-442
>>>>>                URL: https://issues.apache.org/jira/browse/CB-442
>>>>>            Project: Apache Callback
>>>>>         Issue Type: Bug
>>>>>         Components: iOS
>>>>>   Affects Versions: Master
>>>>>           Reporter: Shazron Abdullah
>>>>>           Assignee: Shazron Abdullah
>>>>>            Fix For: 1.6.0
>>>>>=20
>>>>>        Attachments: CB-442-test.html
>>>>>=20
>>>>>=20
>>>>> Right now the way it downloads items, it blocks the UI:
>>>>> =
https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Cla=
sses/CDVFileTransfer.m#L167
>>>>> NSData dataWithContentsOfUrl:
>>>>> =
https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/Fou=
ndation/Classes/NSData_Class/Reference/Reference.html
>>>>> Change to an async download method.
>>>>=20
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> If you think it was sent incorrectly, please contact your JIRA =
administrators: =
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>> For more information on JIRA, see: =
http://www.atlassian.com/software/jira
>>>>=20
>>>>=20
>>>=20